Re-apply: Warning for framework headers using double quote includesIntroduce -Wquoted-include-in-framework-header, which should fire a warningwhenever a quote include appears in a framework header
Re-apply: Warning for framework headers using double quote includesIntroduce -Wquoted-include-in-framework-header, which should fire a warningwhenever a quote include appears in a framework header and suggest a fix-it.For instance, for header A.h added in the tests, this is how the warning lookslike:./A.framework/Headers/A.h:2:10: warning: double-quoted include "A0.h" in framework header, expected angle-bracketed instead [-Wquoted-include-in-framework-header]#include "A0.h" ^~~~~~ <A/A0.h>./A.framework/Headers/A.h:3:10: warning: double-quoted include "B.h" in framework header, expected angle-bracketed instead [-Wquoted-include-in-framework-header]#include "B.h" ^~~~~ <B.h>This helps users to prevent frameworks from using local headers when in factthey should be targetting system level ones.The warning is off by default.Differential Revision: https://reviews.llvm.org/D47157rdar://problem/37077034llvm-svn: 335375
show more ...
Revert "Warning for framework headers using double quote includes"This reverts commit 9b5ff2db7e31c4bb11a7d468260b068b41c7c285.Broke bots:http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/
Revert "Warning for framework headers using double quote includes"This reverts commit 9b5ff2db7e31c4bb11a7d468260b068b41c7c285.Broke bots:http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/11315http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/10411/steps/test-check-all/logs/stdiollvm-svn: 335195
Warning for framework headers using double quote includesIntroduce -Wquoted-include-in-framework-header, which should fire a warningwhenever a quote include appears in a framework header and sugge
Warning for framework headers using double quote includesIntroduce -Wquoted-include-in-framework-header, which should fire a warningwhenever a quote include appears in a framework header and suggest a fix-it.For instance, for header A.h added in the tests, this is how the warning lookslike:./A.framework/Headers/A.h:2:10: warning: double-quoted include "A0.h" in framework header, expected angle-bracketed instead [-Wquoted-include-in-framework-header]#include "A0.h" ^~~~~~ <A/A0.h>./A.framework/Headers/A.h:3:10: warning: double-quoted include "B.h" in framework header, expected angle-bracketed instead [-Wquoted-include-in-framework-header]#include "B.h" ^~~~~ <B.h>This helps users to prevent frameworks from using local headers when in factthey should be targetting system level ones.The warning is off by default.Differential Revision: https://reviews.llvm.org/D47157rdar://problem/37077034llvm-svn: 335184