selftest: rtc: skip some tests if the alarm only supports minutes

There are alarms which have only minute-granularity. The RTC core
already has a flag to describe them. Use this flag to skip tests w

selftest: rtc: skip some tests if the alarm only supports minutes

There are alarms which have only minute-granularity. The RTC core
already has a flag to describe them. Use this flag to skip tests which
require the alarm to support seconds.

Signed-off-by: Wolfram Sang <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Alexandre Belloni <[email protected]>

show more ...

selftest: rtc: Add to check rtc alarm status for alarm related test

In alarm_wkalm_set and alarm_wkalm_set_minute test, they use different
ioctl (RTC_ALM_SET/RTC_WKALM_SET) for alarm feature detecti

selftest: rtc: Add to check rtc alarm status for alarm related test

In alarm_wkalm_set and alarm_wkalm_set_minute test, they use different
ioctl (RTC_ALM_SET/RTC_WKALM_SET) for alarm feature detection. They will
skip testing if RTC_ALM_SET/RTC_WKALM_SET ioctl returns an EINVAL error
code. This design may miss detecting real problems when the
efi.set_wakeup_time() return errors and then RTC_ALM_SET/RTC_WKALM_SET
ioctl returns an EINVAL error code with RTC_FEATURE_ALARM enabled.

In order to make rtctest more explicit and robust, we propose to use
RTC_PARAM_GET ioctl interface to check rtc alarm feature state before
running alarm related tests. If the kernel does not support RTC_PARAM_GET
ioctl interface, we will fallback to check the error number of
(RTC_ALM_SET/RTC_WKALM_SET) ioctl call for alarm feature detection.

Requires commit 101ca8d05913b ("rtc: efi: Enable SET/GET WAKEUP services
as optional")

Reviewed-by: Koba Ko <[email protected]>
Reviewed-by: Matthew R. Ochs <[email protected]>
Signed-off-by: Joseph Jang <[email protected]>
Acked-by: Alexandre Belloni <[email protected]>
Signed-off-by: Shuah Khan <[email protected]>

show more ...

selftest: rtc: Check if could access /dev/rtc0 before testing

The rtctest requires the read permission on /dev/rtc0. The rtctest will
be skipped if the /dev/rtc0 is not readable.

Reviewed-by: Koba

selftest: rtc: Check if could access /dev/rtc0 before testing

The rtctest requires the read permission on /dev/rtc0. The rtctest will
be skipped if the /dev/rtc0 is not readable.

Reviewed-by: Koba Ko <[email protected]>
Reviewed-by: Matthew R. Ochs <[email protected]>
Signed-off-by: Joseph Jang <[email protected]>
Acked-by: Alexandre Belloni <[email protected]>
Signed-off-by: Shuah Khan <[email protected]>

show more ...

selftests: harness: remove unneeded __constructor_order_last()

__constructor_order_last() is unneeded.

If __constructor_order_last() is not called on backward-order systems,
__constructor_order wil

selftests: harness: remove unneeded __constructor_order_last()

__constructor_order_last() is unneeded.

If __constructor_order_last() is not called on backward-order systems,
__constructor_order will remain 0 instead of being set to
_CONSTRUCTOR_ORDER_BACKWARD (= -1).

__LIST_APPEND() will still take the 'else' branch, so there is no
difference in the behavior.

Signed-off-by: Masahiro Yamada <[email protected]>
Signed-off-by: Shuah Khan <[email protected]>

show more ...

selftests: rtc: skip when RTC is not present

There is no point in failing the tests when RTC is not present.

Reported-by: Linux Kernel Functional Testing <[email protected]>
Signed-off-by: Alexandre

selftests: rtc: skip when RTC is not present

There is no point in failing the tests when RTC is not present.

Reported-by: Linux Kernel Functional Testing <[email protected]>
Signed-off-by: Alexandre Belloni <[email protected]>
Tested-by: Daniel Diaz <[email protected]>
Signed-off-by: Shuah Khan <[email protected]>

show more ...

selftests/rtc: continuously read RTC in a loop for 30s

Some problems with reading the RTC time may happen rarely, for example
while the RTC is updating. So read the RTC many times to catch these
pro

selftests/rtc: continuously read RTC in a loop for 30s

Some problems with reading the RTC time may happen rarely, for example
while the RTC is updating. So read the RTC many times to catch these
problems. For example, a previous attempt for my
commit ea6fa4961aab ("rtc: mc146818-lib: fix RTC presence check")
was incorrect and would have triggered this selftest.

To avoid the risk of damaging the hardware, wait 11ms before consecutive
reads.

In rtc_time_to_timestamp I copied values manually instead of casting -
just to be on the safe side. The 11ms wait period was chosen so that it is
not a divisor of 1000ms.

Signed-off-by: Mateusz Jończyk <[email protected]>
Cc: Alessandro Zummo <[email protected]>
Cc: Alexandre Belloni <[email protected]>
Cc: Shuah Khan <[email protected]>
Signed-off-by: Shuah Khan <[email protected]>

show more ...

selftests: rtc: rtctest: specify timeouts

uie_read is a commonly failing test that will block forever on buggy rtc
drivers. Shorten its timeout so it fails earlier. Also increase the timeout
for the

selftests: rtc: rtctest: specify timeouts

uie_read is a commonly failing test that will block forever on buggy rtc
drivers. Shorten its timeout so it fails earlier. Also increase the timeout
for the two alarm test on a minute boundary.

Signed-off-by: Alexandre Belloni <[email protected]>
Signed-off-by: Shuah Khan <[email protected]>

show more ...

selftests: rtc: rtctest: add alarm test on minute boundary

Unfortunately, some RTC don't have a second resolution for alarm so also
test for alarm on a minute boundary.

Signed-off-by: Alexandre Bel

selftests: rtc: rtctest: add alarm test on minute boundary

Unfortunately, some RTC don't have a second resolution for alarm so also
test for alarm on a minute boundary.

Signed-off-by: Alexandre Belloni <[email protected]>
Signed-off-by: Shuah Khan <[email protected]>

show more ...

selftests: rtc: rtctest: fix alarm tests

Return values for select are not checked properly and timeouts may not be
detected.

Signed-off-by: Alexandre Belloni <[email protected]>
Signed-

selftests: rtc: rtctest: fix alarm tests

Return values for select are not checked properly and timeouts may not be
detected.

Signed-off-by: Alexandre Belloni <[email protected]>
Signed-off-by: Shuah Khan <[email protected]>

show more ...

selftests: rtc: rework rtctest

Rework rtctest to use the test harness to better handle skipping tests
(e.g. when alarms are not available). Also, it now handles timeout so it
will not block expectin

selftests: rtc: rework rtctest

Rework rtctest to use the test harness to better handle skipping tests
(e.g. when alarms are not available). Also, it now handles timeout so it
will not block expecting an alarm that never comes.

Signed-off-by: Alexandre Belloni <[email protected]>
Signed-off-by: Shuah Khan (Samsung OSG) <[email protected]>

show more ...

selftests: move RTC tests to rtc subfolder

Move the RTC tests out of the timers folder as they are mostly unrelated.
Keep rtcpie in timers as it only test hrtimers.

Signed-off-by: Alexandre Belloni

selftests: move RTC tests to rtc subfolder

Move the RTC tests out of the timers folder as they are mostly unrelated.
Keep rtcpie in timers as it only test hrtimers.

Signed-off-by: Alexandre Belloni <[email protected]>
Signed-off-by: Shuah Khan (Samsung OSG) <[email protected]>

show more ...