perf test perftool_testsuite: Return correct value for skipping

In 'perf test', a return value 2 represents that the test case was
skipped. Fix this value for perftool_testsuite test cases to
differ

perf test perftool_testsuite: Return correct value for skipping

In 'perf test', a return value 2 represents that the test case was
skipped. Fix this value for perftool_testsuite test cases to
differentiate between skip and pass values.

Signed-off-by: Veronika Molnarova <[email protected]>
Cc: Ian Rogers <[email protected]>
Cc: Namhyung Kim <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Michael Petlan <[email protected]>
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>

show more ...

perf test perftool_testsuite: Add missing description

Properly name the test cases of perftool_testsuite instead of the
license being taken as the name for 'perf test'.

Signed-off-by: Veronika Moln

perf test perftool_testsuite: Add missing description

Properly name the test cases of perftool_testsuite instead of the
license being taken as the name for 'perf test'.

Signed-off-by: Veronika Molnarova <[email protected]>
Cc: Ian Rogers <[email protected]>
Cc: Namhyung Kim <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Michael Petlan <[email protected]>
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>

show more ...

perf tools tests shell base_probe: Enhance print_overall_results to print summary information

Currently print_overall_results prints the number of fails in the
summary, example from base_probe tests

perf tools tests shell base_probe: Enhance print_overall_results to print summary information

Currently print_overall_results prints the number of fails in the
summary, example from base_probe tests in testsuite_probe:

## [ FAIL ] ## perf_probe :: test_invalid_options SUMMARY ::
11 failures found

test_invalid_options contains multiple tests and out of that 11 failed.
Sometimes it could happen that it is due to missing dependency in the
build or environment dependency.

Example, perf probe -L requires DWARF enabled. otherwise
it fails as below:

./perf probe -L
Error: switch `L' is not available because NO_DWARF=1

"-L" is tested as one of the option in:

for opt in '-a' '-d' '-L' '-V'; do
<<perf probe test>>
print_results $PERF_EXIT_CODE $CHECK_EXIT_CODE "missing argument
for $opt"

Here -a and -d doesn't require DWARF. Similarly there are few other
tests requiring DWARF.

To hint the user that missing DWARF could be one issue, update
print_overall_results to print a comment string along with summary
hinting the possible cause. Update test_invalid_options.sh and
test_line_semantics.sh to pass the info about DWARF requirement since
these tests failed when perf is built without DWARF.

Use the check for presence of DWARF with "perf check feature" and append
the hint message based on the result.

With the change:

## [ FAIL ] ## perf_probe :: test_invalid_options SUMMARY ::
11 failures found :: Some of the tests need DWARF to run

Reviewed-by: Kajol Jain <[email protected]>
Signed-off-by: Athira Rajeev <[email protected]>
Cc: Adrian Hunter <[email protected]>
Cc: Disha Goel <[email protected]>
Cc: Ian Rogers <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Madhavan Srinivasan <[email protected]>
Cc: Michael Petlan <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Veronika Molnarova <[email protected]>
Cc: [email protected]
Link: https://lore.kernel.org/r/[email protected]
[ Minor edits changing "dwarf" to "DWARF" as its an acronym ]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>

show more ...

perf testsuite probe: Add test for invalid options

Test if various incompatible options are correctly handled-rejected.
It is run as a part of perftool-testsuite_probe test case.

Signed-off-by: Ver

perf testsuite probe: Add test for invalid options

Test if various incompatible options are correctly handled-rejected.
It is run as a part of perftool-testsuite_probe test case.

Signed-off-by: Veronika Molnarova <[email protected]>
Cc: Athira Rajeev <[email protected]>
Cc: Ian Rogers <[email protected]>
Cc: Masami Hiramatsu <[email protected]>
Cc: Namhyung Kim <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Michael Petlan <[email protected]>
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>

show more ...