ALSA: msnd: Use standard print APIUse the standard print API with dev_*() instead of the old house-bakedone. It gives better information and allows dynamically control ofdebug prints.Reviewed-
ALSA: msnd: Use standard print APIUse the standard print API with dev_*() instead of the old house-bakedone. It gives better information and allows dynamically control ofdebug prints.Reviewed-by: Jaroslav Kysela <[email protected]>Signed-off-by: Takashi Iwai <[email protected]>Link: https://patch.msgid.link/[email protected]
show more ...
ALSA: isa: Use *-y instead of *-objs in Makefile*-objs suffix is reserved rather for (user-space) host programs whileusually *-y suffix is used for kernel drivers (although *-objs worksfor that p
ALSA: isa: Use *-y instead of *-objs in Makefile*-objs suffix is reserved rather for (user-space) host programs whileusually *-y suffix is used for kernel drivers (although *-objs worksfor that purpose for now).Let's correct the old usages of *-objs in Makefiles.Signed-off-by: Takashi Iwai <[email protected]>Reviewed-by: Andy Shevchenko <[email protected]>Reviewed-by: Jaroslav Kysela <[email protected]>Link: https://lore.kernel.org/r/[email protected]
ALSA: msnd: Use proper mmap methodThe old ISA MSND driver basically maps the iomem as the DMA buffer.For this type of buffer, we have already the standard mmap helper,snd_pcm_lib_mmap_iomem(). C
ALSA: msnd: Use proper mmap methodThe old ISA MSND driver basically maps the iomem as the DMA buffer.For this type of buffer, we have already the standard mmap helper,snd_pcm_lib_mmap_iomem(). Correct the PCM info, set the DMA addressand use the standard helper for handling the mmap on all architecturesproperly.Link: https://lore.kernel.org/r/[email protected]Signed-off-by: Takashi Iwai <[email protected]>
ALSA: msnd: Allocate resources with device-managed APIsThis patch converts the resource management in ISA msnd drivers withdevres as a clean up. Each manual resource management is convertedwith
ALSA: msnd: Allocate resources with device-managed APIsThis patch converts the resource management in ISA msnd drivers withdevres as a clean up. Each manual resource management is convertedwith the corresponding devres helper. The remove callback becamesuperfluous and dropped.This should give no user-visible functional changes.Link: https://lore.kernel.org/r/[email protected]Signed-off-by: Takashi Iwai <[email protected]>
isa: Make the remove callback for isa drivers return voidThe driver core ignores the return value of the remove callback, sodon't give isa drivers the chance to provide a value.Adapt all isa_dri
isa: Make the remove callback for isa drivers return voidThe driver core ignores the return value of the remove callback, sodon't give isa drivers the chance to provide a value.Adapt all isa_drivers with a remove callbacks accordingly; they allreturn 0 unconditionally anyhow.Acked-by: Marc Kleine-Budde <[email protected]> # for drivers/net/can/sja1000/tscan1.cAcked-by: William Breathitt Gray <[email protected]>Acked-by: Wolfram Sang <[email protected]> # for drivers/i2c/Reviewed-by: Takashi Iway <[email protected]> # for sound/Reviewed-by: Hans Verkuil <[email protected]> # for drivers/media/Signed-off-by: Uwe Kleine-König <[email protected]>Link: https://lore.kernel.org/r/[email protected]Signed-off-by: Takashi Iwai <[email protected]>
ALSA: Use fallthrough pseudo-keywordReplace the existing /* fall through */ comments and its variants withthe new pseudo-keyword macro fallthrough[1]. Also, remove unnecessaryfall-through marking
ALSA: Use fallthrough pseudo-keywordReplace the existing /* fall through */ comments and its variants withthe new pseudo-keyword macro fallthrough[1]. Also, remove unnecessaryfall-through markings when it is the case.[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-throughSigned-off-by: Gustavo A. R. Silva <[email protected]>Link: https://lore.kernel.org/r/20200708203236.GA5112@embeddedorSigned-off-by: Takashi Iwai <[email protected]>
remove ioremap_nocache and devm_ioremap_nocacheioremap has provided non-cached semantics by default since the Linux 2.6days, so remove the additional ioremap_nocache interface.Signed-off-by: Chr
remove ioremap_nocache and devm_ioremap_nocacheioremap has provided non-cached semantics by default since the Linux 2.6days, so remove the additional ioremap_nocache interface.Signed-off-by: Christoph Hellwig <[email protected]>Acked-by: Arnd Bergmann <[email protected]>
ALSA: isa: Constify snd_kcontrol_new itemsMost of snd_kcontrol_new definitions are read-only and passed as-is.Let's declare them as const for further optimization.There should be no functional c
ALSA: isa: Constify snd_kcontrol_new itemsMost of snd_kcontrol_new definitions are read-only and passed as-is.Let's declare them as const for further optimization.There should be no functional changes by this patch.Link: https://lore.kernel.org/r/[email protected]Signed-off-by: Takashi Iwai <[email protected]>
ALSA: isa: Constify snd_device_ops definitionsNow we may declare const for snd_device_ops definitions, so let's doit for optimization.There should be no functional changes by this patch.Link:
ALSA: isa: Constify snd_device_ops definitionsNow we may declare const for snd_device_ops definitions, so let's doit for optimization.There should be no functional changes by this patch.Link: https://lore.kernel.org/r/[email protected]Signed-off-by: Takashi Iwai <[email protected]>
ALSA: msnd: Support PCM sync_stopThe driver invokes snd_pcm_period_elapsed() simply from the interrupthandler. Set card->sync_irq for enabling the missing sync_stop PCMoperation.Link: https://
ALSA: msnd: Support PCM sync_stopThe driver invokes snd_pcm_period_elapsed() simply from the interrupthandler. Set card->sync_irq for enabling the missing sync_stop PCMoperation.Link: https://lore.kernel.org/r/[email protected]Signed-off-by: Takashi Iwai <[email protected]>
ALSA: isa: Drop superfluous ioctl PCM opsPCM core deals the empty ioctl field now as default(*).Let's kill the redundant lines.(*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")Link:
ALSA: isa: Drop superfluous ioctl PCM opsPCM core deals the empty ioctl field now as default(*).Let's kill the redundant lines.(*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")Link: https://lore.kernel.org/r/[email protected]Signed-off-by: Takashi Iwai <[email protected]>
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of th
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later version this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more details you should have received a copy of the gnu general public license along with this program if not write to the free software foundation inc 59 temple place suite 330 boston ma 02111 1307 usaextracted by the scancode license scanner the SPDX license identifier GPL-2.0-or-laterhas been chosen to replace the boilerplate/reference in 1334 file(s).Signed-off-by: Thomas Gleixner <[email protected]>Reviewed-by: Allison Randal <[email protected]>Reviewed-by: Richard Fontana <[email protected]>Cc: [email protected]Link: https://lkml.kernel.org/r/[email protected]Signed-off-by: Greg Kroah-Hartman <[email protected]>
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of th
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later versionextracted by the scancode license scanner the SPDX license identifier GPL-2.0-or-laterhas been chosen to replace the boilerplate/reference in 3029 file(s).Signed-off-by: Thomas Gleixner <[email protected]>Reviewed-by: Allison Randal <[email protected]>Cc: [email protected]Link: https://lkml.kernel.org/r/[email protected]Signed-off-by: Greg Kroah-Hartman <[email protected]>
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later version this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more details you should have received a copy of the gnu general public license along with this program if not write to the free software foundation inc 675 mass ave cambridge ma 02139 usaextracted by the scancode license scanner the SPDX license identifier GPL-2.0-or-laterhas been chosen to replace the boilerplate/reference in 441 file(s).Signed-off-by: Thomas Gleixner <[email protected]>Reviewed-by: Michael Ellerman <[email protected]> (powerpc)Reviewed-by: Richard Fontana <[email protected]>Reviewed-by: Allison Randal <[email protected]>Reviewed-by: Kate Stewart <[email protected]>Cc: [email protected]Link: https://lkml.kernel.org/r/[email protected]Signed-off-by: Greg Kroah-Hartman <[email protected]>
ALSA: msnd: Use NULL instead of 0Fix a sparse warning: sound/isa/msnd/msnd_pinnacle.c:813:1: warning: Using plain integer as NULL pointerSigned-off-by: Takashi Iwai <[email protected]>
ALSA: msnd: Fix the default sample sizesThe default sample sizes set by msnd driver are bogus; it sets ALSAPCM format, not the actual bit width.Signed-off-by: Takashi Iwai <[email protected]>
ALSA: msnd: Add missing __iomem annotationsThe io-mapped buffers used in msnd drivers need __iomem annotations.This fixes sparse warnings like: sound/isa/msnd/msnd_pinnacle.c:172:45: warning: i
ALSA: msnd: Add missing __iomem annotationsThe io-mapped buffers used in msnd drivers need __iomem annotations.This fixes sparse warnings like: sound/isa/msnd/msnd_pinnacle.c:172:45: warning: incorrect type in initializer (different address spaces)Signed-off-by: Takashi Iwai <[email protected]>
sound: Use octal not symbolic permissionsConvert the S_<FOO> symbolic permissions to their octal equivalents asusing octal and not symbolic permissions is preferred by many as morereadable.see:
sound: Use octal not symbolic permissionsConvert the S_<FOO> symbolic permissions to their octal equivalents asusing octal and not symbolic permissions is preferred by many as morereadable.see: https://lkml.org/lkml/2016/8/2/1945Done with automated conversion via:$ ./scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace <files...>Miscellanea:o Wrapped one multi-line call to a single lineSigned-off-by: Joe Perches <[email protected]>Acked-by: Vinod Koul <[email protected]>Signed-off-by: Takashi Iwai <[email protected]>
License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine
License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart <[email protected]>Reviewed-by: Philippe Ombredanne <[email protected]>Reviewed-by: Thomas Gleixner <[email protected]>Signed-off-by: Greg Kroah-Hartman <[email protected]>
ALSA: isa: make snd_pcm_hardware constMake these const as they are only used in a copy operation.Done using Coccinelle.Signed-off-by: Bhumika Goyal <[email protected]>Signed-off-by: Takashi Iw
ALSA: isa: make snd_pcm_hardware constMake these const as they are only used in a copy operation.Done using Coccinelle.Signed-off-by: Bhumika Goyal <[email protected]>Signed-off-by: Takashi Iwai <[email protected]>
ALSA: msnd: constify pnp_card_device_idpnp_card_device_id are not supposed to change at runtime. All functionsworking with pnp_card_device_id provided by <linux/pnp.h> work withconst pnp_card_dev
ALSA: msnd: constify pnp_card_device_idpnp_card_device_id are not supposed to change at runtime. All functionsworking with pnp_card_device_id provided by <linux/pnp.h> work withconst pnp_card_device_id. So mark the non-const structs as const.Signed-off-by: Arvind Yadav <[email protected]>Signed-off-by: Takashi Iwai <[email protected]>
ALSA: msnd: constify snd_pcm_ops structuressnd_pcm_ops are not supposed to change at runtime. All functionsworking with snd_pcm_ops provided by <sound/pcm.h> work withconst snd_pcm_ops. So mark t
ALSA: msnd: constify snd_pcm_ops structuressnd_pcm_ops are not supposed to change at runtime. All functionsworking with snd_pcm_ops provided by <sound/pcm.h> work withconst snd_pcm_ops. So mark the non-const structs as const.Signed-off-by: Arvind Yadav <[email protected]>Signed-off-by: Takashi Iwai <[email protected]>
ALSA: msnd: Optimize / harden DSP and MIDI loopsThe ISA msnd drivers have loops fetching the ring-buffer head, tailand size values inside the loops. Such codes are inefficient andfragile.This
ALSA: msnd: Optimize / harden DSP and MIDI loopsThe ISA msnd drivers have loops fetching the ring-buffer head, tailand size values inside the loops. Such codes are inefficient andfragile.This patch optimizes it, and also adds the sanity check to avoid theendless loops.Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196131Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196133Signed-off-by: Takashi Iwai <[email protected]>
Annotate hardware config module parameters in sound/isa/When the kernel is running in secure boot mode, we lock down the kernel toprevent userspace from modifying the running kernel image. Whilst
Annotate hardware config module parameters in sound/isa/When the kernel is running in secure boot mode, we lock down the kernel toprevent userspace from modifying the running kernel image. Whilst thisincludes prohibiting access to things like /dev/mem, it must also preventaccess by means of configuring driver modules in such a way as to cause adevice to access or modify the kernel image.To this end, annotate module_param* statements that refer to hardwareconfiguration and indicate for future reference what type of parameter theyspecify. The parameter parser in the core sees this information and canskip such parameters with an error message if the kernel is locked down.The module initialisation then runs as normal, but just sees whatever thedefault values for those parameters is.Note that we do still need to do the module initialisation because somedrivers have viable defaults set in case parameters aren't specified andsome drivers support automatic configuration (e.g. PNP or PCI) in additionto manually coded parameters.This patch annotates drivers in sound/isa/.Suggested-by: Alan Cox <[email protected]>Signed-off-by: David Howells <[email protected]>cc: Jaroslav Kysela <[email protected]>cc: Takashi Iwai <[email protected]>cc: [email protected]
sched/headers: Prepare to move signal wakeup & sigpending methods from <linux/sched.h> into <linux/sched/signal.h>Fix up affected files that include this signal functionality via sched.h.Acked-by
sched/headers: Prepare to move signal wakeup & sigpending methods from <linux/sched.h> into <linux/sched/signal.h>Fix up affected files that include this signal functionality via sched.h.Acked-by: Linus Torvalds <[email protected]>Cc: Mike Galbraith <[email protected]>Cc: Peter Zijlstra <[email protected]>Cc: Thomas Gleixner <[email protected]>Cc: [email protected]Signed-off-by: Ingo Molnar <[email protected]>
12