Get rid of 'remove_new' relic from platform driver structThe continual trickle of small conversion patches is grating on me, andis really not helping. Just get rid of the 'remove_new' memberfunc
Get rid of 'remove_new' relic from platform driver structThe continual trickle of small conversion patches is grating on me, andis really not helping. Just get rid of the 'remove_new' memberfunction, which is just an alias for the plain 'remove', and had acomment to that effect: /* * .remove_new() is a relic from a prototype conversion of .remove(). * New drivers are supposed to implement .remove(). Once all drivers are * converted to not use .remove_new any more, it will be dropped. */This was just a tree-wide 'sed' script that replaced '.remove_new' with'.remove', with some care taken to turn a subsequent tab into two tabsto make things line up.I did do some minimal manual whitespace adjustment for places that usedspaces to line things up.Then I just removed the old (sic) .remove_new member function, and thisis the end result. No more unnecessary conversion noise.Signed-off-by: Linus Torvalds <[email protected]>
show more ...
samples: qmi: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error
samples: qmi: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is ignored (apartfrom emitting a warning) and this typically results in resource leaks.To improve here there is a quest to make the remove callback returnvoid. In the first step of this quest all drivers are converted to.remove_new(), which already returns void. Eventually after all driversare converted, .remove_new() will be renamed to .remove().Trivially convert this driver from always returning zero in the removecallback to the void returning variant.Link: https://lore.kernel.org/r/d30beb557e0e97ea194028f62d3c4c10841d3e7c.1709886922.git.u.kleine-koenig@pengutronix.deSigned-off-by: Uwe Kleine-König <[email protected]>
soc: qcom: qmi: use const for struct qmi_elem_infoCurrently all usage of struct qmi_elem_info, which is used to definethe QMI message encoding/decoding rules, does not use const. Thisprevents cli
soc: qcom: qmi: use const for struct qmi_elem_infoCurrently all usage of struct qmi_elem_info, which is used to definethe QMI message encoding/decoding rules, does not use const. Thisprevents clients from registering const arrays. Since these arrays arealways pre-defined, they should be const, so add the const qualifierto all places in the QMI interface where struct qmi_elem_info is used.Once this patch is in place, clients can independently update theirpre-defined arrays to be const, as demonstrated in the QMI samplecode.Signed-off-by: Jeff Johnson <[email protected]>Signed-off-by: Bjorn Andersson <[email protected]>Link: https://lore.kernel.org/r/[email protected]
samples: qmi: Constify static qmi opsThe only usage of qmi_sample_handlers[] and lookup_ops is to pass theiraddresses to qmi_handle_init() which accepts const pointers to bothqmi_ops and qmi_msg_
samples: qmi: Constify static qmi opsThe only usage of qmi_sample_handlers[] and lookup_ops is to pass theiraddresses to qmi_handle_init() which accepts const pointers to bothqmi_ops and qmi_msg_handler. Make them const to allow the compiler toput them in read-only memory.Signed-off-by: Rikard Falkeborn <[email protected]>Link: https://lore.kernel.org/r/[email protected]Signed-off-by: Bjorn Andersson <[email protected]>
treewide: Add SPDX license identifier - Makefile/KconfigAdd SPDX license identifiers to all Make/Kconfig files which: - Have no license information of any formThese files fall under the project
treewide: Add SPDX license identifier - Makefile/KconfigAdd SPDX license identifiers to all Make/Kconfig files which: - Have no license information of any formThese files fall under the project license, GPL v2 only. The resulting SPDXlicense identifier is: GPL-2.0-onlySigned-off-by: Thomas Gleixner <[email protected]>Signed-off-by: Greg Kroah-Hartman <[email protected]>
samples: Introduce Qualcomm QMI sample clientIntroduce a sample driver that register for server notifications andspawn clients for each available test service (service 15). The spawnedclients imp
samples: Introduce Qualcomm QMI sample clientIntroduce a sample driver that register for server notifications andspawn clients for each available test service (service 15). The spawnedclients implements the interface for encoding "ping" and "data" requestsand decode the responses from the remote.Acked-By: Chris Lew <[email protected]>Signed-off-by: Bjorn Andersson <[email protected]>