| 359bc01d | 10-Jul-2024 |
Jeff Johnson <[email protected]> |
libceph: fix crush_choose_firstn() kernel-doc warnings
Currently, when built with "make W=1", the following warnings are generated:
net/ceph/crush/mapper.c:466: warning: Function parameter or struc
libceph: fix crush_choose_firstn() kernel-doc warnings
Currently, when built with "make W=1", the following warnings are generated:
net/ceph/crush/mapper.c:466: warning: Function parameter or struct member 'work' not described in 'crush_choose_firstn' net/ceph/crush/mapper.c:466: warning: Function parameter or struct member 'weight' not described in 'crush_choose_firstn' net/ceph/crush/mapper.c:466: warning: Function parameter or struct member 'weight_max' not described in 'crush_choose_firstn' net/ceph/crush/mapper.c:466: warning: Function parameter or struct member 'choose_args' not described in 'crush_choose_firstn'
Update the crush_choose_firstn() kernel-doc to document these parameters.
Signed-off-by: Jeff Johnson <[email protected]> Reviewed-by: Simon Horman <[email protected]> Signed-off-by: Ilya Dryomov <[email protected]>
show more ...
|
| b88ed8d8 | 22-Jun-2017 |
Ilya Dryomov <[email protected]> |
crush: crush_init_workspace starts with struct crush_work
It is not just a pointer to crush_work, it is the whole structure. That is not a problem since it only contains a pointer. But it will be a
crush: crush_init_workspace starts with struct crush_work
It is not just a pointer to crush_work, it is the whole structure. That is not a problem since it only contains a pointer. But it will be a problem if new data members are added to crush_work.
Reflects ceph.git commit ee957dd431bfbeb6dadaf77764db8e0757417328.
Signed-off-by: Ilya Dryomov <[email protected]>
show more ...
|
| 5cf9c4a9 | 22-Jun-2017 |
Ilya Dryomov <[email protected]> |
libceph, crush: per-pool crush_choose_arg_map for crush_do_rule()
If there is no crush_choose_arg_map for a given pool, a NULL pointer is passed to preserve existing crush_do_rule() behavior.
Refle
libceph, crush: per-pool crush_choose_arg_map for crush_do_rule()
If there is no crush_choose_arg_map for a given pool, a NULL pointer is passed to preserve existing crush_do_rule() behavior.
Reflects ceph.git commits 55fb91d64071552ea1bc65ab4ea84d3c8b73ab4b, dbe36e08be00c6519a8c89718dd47b0219c20516.
Signed-off-by: Ilya Dryomov <[email protected]>
show more ...
|
| 7ba0487c | 16-Feb-2017 |
Ilya Dryomov <[email protected]> |
crush: fix dprintk compilation
The syntax error was not noticed because dprintk is a macro and the code is discarded by default.
Reflects ceph.git commit f29b840c64a933b2cb13e3da6f3d785effd73a57.
crush: fix dprintk compilation
The syntax error was not noticed because dprintk is a macro and the code is discarded by default.
Reflects ceph.git commit f29b840c64a933b2cb13e3da6f3d785effd73a57.
Signed-off-by: Ilya Dryomov <[email protected]>
show more ...
|
| 743efcff | 31-Jan-2017 |
Ilya Dryomov <[email protected]> |
crush: merge working data and scratch
Much like Arlo Guthrie, I decided that one big pile is better than two little piles.
Reflects ceph.git commit 95c2df6c7e0b22d2ea9d91db500cf8b9441c73ba.
Signed
crush: merge working data and scratch
Much like Arlo Guthrie, I decided that one big pile is better than two little piles.
Reflects ceph.git commit 95c2df6c7e0b22d2ea9d91db500cf8b9441c73ba.
Signed-off-by: Ilya Dryomov <[email protected]>
show more ...
|
| 64f77566 | 27-Sep-2016 |
Ilya Dryomov <[email protected]> |
crush: remove redundant local variable
Remove extra x1 variable, it's just temporary placeholder that clutters the code unnecessarily.
Reflects ceph.git commit 0d19408d91dd747340d70287b4ef9efd89e95
crush: remove redundant local variable
Remove extra x1 variable, it's just temporary placeholder that clutters the code unnecessarily.
Reflects ceph.git commit 0d19408d91dd747340d70287b4ef9efd89e95c6b.
Signed-off-by: Ilya Dryomov <[email protected]>
show more ...
|
| 56a4f309 | 31-Jan-2016 |
Ilya Dryomov <[email protected]> |
crush: ensure take bucket value is valid
Ensure that the take argument is a valid bucket ID before indexing the buckets array.
Reflects ceph.git commit 93ec538e8a667699876b72459b8ad78966d89c61.
Si
crush: ensure take bucket value is valid
Ensure that the take argument is a valid bucket ID before indexing the buckets array.
Reflects ceph.git commit 93ec538e8a667699876b72459b8ad78966d89c61.
Signed-off-by: Ilya Dryomov <[email protected]> Reviewed-by: Sage Weil <[email protected]>
show more ...
|