Revert "wifi: iwlwifi: make no_160 more generic"This reverts commit 75a3313f52b7e08e7e73746f69a68c2b7c28bb2b.The indication of the BW limitation in the sub-device ID is not applicablefor Killer
Revert "wifi: iwlwifi: make no_160 more generic"This reverts commit 75a3313f52b7e08e7e73746f69a68c2b7c28bb2b.The indication of the BW limitation in the sub-device ID is not applicablefor Killer devices. For those devices, bw_limit will hold a random value,so a matching dev_info might not be found, which leads to a probefailure.Until it is properly fixed, revert this.Reported-by: Todd Brandt <[email protected]>Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220029Fixes: 75a3313f52b7 ("wifi: iwlwifi: make no_160 more generic")Signed-off-by: Miri Korenblit <[email protected]>Link: https://patch.msgid.link/20250420115541.36dd3007151e.I66b6b78db09bfea12ae84dd85603cf1583271474@changeidSigned-off-by: Johannes Berg <[email protected]>
show more ...
wifi: iwlwifi: make no_160 more genericWe'll have devices that are EHT capable but don't support 320 MHz andthose devices look like the 320 MHz capable devices, but have distinctsubsystem ID.We
wifi: iwlwifi: make no_160 more genericWe'll have devices that are EHT capable but don't support 320 MHz andthose devices look like the 320 MHz capable devices, but have distinctsubsystem ID.We already had the same type of differentiation for HE devices thatsupport 160 MHz or not.Enhance that mechanism and now the _IWL_DEV_INFO macro gets anindication whether the bandwidth should be limited for that specificdevice.The subsystem ID gives a binary answer about the bandwidth limitationand iwl_pci_find_dev_info() compares this to the list of _IWL_DEV_INFOentries.Signed-off-by: Emmanuel Grumbach <[email protected]>Reviewed-by: Johannes Berg <[email protected]>Signed-off-by: Miri Korenblit <[email protected]>Link: https://patch.msgid.link/20250205145347.1ba406c538a5.I6e24123f60a764aedfeaaac8768c26e136c320cf@changeidSigned-off-by: Johannes Berg <[email protected]>
module: Convert symbol namespace to string literalClean up the existing export namespace code along the same lines ofcommit 33def8498fdd ("treewide: Convert macro and uses of __section(foo)to __s
module: Convert symbol namespace to string literalClean up the existing export namespace code along the same lines ofcommit 33def8498fdd ("treewide: Convert macro and uses of __section(foo)to __section("foo")") and for the same reason, it is not desired for thenamespace argument to be a macro expansion itself.Scripted using git grep -l -e MODULE_IMPORT_NS -e EXPORT_SYMBOL_NS | while read file; do awk -i inplace ' /^#define EXPORT_SYMBOL_NS/ { gsub(/__stringify\(ns\)/, "ns"); print; next; } /^#define MODULE_IMPORT_NS/ { gsub(/__stringify\(ns\)/, "ns"); print; next; } /MODULE_IMPORT_NS/ { $0 = gensub(/MODULE_IMPORT_NS\(([^)]*)\)/, "MODULE_IMPORT_NS(\"\\1\")", "g"); } /EXPORT_SYMBOL_NS/ { if ($0 ~ /(EXPORT_SYMBOL_NS[^(]*)\(([^,]+),/) { if ($0 !~ /(EXPORT_SYMBOL_NS[^(]*)\(([^,]+), ([^)]+)\)/ && $0 !~ /(EXPORT_SYMBOL_NS[^(]*)\(\)/ && $0 !~ /^my/) { getline line; gsub(/[[:space:]]*\\$/, ""); gsub(/[[:space:]]/, "", line); $0 = $0 " " line; } $0 = gensub(/(EXPORT_SYMBOL_NS[^(]*)\(([^,]+), ([^)]+)\)/, "\\1(\\2, \"\\3\")", "g"); } } { print }' $file; doneRequested-by: Masahiro Yamada <[email protected]>Signed-off-by: Peter Zijlstra (Intel) <[email protected]>Link: https://mail.google.com/mail/u/2/#inbox/FMfcgzQXKWgMmjdFwwdsfgxzKpVHWPlcAcked-by: Greg KH <[email protected]>Signed-off-by: Linus Torvalds <[email protected]>
kbuild: use $(src) instead of $(srctree)/$(src) for source directoryKbuild conventionally uses $(obj)/ for generated files, and $(src)/ forchecked-in source files. It is merely a convention withou
kbuild: use $(src) instead of $(srctree)/$(src) for source directoryKbuild conventionally uses $(obj)/ for generated files, and $(src)/ forchecked-in source files. It is merely a convention without any functionaldifference. In fact, $(obj) and $(src) are exactly the same, as definedin scripts/Makefile.build: src := $(obj)When the kernel is built in a separate output directory, $(src) doesnot accurately reflect the source directory location. While Kbuildresolves this discrepancy by specifying VPATH=$(srctree) to search forsource files, it does not cover all cases. For example, when adding aheader search path for local headers, -I$(srctree)/$(src) is typicallypassed to the compiler.This introduces inconsistency between upstream and downstream Makefilesbecause $(src) is used instead of $(srctree)/$(src) for the latter.To address this inconsistency, this commit changes the semantics of$(src) so that it always points to the directory in the source tree.Going forward, the variables used in Makefiles will have the followingmeanings: $(obj) - directory in the object tree $(src) - directory in the source tree (changed by this commit) $(objtree) - the top of the kernel object tree $(srctree) - the top of the kernel source treeConsequently, $(srctree)/$(src) in upstream Makefiles need to be replacedwith $(src).Signed-off-by: Masahiro Yamada <[email protected]>Reviewed-by: Nicolas Schier <[email protected]>
wifi: iwlwifi: add a kunit test for PCI table duplicatesWe shouldn't have entries in the table that match the samedevice; it's possible to have a specific entry followed bya less specific entry (
wifi: iwlwifi: add a kunit test for PCI table duplicatesWe shouldn't have entries in the table that match the samedevice; it's possible to have a specific entry followed bya less specific entry (i.e. NNNN followed by ANY), but notentries that are dead, where an earlier entry matches thesame as a later one.Add a test similar to the existing devinfo test to catchthis situation.Signed-off-by: Johannes Berg <[email protected]>Signed-off-by: Miri Korenblit <[email protected]>Link: https://msgid.link/20240319100755.826b859abd62.I8140d7e9ae52ac50c6830818f8f95ccd0d94b3d3@changeidSigned-off-by: Johannes Berg <[email protected]>
wifi: iwlwifi: add kunit test for devinfo orderingWe used to have a test built into the code for this internally,but now we can put that into kunit and let everyone run it, toverify the devinfo t
wifi: iwlwifi: add kunit test for devinfo orderingWe used to have a test built into the code for this internally,but now we can put that into kunit and let everyone run it, toverify the devinfo table ordering if it's changed.Signed-off-by: Johannes Berg <[email protected]>Reviewed-by: Benjamin Berg <[email protected]>Reviewed-by: Gregory Greenman <[email protected]>Signed-off-by: Miri Korenblit <[email protected]>Link: https://msgid.link/20240123200528.a4a8af7c091f.I0fb09083317b331168b99b8db39656a126a5cc4d@changeidSigned-off-by: Johannes Berg <[email protected]>