net/fungible: Remove unused fun_create_queuefun_create_queue was added in 2022 bycommit e1ffcc66818f ("net/fungible: Add service module for Fungibledrivers")but hasn't been used.Remove it.Al
net/fungible: Remove unused fun_create_queuefun_create_queue was added in 2022 bycommit e1ffcc66818f ("net/fungible: Add service module for Fungibledrivers")but hasn't been used.Remove it.Also remove the static helper functions it was the only user of.Signed-off-by: Dr. David Alan Gilbert <[email protected]>Signed-off-by: Jakub Kicinski <[email protected]>
show more ...
net/fungible: Avoid -Wflex-array-member-not-at-end warningUse the `DEFINE_RAW_FLEX()` helper for an on-stack definition ofa flexible structure where the size of the flexible-array memberis known
net/fungible: Avoid -Wflex-array-member-not-at-end warningUse the `DEFINE_RAW_FLEX()` helper for an on-stack definition ofa flexible structure where the size of the flexible-array memberis known at compile-time, and refactor the rest of the code,accordingly.So, with these changes, fix the following warning:drivers/net/ethernet/fungible/funcore/fun_dev.c:550:43: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]Signed-off-by: Gustavo A. R. Silva <[email protected]>Link: https://patch.msgid.link/ZrDwEugW7DR/FlP5@cuteSigned-off-by: Jakub Kicinski <[email protected]>
net/fungible: Remove redundant pci_clear_masterRemove pci_clear_master to simplify the code,the bus-mastering is also cleared in do_pci_disable_device,like this:./drivers/pci/pci.c:2197static v
net/fungible: Remove redundant pci_clear_masterRemove pci_clear_master to simplify the code,the bus-mastering is also cleared in do_pci_disable_device,like this:./drivers/pci/pci.c:2197static void do_pci_disable_device(struct pci_dev *dev){ u16 pci_command; pci_read_config_word(dev, PCI_COMMAND, &pci_command); if (pci_command & PCI_COMMAND_MASTER) { pci_command &= ~PCI_COMMAND_MASTER; pci_write_config_word(dev, PCI_COMMAND, pci_command); } pcibios_disable_device(dev);}.And dev->is_busmaster is set to 0 in pci_disable_device.Signed-off-by: Cai Huoqing <[email protected]>Acked-by: Dimitris Michailidis <[email protected]>Signed-off-by: David S. Miller <[email protected]>
net/fungible: Drop redundant pci_enable_pcie_error_reporting()pci_enable_pcie_error_reporting() enables the device to send ERR_*Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when
net/fungible: Drop redundant pci_enable_pcie_error_reporting()pci_enable_pcie_error_reporting() enables the device to send ERR_*Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER isnative"), the PCI core does this for all devices during enumeration, so thedriver doesn't need to do it itself.Remove the redundant pci_enable_pcie_error_reporting() call from thedriver. Also remove the corresponding pci_disable_pcie_error_reporting()from the driver .remove() path.Note that this only controls ERR_* Messages from the device. An ERR_*Message may cause the Root Port to generate an interrupt, depending on theAER Root Error Command register managed by the AER service driver.Signed-off-by: Bjorn Helgaas <[email protected]>Acked-by: Dimitris Michailidis <[email protected]>Acked-by: Jesse Brandeburg <[email protected]>Signed-off-by: Jakub Kicinski <[email protected]>
net/funeth: Support for ethtool -mAdd the FW command for reading port module memory pages and implementethtool's get_module_eeprom_by_page operation.Signed-off-by: Dimitris Michailidis <dmichail
net/funeth: Support for ethtool -mAdd the FW command for reading port module memory pages and implementethtool's get_module_eeprom_by_page operation.Signed-off-by: Dimitris Michailidis <[email protected]>Link: https://lore.kernel.org/r/[email protected]Signed-off-by: Jakub Kicinski <[email protected]>
net/fungible: Fix reference to __udivdi3 on 32b builds32b builds with CONFIG_PHYS_ADDR_T_64BIT=y, such as i386 PAE,raise a linker error due to a 64b division:ld: drivers/net/ethernet/fungible/fu
net/fungible: Fix reference to __udivdi3 on 32b builds32b builds with CONFIG_PHYS_ADDR_T_64BIT=y, such as i386 PAE,raise a linker error due to a 64b division:ld: drivers/net/ethernet/fungible/funcore/fun_dev.o: in function`fun_dev_enable':(.text+0xe1a): undefined reference to `__udivdi3'The divisor in the offendinng expression is a power of 2. Change it touse an explicit right shift.Fixes: e1ffcc66818f ("net/fungible: Add service module for Fungible drivers")Reported-by: Randy Dunlap <[email protected]>Signed-off-by: Dimitris Michailidis <[email protected]>Link: https://lore.kernel.org/r/[email protected]Signed-off-by: Jakub Kicinski <[email protected]>
net/fungible: Add service module for Fungible driversFungible cards have a number of different PCI functions and thusdifferent drivers, all of which use a common method to initialize andinteract
net/fungible: Add service module for Fungible driversFungible cards have a number of different PCI functions and thusdifferent drivers, all of which use a common method to initialize andinteract with the device. This commit adds a library module thatcollects these common mechanisms. They mainly deal with deviceinitialization, setting up and destroying queues, and operating an adminqueue. A subset of the FW interface is also included here.Signed-off-by: Dimitris Michailidis <[email protected]>Signed-off-by: David S. Miller <[email protected]>