| 24a19e4b | 05-Aug-2024 |
Wolfram Sang <[email protected]> |
media: platform: exynos-gsc: use 'time_left' variable with wait_event_timeout()
There is a confusing pattern in the kernel to use a variable named 'timeout' to store the result of wait_event_timeout
media: platform: exynos-gsc: use 'time_left' variable with wait_event_timeout()
There is a confusing pattern in the kernel to use a variable named 'timeout' to store the result of wait_event_timeout() causing patterns like:
timeout = wait_event_timeout(...) if (!timeout) return -ETIMEDOUT;
with all kinds of permutations. Use 'time_left' as a variable to make the code self explaining.
Fix to the proper variable type 'long' while here.
Signed-off-by: Wolfram Sang <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
show more ...
|
| 6b1e2e04 | 24-Dec-2023 |
Krzysztof Kozlowski <[email protected]> |
media: s5p-mfc: drop useless clock refcnt debugging
Drop useless debugging of clock enabl/disable counts, because core handles this much better.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlow
media: s5p-mfc: drop useless clock refcnt debugging
Drop useless debugging of clock enabl/disable counts, because core handles this much better.
Signed-off-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
show more ...
|
| 60a2a86f | 24-Dec-2023 |
Krzysztof Kozlowski <[email protected]> |
media: s5p-mfc: constify pointers to s5p_mfc_cmd_args
In few places functions do not modify pointed "struct s5p_mfc_cmd_args", thus the pointer can point to const data for additional safety and self
media: s5p-mfc: constify pointers to s5p_mfc_cmd_args
In few places functions do not modify pointed "struct s5p_mfc_cmd_args", thus the pointer can point to const data for additional safety and self-documenting intention of the function.
Signed-off-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
show more ...
|
| 4b9f9109 | 24-Dec-2023 |
Krzysztof Kozlowski <[email protected]> |
media: s5p-mfc: constify struct structures
Static "struct" structures are not modified by the driver, so they can be made const for code safety.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlow
media: s5p-mfc: constify struct structures
Static "struct" structures are not modified by the driver, so they can be made const for code safety.
Signed-off-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
show more ...
|
| 028111b3 | 24-Dec-2023 |
Krzysztof Kozlowski <[email protected]> |
media: s5p-mfc: constify s5p_mfc_fmt structures
Static "s5p_mfc_fmt" structures are not modified by the driver, so they can be made const for code safety.
Signed-off-by: Krzysztof Kozlowski <krzysz
media: s5p-mfc: constify s5p_mfc_fmt structures
Static "s5p_mfc_fmt" structures are not modified by the driver, so they can be made const for code safety.
Signed-off-by: Krzysztof Kozlowski <[email protected]> Reviewed-by: Aakarsh Jain <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
show more ...
|