media: cec: tda9950: add back i2c dependencydrivers/media/cec/i2c/tda9950.c: In function 'tda9950_write_range':drivers/media/cec/i2c/tda9950.c:92:15: error: implicit declaration of function 'i2c_t
media: cec: tda9950: add back i2c dependencydrivers/media/cec/i2c/tda9950.c: In function 'tda9950_write_range':drivers/media/cec/i2c/tda9950.c:92:15: error: implicit declaration of function 'i2c_transfer' [-Wimplicit-function-declaration] 92 | ret = i2c_transfer(client->adapter, &msg, 1); | ^~~~~~~~~~~~drivers/media/cec/i2c/tda9950.c: In function 'tda9950_probe':drivers/media/cec/i2c/tda9950.c:391:14: error: implicit declaration of function 'i2c_check_functionality' [-Wimplicit-function-declaration] 391 | if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { | ^~~~~~~~~~~~~~~~~~~~~~~Fixes: caa6f4a75e9f ("media: cec: move driver for TDA9950 from drm/i2c")Signed-off-by: Arnd Bergmann <[email protected]>Signed-off-by: Hans Verkuil <[email protected]>
show more ...
media: cec: move driver for TDA9950 from drm/i2cMove the driver for NXP TDA9950 / CEC part of TDA998x together todrivers/media/i2c, close to other CEC drivers. Specify 'defaultDRM_I2C_NXP_TDA998X
media: cec: move driver for TDA9950 from drm/i2cMove the driver for NXP TDA9950 / CEC part of TDA998x together todrivers/media/i2c, close to other CEC drivers. Specify 'defaultDRM_I2C_NXP_TDA998X' in order to simplify migration from old configfiles as the Kconfig name has been changed to follow media/cec style.Acked-by: Hans Verkuil <[email protected]>Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]Signed-off-by: Dmitry Baryshkov <[email protected]>
media: cec: ch7322: drop of_match_ptr for ID tableThe driver can match only via the DT table so the table should be alwaysused and the of_match_ptr does not have any sense (this also allows ACPIm
media: cec: ch7322: drop of_match_ptr for ID tableThe driver can match only via the DT table so the table should be alwaysused and the of_match_ptr does not have any sense (this also allows ACPImatching via PRP0001, even though it might not be relevant here). drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]Signed-off-by: Krzysztof Kozlowski <[email protected]>Reviewed-by: Hans Verkuil <[email protected]>Reviewed-by: Guenter Roeck <[email protected]>Signed-off-by: Sakari Ailus <[email protected]>Signed-off-by: Mauro Carvalho Chehab <[email protected]>
media: cec: i2c: ch7322: also select REGMAPSelecting only REGMAP_I2C can leave REGMAP unset, causing build errors,so also select REGMAP to prevent the build errors.../drivers/media/cec/i2c/ch732
media: cec: i2c: ch7322: also select REGMAPSelecting only REGMAP_I2C can leave REGMAP unset, causing build errors,so also select REGMAP to prevent the build errors.../drivers/media/cec/i2c/ch7322.c:158:21: error: variable 'ch7322_regmap' has initializer but incomplete type 158 | static const struct regmap_config ch7322_regmap = {../drivers/media/cec/i2c/ch7322.c:159:10: error: 'const struct regmap_config' has no member named 'reg_bits' 159 | .reg_bits = 8,../drivers/media/cec/i2c/ch7322.c:159:21: warning: excess elements in struct initializer 159 | .reg_bits = 8,../drivers/media/cec/i2c/ch7322.c:160:10: error: 'const struct regmap_config' has no member named 'val_bits' 160 | .val_bits = 8,../drivers/media/cec/i2c/ch7322.c:160:21: warning: excess elements in struct initializer 160 | .val_bits = 8,../drivers/media/cec/i2c/ch7322.c:161:10: error: 'const struct regmap_config' has no member named 'max_register' 161 | .max_register = 0x7f,../drivers/media/cec/i2c/ch7322.c:161:25: warning: excess elements in struct initializer 161 | .max_register = 0x7f,../drivers/media/cec/i2c/ch7322.c:162:10: error: 'const struct regmap_config' has no member named 'disable_locking' 162 | .disable_locking = true,../drivers/media/cec/i2c/ch7322.c:162:28: warning: excess elements in struct initializer 162 | .disable_locking = true,../drivers/media/cec/i2c/ch7322.c: In function 'ch7322_probe':../drivers/media/cec/i2c/ch7322.c:468:26: error: implicit declaration of function 'devm_regmap_init_i2c' [-Werror=implicit-function-declaration] 468 | ch7322->regmap = devm_regmap_init_i2c(client, &ch7322_regmap);../drivers/media/cec/i2c/ch7322.c:468:24: warning: assignment to 'struct regmap *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 468 | ch7322->regmap = devm_regmap_init_i2c(client, &ch7322_regmap);../drivers/media/cec/i2c/ch7322.c: At top level:../drivers/media/cec/i2c/ch7322.c:158:35: error: storage size of 'ch7322_regmap' isn't known 158 | static const struct regmap_config ch7322_regmap = {Link: https://lore.kernel.org/linux-media/[email protected]Fixes: 21b9a47e0ec7 ("media: cec: i2c: ch7322: Add ch7322 CEC controller driver")Signed-off-by: Randy Dunlap <[email protected]>Cc: Jeff Chase <[email protected]>Cc: Hans Verkuil <[email protected]>Cc: Joe Tessler <[email protected]>Cc: Arnd Bergmann <[email protected]>Cc: Mark Brown <[email protected]>Cc: Masahiro Yamada <[email protected]>Signed-off-by: Mauro Carvalho Chehab <[email protected]>
media: Switch i2c drivers back to use .probe()After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()call-back type"), all drivers being converted to .probe_new() and thencommit 03c835f
media: Switch i2c drivers back to use .probe()After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()call-back type"), all drivers being converted to .probe_new() and thencommit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")convert back to (the new) .probe() to be able to eventually drop.probe_new() from struct i2c_driver.Signed-off-by: Uwe Kleine-König <[email protected]>Signed-off-by: Hans Verkuil <[email protected]>
i2c: Make remove callback return voidThe value returned by an i2c driver's remove function is mostly ignored.(Only an error message is printed if the value is non-zero that theerror is ignored.)
i2c: Make remove callback return voidThe value returned by an i2c driver's remove function is mostly ignored.(Only an error message is printed if the value is non-zero that theerror is ignored.)So change the prototype of the remove function to return no value. Thisway driver authors are not tempted to assume that passing an error tothe upper layer is a good idea. All drivers are adapted accordingly.There is no intended change of behaviour, all callbacks were prepared toreturn 0 before.Reviewed-by: Peter Senna Tschudin <[email protected]>Reviewed-by: Jeremy Kerr <[email protected]>Reviewed-by: Benjamin Mugnier <[email protected]>Reviewed-by: Javier Martinez Canillas <[email protected]>Reviewed-by: Crt Mori <[email protected]>Reviewed-by: Heikki Krogerus <[email protected]>Acked-by: Greg Kroah-Hartman <[email protected]>Acked-by: Marek Behún <[email protected]> # for leds-turris-omniaAcked-by: Andy Shevchenko <[email protected]>Reviewed-by: Petr Machata <[email protected]> # for mlxswReviewed-by: Maximilian Luz <[email protected]> # for surface3_powerAcked-by: Srinivas Pandruvada <[email protected]> # for bmc150-accel-i2c + kxcjk-1013Reviewed-by: Hans Verkuil <[email protected]> # for media/* + staging/media/*Acked-by: Miguel Ojeda <[email protected]> # for auxdisplay/ht16k33 + auxdisplay/lcd2sReviewed-by: Luca Ceresoli <[email protected]> # for versaclock5Reviewed-by: Ajay Gupta <[email protected]> # for ucsi_ccgAcked-by: Jonathan Cameron <[email protected]> # for iioAcked-by: Peter Rosin <[email protected]> # for i2c-mux-*, max9860Acked-by: Adrien Grassein <[email protected]> # for lontium-lt8912bReviewed-by: Jean Delvare <[email protected]> # for hwmon, i2c-core and i2c/muxesAcked-by: Corey Minyard <[email protected]> # for IPMIReviewed-by: Vladimir Oltean <[email protected]>Acked-by: Dmitry Torokhov <[email protected]>Acked-by: Sebastian Reichel <[email protected]> # for drivers/powerAcked-by: Krzysztof Hałasa <[email protected]>Signed-off-by: Uwe Kleine-König <[email protected]>Signed-off-by: Wolfram Sang <[email protected]>
media: cec: i2c: ch7322: Add ch7322 CEC controller driverAdd a CEC device driver for the Chrontel ch7322 CEC conroller.This is an I2C device capable of sending and receiving CEC messages.Signed-
media: cec: i2c: ch7322: Add ch7322 CEC controller driverAdd a CEC device driver for the Chrontel ch7322 CEC conroller.This is an I2C device capable of sending and receiving CEC messages.Signed-off-by: Jeff Chase <[email protected]>Signed-off-by: Hans Verkuil <[email protected]>Signed-off-by: Mauro Carvalho Chehab <[email protected]>