| 653959e3 | 31-Oct-2023 |
Uwe Kleine-König <[email protected]> |
interconnect: imx8mq: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to d
interconnect: imx8mq: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Georgi Djakov <[email protected]>
show more ...
|
| 12384b76 | 31-Oct-2023 |
Uwe Kleine-König <[email protected]> |
interconnect: imx8mp: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to d
interconnect: imx8mp: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Georgi Djakov <[email protected]>
show more ...
|
| 1841d085 | 31-Oct-2023 |
Uwe Kleine-König <[email protected]> |
interconnect: imx8mn: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to d
interconnect: imx8mn: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Georgi Djakov <[email protected]>
show more ...
|
| c14ec5c9 | 03-Jul-2022 |
Peng Fan <[email protected]> |
interconnect: imx: Add platform driver for imx8mp
Add a platform driver for the i.MX8MP SoC describing bus topology, based on internal documentation.
Signed-off-by: Peng Fan <[email protected]> Link
interconnect: imx: Add platform driver for imx8mp
Add a platform driver for the i.MX8MP SoC describing bus topology, based on internal documentation.
Signed-off-by: Peng Fan <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Georgi Djakov <[email protected]>
show more ...
|
| 7980d85a | 03-Jul-2022 |
Peng Fan <[email protected]> |
interconnect: imx: configure NoC mode/prioriry/ext_control
Introduce imx_icc_noc_setting structure to describe a master port setting Pass imx_icc_noc_setting as a parameter from specific driver Set
interconnect: imx: configure NoC mode/prioriry/ext_control
Introduce imx_icc_noc_setting structure to describe a master port setting Pass imx_icc_noc_setting as a parameter from specific driver Set priority level, mode, ext control in imx_icc_node_set
Signed-off-by: Peng Fan <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Georgi Djakov <[email protected]>
show more ...
|
| 6eeaf28c | 03-Jul-2022 |
Peng Fan <[email protected]> |
interconnect: imx: set src node
When set QoS for a icc path, only set dst icc node is not enough, also need to set src icc node.
Signed-off-by: Peng Fan <[email protected]> Link: https://lore.kernel
interconnect: imx: set src node
When set QoS for a icc path, only set dst icc node is not enough, also need to set src icc node.
Signed-off-by: Peng Fan <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Georgi Djakov <[email protected]>
show more ...
|
| 67288f74 | 28-Dec-2020 |
Martin Kepplinger <[email protected]> |
interconnect: imx8mq: Use icc_sync_state
Add the icc_sync_state callback to notify the framework when consumers are probed and the bandwidth doesn't have to be kept at maximum anymore.
Signed-off-b
interconnect: imx8mq: Use icc_sync_state
Add the icc_sync_state callback to notify the framework when consumers are probed and the bandwidth doesn't have to be kept at maximum anymore.
Signed-off-by: Martin Kepplinger <[email protected]> Suggested-by: Georgi Djakov <[email protected]> Fixes: 7d3b0b0d8184 ("interconnect: qcom: Use icc_sync_state") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Georgi Djakov <[email protected]>
show more ...
|
| 6414b79d | 28-Dec-2020 |
Christophe JAILLET <[email protected]> |
interconnect: imx: Remove a useless test
'dn' can't be NULL here, it is tested just the line above. Remove this useless test.
Signed-off-by: Christophe JAILLET <[email protected]> Link:
interconnect: imx: Remove a useless test
'dn' can't be NULL here, it is tested just the line above. Remove this useless test.
Signed-off-by: Christophe JAILLET <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Georgi Djakov <[email protected]>
show more ...
|
| 360a1028 | 10-May-2020 |
Wei Yongjun <[email protected]> |
interconnect: imx: Fix return value check in imx_icc_node_init_qos()
In case of error, the function of_parse_phandle() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check
interconnect: imx: Fix return value check in imx_icc_node_init_qos()
In case of error, the function of_parse_phandle() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test.
Fixes: f0d8048525d7 ("interconnect: Add imx core driver") Reported-by: Hulk Robot <[email protected]> Signed-off-by: Wei Yongjun <[email protected]> Reviewed-by: Dong Aisheng <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Georgi Djakov <[email protected]>
show more ...
|
| 4b54bf47 | 28-Apr-2020 |
Leonard Crestez <[email protected]> |
interconnect: imx: Add platform driver for imx8mn
Add a platform driver for the i.MX8MN SoC describing bus topology, based on internal documentation.
Signed-off-by: Leonard Crestez <leonard.crestez
interconnect: imx: Add platform driver for imx8mn
Add a platform driver for the i.MX8MN SoC describing bus topology, based on internal documentation.
Signed-off-by: Leonard Crestez <[email protected]> Link: https://lore.kernel.org/r/338a5409ce88811ba6c940ba06441db3faa8c187.1586174566.git.leonard.crestez@nxp.com Signed-off-by: Georgi Djakov <[email protected]>
show more ...
|