| fc62d5e2 | 10-Oct-2023 |
Andy Shevchenko <[email protected]> |
hte: Use kasprintf() instead of fixed buffer formatting
Improve readability and maintainability by replacing a hardcoded string allocation and formatting by the use of the kasprintf() helper.
Signe
hte: Use kasprintf() instead of fixed buffer formatting
Improve readability and maintainability by replacing a hardcoded string allocation and formatting by the use of the kasprintf() helper.
Signed-off-by: Andy Shevchenko <[email protected]> Reviewed-by: Dipen Patel <[email protected]> Signed-off-by: Dipen Patel <[email protected]>
show more ...
|
| b7c3ca35 | 26-Oct-2023 |
Harshit Mogalapalli <[email protected]> |
hte: tegra: Fix missing error code in tegra_hte_test_probe()
The value of 'ret' is zero when of_hte_req_count() fails to get number of entitties to timestamp. And returning success(zero) on this fai
hte: tegra: Fix missing error code in tegra_hte_test_probe()
The value of 'ret' is zero when of_hte_req_count() fails to get number of entitties to timestamp. And returning success(zero) on this failure path is incorrect.
Fixes: 9a75a7cd03c9 ("hte: Add Tegra HTE test driver") Signed-off-by: Harshit Mogalapalli <[email protected]> Reviewed-by: Dipen Patel <[email protected]> Signed-off-by: Dipen Patel <[email protected]>
show more ...
|
| 9bc63311 | 23-Oct-2023 |
Arnd Bergmann <[email protected]> |
hte: tegra194: add GPIOLIB dependency
The driver started calling into a few interfaces that are part of GPIOLIB and don't have stub implementations otherwise:
drivers/hte/hte-tegra194.c: In functio
hte: tegra194: add GPIOLIB dependency
The driver started calling into a few interfaces that are part of GPIOLIB and don't have stub implementations otherwise:
drivers/hte/hte-tegra194.c: In function 'tegra_hte_line_xlate': drivers/hte/hte-tegra194.c:424:48: error: implicit declaration of function 'gpio_device_get_base'; did you mean 'gpio_device_get_desc'? [-Werror=implicit-function-declaration] 424 | line_id = desc->attr.line_id - gpio_device_get_base(gs->gdev); | ^~~~~~~~~~~~~~~~~~~~ | gpio_device_get_desc
Add a Kconfig dependency to only allow building when this is defined.
Fixes: dc850faa28ee0 ("hte: tegra194: don't access struct gpio_chip") Signed-off-by: Arnd Bergmann <[email protected]> Acked-by: Dipen Patel <[email protected]> Signed-off-by: Bartosz Golaszewski <[email protected]>
show more ...
|
| 091ac92d | 11-Oct-2023 |
Andy Shevchenko <[email protected]> |
hte: tegra194: Switch to LATE_SIMPLE_DEV_PM_OPS()
SET_LATE_SYSTEM_SLEEP_PM_OPS is deprecated, replace it with LATE_SYSTEM_SLEEP_PM_OPS() and use pm_sleep_ptr() for setting the driver's pm routines.
hte: tegra194: Switch to LATE_SIMPLE_DEV_PM_OPS()
SET_LATE_SYSTEM_SLEEP_PM_OPS is deprecated, replace it with LATE_SYSTEM_SLEEP_PM_OPS() and use pm_sleep_ptr() for setting the driver's pm routines. We can now remove the __maybe_unused qualifier in the suspend and resume functions.
Tested-by: Dipen Patel <[email protected]> Reviewed-by: Dipen Patel <[email protected]> Reviewed-by: Linus Walleij <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Dipen Patel <[email protected]>
show more ...
|
| ca3d1a4b | 08-Feb-2023 |
Linus Walleij <[email protected]> |
hte: tegra-194: Use proper includes
The test driver uses the gpiod consumer API so include the right <linux/gpio/consumer.h> header. This may cause a problem with struct of_device_id being implcitly
hte: tegra-194: Use proper includes
The test driver uses the gpiod consumer API so include the right <linux/gpio/consumer.h> header. This may cause a problem with struct of_device_id being implcitly pulled in by the legacy header <linux/gpio.h> so include <linux/mod_devicetable.h> explicitly as well.
While at it, drop explicit moduleparam.h (it's included with module.h) and sort the headers.
Signed-off-by: Linus Walleij <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]> Acked-by: Dipen Patel <[email protected]> Signed-off-by: Dipen Patel <[email protected]>
show more ...
|
| e078180d | 19-Apr-2023 |
Dan Carpenter <[email protected]> |
hte: tegra-194: Fix off by one in tegra_hte_map_to_line_id()
The "map_sz" is the number of elements in the "m" array so the > comparison needs to be changed to >= to prevent an out of bounds read.
hte: tegra-194: Fix off by one in tegra_hte_map_to_line_id()
The "map_sz" is the number of elements in the "m" array so the > comparison needs to be changed to >= to prevent an out of bounds read.
Fixes: 09574cca6ad6 ("hte: Add Tegra194 HTE kernel provider") Signed-off-by: Dan Carpenter <[email protected]> Acked-by: Dipen Patel <[email protected]> Signed-off-by: Dipen Patel <[email protected]>
show more ...
|
| 6680c835 | 15-Dec-2022 |
Arnd Bergmann <[email protected]> |
hte: tegra: fix 'struct of_device_id' build error
Without the extra #include, this driver produces a build failure in some configurations.
drivers/hte/hte-tegra194-test.c:96:34: error: array type h
hte: tegra: fix 'struct of_device_id' build error
Without the extra #include, this driver produces a build failure in some configurations.
drivers/hte/hte-tegra194-test.c:96:34: error: array type has incomplete element type 'struct of_device_id' 96 | static const struct of_device_id tegra_hte_test_of_match[] = {
Fixes: 9a75a7cd03c9 ("hte: Add Tegra HTE test driver") Signed-off-by: Arnd Bergmann <[email protected]> Acked-by: Dipen Patel <[email protected]> Signed-off-by: Dipen Patel <[email protected]>
show more ...
|
| 902dea62 | 10-Mar-2023 |
Rob Herring <[email protected]> |
hte: Use of_property_present() for testing DT property presence
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/
hte: Use of_property_present() for testing DT property presence
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more.
Signed-off-by: Rob Herring <[email protected]> Acked-by: Dipen Patel <[email protected]> Signed-off-by: Dipen Patel <[email protected]>
show more ...
|
| d02b1cab | 14-Apr-2023 |
Dipen Patel <[email protected]> |
hte: handle nvidia,gpio-controller property
The dt binding adds nvidia,gpio-controller property from Tegra234 SoC onwards to simplify code handling gpio chip search. The gpio chip search is needed f
hte: handle nvidia,gpio-controller property
The dt binding adds nvidia,gpio-controller property from Tegra234 SoC onwards to simplify code handling gpio chip search. The gpio chip search is needed for the AON GPIO GTE instances to map the hardware timestamp GPIO request (coming from the GPIO framework) to the tegra HTE providers. The patch also adds new gpio chip match function to match from the fwnode instead of the gpio controller label. The addition of the property does not break ABI for the existing Tegra194 code.
Signed-off-by: Dipen Patel <[email protected]> Reviewed-by: Linus Walleij <[email protected]>
show more ...
|
| 0ebc475f | 14-Apr-2023 |
Dipen Patel <[email protected]> |
hte: Deprecate nvidia,slices property
The relevant DT bindings deprecates nvidia,slices property from Tegra234 SoC onwards, moving the slices value per SoC data structure instead.
Signed-off-by: Di
hte: Deprecate nvidia,slices property
The relevant DT bindings deprecates nvidia,slices property from Tegra234 SoC onwards, moving the slices value per SoC data structure instead.
Signed-off-by: Dipen Patel <[email protected]>
show more ...
|
| 348b10b0 | 06-May-2022 |
Dan Carpenter <[email protected]> |
hte: Uninitialized variable in hte_ts_get()
The "free_name" variable is sometimes used without being initialized.
Fixes: 31ab09b42188 ("drivers: Add hardware timestamp engine (HTE) subsystem") Sign
hte: Uninitialized variable in hte_ts_get()
The "free_name" variable is sometimes used without being initialized.
Fixes: 31ab09b42188 ("drivers: Add hardware timestamp engine (HTE) subsystem") Signed-off-by: Dan Carpenter <[email protected]> Acked-by: Dipen Patel <[email protected]> Signed-off-by: Thierry Reding <[email protected]>
show more ...
|
| e30b64a3 | 06-May-2022 |
Dan Carpenter <[email protected]> |
hte: Fix off by one in hte_push_ts_ns()
The &chip->gdev->ei[] array has chip->nlines elements so this > comparison needs to be >= to prevent an out of bounds access. The gdev->ei[] array is allocate
hte: Fix off by one in hte_push_ts_ns()
The &chip->gdev->ei[] array has chip->nlines elements so this > comparison needs to be >= to prevent an out of bounds access. The gdev->ei[] array is allocated in hte_register_chip().
Fixes: 31ab09b42188 ("drivers: Add hardware timestamp engine (HTE) subsystem") Signed-off-by: Dan Carpenter <[email protected]> Reviewed-by: Dipen Patel <[email protected]> Acked-by: Dipen Patel <[email protected]> Signed-off-by: Thierry Reding <[email protected]>
show more ...
|
| 0668e8cc | 06-May-2022 |
Yang Yingliang <[email protected]> |
hte: Fix possible use-after-free in tegra_hte_test_remove()
del_timer() does not wait until the timer handler finishing. This means that the timer handler may still be running after the driver's rem
hte: Fix possible use-after-free in tegra_hte_test_remove()
del_timer() does not wait until the timer handler finishing. This means that the timer handler may still be running after the driver's remove function has finished, which would result in a use-after-free. Fix it by calling del_timer_sync(), which makes sure the timer handler has finished.
Reported-by: Hulk Robot <[email protected]> Signed-off-by: Yang Yingliang <[email protected]> Reviewed-by: Dipen Patel <[email protected]> Acked-by: Dipen Patel <[email protected]> Signed-off-by: Thierry Reding <[email protected]>
show more ...
|