drm/amd/display: Adjust functions prefix for some of the dcn301 fpu functionsAdd dcn301_fpu prefix to some of the FPU function with the requiredadjustments.Acked-by: Wayne Lin <[email protected]
drm/amd/display: Adjust functions prefix for some of the dcn301 fpu functionsAdd dcn301_fpu prefix to some of the FPU function with the requiredadjustments.Acked-by: Wayne Lin <[email protected]>Signed-off-by: Rodrigo Siqueira <[email protected]>Tested-by: Daniel Wheeler <[email protected]>Signed-off-by: Alex Deucher <[email protected]>
show more ...
drm/amd/display: Clean FPGA code in dc[Why]Drop dead code for Linux.[How]Remove all IS_FPGA_MAXIMUS_DC and IS_DIAG_DCReviewed-by: Ariel Bernstein <[email protected]>Acked-by: Tom Chung
drm/amd/display: Clean FPGA code in dc[Why]Drop dead code for Linux.[How]Remove all IS_FPGA_MAXIMUS_DC and IS_DIAG_DCReviewed-by: Ariel Bernstein <[email protected]>Acked-by: Tom Chung <[email protected]>Signed-off-by: Qingqing Zhuo <[email protected]>Tested-by: Daniel Wheeler <[email protected]>Signed-off-by: Alex Deucher <[email protected]>
drm/amd/display: add debug option for dramclk_change_latency in apu[Why & How]Support dramclk change latency change via debug option and add somecode isolation.Reviewed-by: Martin Leung <Martin
drm/amd/display: add debug option for dramclk_change_latency in apu[Why & How]Support dramclk change latency change via debug option and add somecode isolation.Reviewed-by: Martin Leung <[email protected]>Acked-by: Wayne Lin <[email protected]>Signed-off-by: Charlene Liu <[email protected]>Tested-by: Daniel Wheeler <[email protected]>Signed-off-by: Alex Deucher <[email protected]>
drm/amd/display: include soc._clock_tmp[] into DC's scratch regionCurrently, we are using soc._clock_tmp[] to temporarily store and modifydata from soc.clock_limits[] before copying it back intos
drm/amd/display: include soc._clock_tmp[] into DC's scratch regionCurrently, we are using soc._clock_tmp[] to temporarily store and modifydata from soc.clock_limits[] before copying it back intosoc.clock_limits[] (because modifying data directly insoc.clock_limits[] causes unintended behavior). However, this approachhas a number of downsides, such as: 1. struct _vcs_dpi_soc_bounding_box_st's creation/destruction aren't well defined (which could mean more unintended behavior). 2. Throwing "temp" varibles in structs everywhere doesn't make for a particularly readable codebase.For these reasons, we should get rid of soc._clock_tmp[] by defining astruct scratch within struct dc that, contains within it all of thetemporary variables (including _clock_tmp[]) such that it is obvious howthey are intended to be used.Co-authored-by: Leo Li <[email protected]>Signed-off-by: Hamza Mahfooz <[email protected]>Signed-off-by: Alex Deucher <[email protected]>
drm/amd/display: include missing headersAdd missing headers to solve the following warnings from sparse:drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/dcn20_fpu.c:656:17: warning: symbol 'ddr
drm/amd/display: include missing headersAdd missing headers to solve the following warnings from sparse:drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/dcn20_fpu.c:656:17: warning: symbol 'ddr4_wm_table_gs' was not declared. Should it be static?drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/dcn20_fpu.c:693:17: warning: symbol 'lpddr4_wm_table_gs' was not declared. Should it be static?drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/dcn20_fpu.c:730:17: warning: symbol 'lpddr4_wm_table_with_disabled_ppt' was not declared. Should it be static?drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/dcn20_fpu.c:767:17: warning: symbol 'ddr4_wm_table_rn' was not declared. Should it be static?drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/dcn20_fpu.c:804:17: warning: symbol 'ddr4_1R_wm_table_rn' was not declared. Should it be static?drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/dcn20_fpu.c:841:17: warning: symbol 'lpddr4_wm_table_rn' was not declared. Should it be static?drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn301/dcn301_fpu.c:217:17: warning: symbol 'ddr4_wm_table' was not declared. Should it be static?drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn301/dcn301_fpu.c:254:17: warning: symbol 'lpddr5_wm_table' was not declared. Should it be static?drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/dcn31_fpu.c:53:30: warning: symbol 'dcn3_1_ip' was not declared. Should it be static?drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/dcn31_fpu.c:197:30: warning: symbol 'dcn3_15_ip' was not declared. Should it be static?drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/dcn31_fpu.c:293:30: warning: symbol 'dcn3_16_ip' was not declared. Should it be static?Fixes: 1a3408259bfd ("drm/amd/display: move FPU code on dcn21 clk_mgr")Fixes: 5085e0361f5a ("drm/amd/display: move FPU code from dcn301 clk mgr to DML folder")Fixes: 26f4712aedbd ("drm/amd/display: move FPU related code from dcn31 to dml/dcn31 folder")Fixes: fa896297b31b ("drm/amd/display: move FPU related code from dcn315 to dml/dcn31 folder")Fixes: 3f8951cc123f ("drm/amd/display: move FPU related code from dcn316 to dml/dcn31 folder")Signed-off-by: Magali Lemes <[email protected]>Reviewed-by: Rodrigo Siqueira <[email protected]>Reviewed-by: Maíra Canal <[email protected]>Reviewed-by: Melissa Wen <[email protected]>Signed-off-by: Alex Deucher <[email protected]>
drm/amd/display: move FPU code from dcn301 clk mgr to DML folderThe -mno-gnu-attribute option in dcn301 clk mgr makefile hides a soft vshard fp error for powerpc. After removing this flag, we can
drm/amd/display: move FPU code from dcn301 clk mgr to DML folderThe -mno-gnu-attribute option in dcn301 clk mgr makefile hides a soft vshard fp error for powerpc. After removing this flag, we can see some FPUcode remains there:gcc-11.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld:drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.o useshard float,drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn301/vg_clk_mgr.ouses soft floatTherefore, remove the -mno-gnu-attribute flag for dcn301/powerpc andmove FPU-associated code to DML folder.Signed-off-by: Melissa Wen <[email protected]>Reviewed-by: Maíra Canal <[email protected]>Reviewed-by: Rodrigo Siqueira <[email protected]>Signed-off-by: Alex Deucher <[email protected]>
drm/amd/display: Use pre-allocated temp struct for bounding box update[Why]There is a theoretical problem in prior patches for reducing the stacksize of *update_bw_bounding_box() functions.By
drm/amd/display: Use pre-allocated temp struct for bounding box update[Why]There is a theoretical problem in prior patches for reducing the stacksize of *update_bw_bounding_box() functions.By modifying the soc.clock_limits[n] struct directly, this can causeunintended behavior as the for loop attempts to swap rows inclock_limits[n]. A temporary struct is still required to make sure westay functinoally equivalent.[How]Add a temporary clock_limits table to the SOC struct, and use it whenswapping rows.Signed-off-by: Leo Li <[email protected]>Reviewed-by: Harry Wentland <[email protected]>Signed-off-by: Alex Deucher <[email protected]>
drm/amd/display: Reduce frame size in the bouding box for DCN301GCC throw warnings for the function dcn301_fpu_update_bw_bounding_boxdue to its frame size that looks like this: error: the frame
drm/amd/display: Reduce frame size in the bouding box for DCN301GCC throw warnings for the function dcn301_fpu_update_bw_bounding_boxdue to its frame size that looks like this: error: the frame size of 1936 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]For fixing this issue I dropped an intermadiate variable.Cc: Stephen Rothwell <[email protected]>Cc: Hamza Mahfooz <[email protected]>Cc: Aurabindo Pillai <[email protected]>Reviewed-by: Harry Wentland <[email protected]>Reviewed-by: Alex Deucher <[email protected]>Signed-off-by: Rodrigo Siqueira <[email protected]>Signed-off-by: Alex Deucher <[email protected]>
drm/amd/display: Wrap dcn301_calculate_wm_and_dlg for FPU.Mirrors the logic for dcn30. Cue lots of WARNs and somekernel panics without this fix.Cc: [email protected]Signed-off-by: Bas Nieu
drm/amd/display: Wrap dcn301_calculate_wm_and_dlg for FPU.Mirrors the logic for dcn30. Cue lots of WARNs and somekernel panics without this fix.Cc: [email protected]Signed-off-by: Bas Nieuwenhuizen <[email protected]>Signed-off-by: Alex Deucher <[email protected]>
drm/amd/display: move FPU associated DCN301 code to DML folder[Why & How]As part of the FPU isolation work documented inhttps://patchwork.freedesktop.org/series/93042/, isolatecode that uses FPU
drm/amd/display: move FPU associated DCN301 code to DML folder[Why & How]As part of the FPU isolation work documented inhttps://patchwork.freedesktop.org/series/93042/, isolatecode that uses FPU in DCN301 to DML, where all FPU codeshould locate.Cc: Christian König <[email protected]>Cc: Harry Wentland <[email protected]>Cc: Rodrigo Siqueira <[email protected]>Tested-by: Zhan Liu <[email protected]>Tested-by: Daniel Wheeler <[email protected]>Signed-off-by: Qingqing Zhuo <[email protected]>Reviewed-by: Rodrigo Siqueira <[email protected]>Signed-off-by: Alex Deucher <[email protected]>