History log of /lighttpd1.4/src/mod_staticfile.c (Results 1 – 25 of 64)
Revision (<<< Hide revision tags) (Show revision tags >>>) Date Author Comments
Revision tags: lighttpd-1.4.69, lighttpd-1.4.68
# 5e14db43 10-Dec-2022 Glenn Strauss <[email protected]>

[multiple] employ ck_calloc, ck_malloc shared code

employ ck_calloc(), ck_malloc() shared code to slightly reduce code size
(centralize the ck_assert() to check that memory allocation succeeded)


# b82d7b8a 06-Dec-2022 Glenn Strauss <[email protected]>

[multiple] mark mod_*_plugin_init() funcs cold


Revision tags: lighttpd-1.4.67, lighttpd-1.4.66, lighttpd-1.4.65
# d0494fc0 14-Apr-2022 Glenn Strauss <[email protected]>

[multiple] recognize HTTP QUERY method

x-ref:
https://www.ietf.org/id/draft-ietf-httpbis-safe-method-w-body-02.html


Revision tags: lighttpd-1.4.64, lighttpd-1.4.63, lighttpd-1.4.62, lighttpd-1.4.61, lighttpd-1.4.60
# 67c0b149 02-Aug-2021 Glenn Strauss <[email protected]>

[multiple] remove base.h include where not used

(substitute request.h if file only accesses request_st,
and not connection or server structs)


# 91472ab7 07-Jul-2021 Glenn Strauss <[email protected]>

[tests] t/test_mod_staticfile

move some tests from tests/request.t to src/t/test_mod_staticfile.c


# af3df29a 09-Jun-2021 Glenn Strauss <[email protected]>

[multiple] reduce redundant NULL buffer checks

This commit is a large set of code changes and results in removal of
hundreds, perhaps thousands, of CPU instructions, a portion of which
are on hot co

[multiple] reduce redundant NULL buffer checks

This commit is a large set of code changes and results in removal of
hundreds, perhaps thousands, of CPU instructions, a portion of which
are on hot code paths.

Most (buffer *) used by lighttpd are not NULL, especially since buffers
were inlined into numerous larger structs such as request_st and chunk.

In the small number of instances where that is not the case, a NULL
check is often performed earlier in a function where that buffer is
later used with a buffer_* func. In the handful of cases that remained,
a NULL check was added, e.g. with r->http_host and r->conf.server_tag.

- check for empty strings at config time and set value to NULL if blank
string will be ignored at runtime; at runtime, simple pointer check
for NULL can be used to check for a value that has been set and is not
blank ("")
- use buffer_is_blank() instead of buffer_string_is_empty(),
and use buffer_is_unset() instead of buffer_is_empty(),
where buffer is known not to be NULL so that NULL check can be skipped
- use buffer_clen() instead of buffer_string_length() when buffer is
known not to be NULL (to avoid NULL check at runtime)
- use buffer_truncate() instead of buffer_string_set_length() to
truncate string, and use buffer_extend() to extend

Examples where buffer known not to be NULL:
- cpv->v.b from config_plugin_values_init is not NULL if T_CONFIG_BOOL
(though we might set it to NULL if buffer_is_blank(cpv->v.b))
- address of buffer is arg (&foo)
(compiler optimizer detects this in most, but not all, cases)
- buffer is checked for NULL earlier in func
- buffer is accessed in same scope without a NULL check (e.g. b->ptr)

internal behavior change:
callers must not pass a NULL buffer to some funcs.
- buffer_init_buffer() requires non-null args
- buffer_copy_buffer() requires non-null args
- buffer_append_string_buffer() requires non-null args
- buffer_string_space() requires non-null arg

show more ...


# 57c8b328 04-May-2021 Glenn Strauss <[email protected]>

[mod_staticfile] move cold paths to separate func


# 9a5e1652 04-May-2021 Glenn Strauss <[email protected]>

[multiple] static file optimization; reuse cache

reuse cache lookup in common case of serving a static file
rather than repeating the stat_cache_entry lookup
(which is more work than memcmp() to re-

[multiple] static file optimization; reuse cache

reuse cache lookup in common case of serving a static file
rather than repeating the stat_cache_entry lookup
(which is more work than memcmp() to re-check stat_cache_entry match)

show more ...


Revision tags: lighttpd-1.4.59, lighttpd-1.4.58, lighttpd-1.4.57, lighttpd-1.4.56, lighttpd-1.4.56-rc7, lighttpd-1.4.56-rc6, lighttpd-1.4.56-rc5, lighttpd-1.4.56-rc4, lighttpd-1.4.56-rc3, lighttpd-1.4.56-rc2, lighttpd-1.4.56-rc1, lighttpd-1.4.55
# 7c7f8c46 13-Jan-2020 Glenn Strauss <[email protected]>

[multiple] split con, request (very large change)

NB: r->tmp_buf == srv->tmp_buf (pointer is copied for quicker access)

NB: request read and write chunkqueues currently point to connection
chun

[multiple] split con, request (very large change)

NB: r->tmp_buf == srv->tmp_buf (pointer is copied for quicker access)

NB: request read and write chunkqueues currently point to connection
chunkqueues; per-request and per-connection chunkqueues are
not distinct from one another
con->read_queue == r->read_queue
con->write_queue == r->write_queue

NB: in the future, a separate connection config may be needed for
connection-level module hooks. Similarly, might need to have
per-request chunkqueues separate from per-connection chunkqueues.
Should probably also have a request_reset() which is distinct from
connection_reset().

show more ...


# cc2134c8 11-Jan-2020 Glenn Strauss <[email protected]>

[multiple] copy small struct instead of memcpy()

when patching config


# 31d94953 11-Jan-2020 Glenn Strauss <[email protected]>

[core] store subrequest_handler instead of mode

store pointer to module in handler_module instead of con->mode id


# 19985261 10-Dec-2019 Glenn Strauss <[email protected]>

[core] convenience macros to check req methods


# 03b4c993 08-Dec-2019 Glenn Strauss <[email protected]>

[multiple] generic config array type checking


# 50bdb55d 26-Nov-2019 Glenn Strauss <[email protected]>

[multiple] connection hooks no longer get (srv *)

(explicit (server *) not passed; available in con->srv)


# 010c2894 25-Nov-2019 Glenn Strauss <[email protected]>

[multiple] prefer (connection *) to (srv *)

convert all log_error_write() to log_error() and pass (log_error_st *)

use con->errh in preference to srv->errh (even though currently same)

avoid passi

[multiple] prefer (connection *) to (srv *)

convert all log_error_write() to log_error() and pass (log_error_st *)

use con->errh in preference to srv->errh (even though currently same)

avoid passing (server *) when previously used only for logging (errh)

show more ...


# b73949e0 19-Nov-2019 Glenn Strauss <[email protected]>

[multiple] plugin.c handles common FREE_FUNC code

(simpler for modules; less boilerplate to cut-n-paste)


# ed62e354 16-Nov-2019 Glenn Strauss <[email protected]>

[core] use config_plugin_values_init()


# 49140fe3 24-Oct-2019 Glenn Strauss <[email protected]>

[mod_staticfile] use config_plugin_values_init()


# e2de4e58 19-Oct-2019 Glenn Strauss <[email protected]>

[core] const char *name in struct plugin

put void *data (always used) as first member of struct plugin

add int nconfig member to PLUGIN_DATA

calloc() inits p->data to NULL


# 36f64b26 17-Oct-2019 Glenn Strauss <[email protected]>

[core] simpler config_check_cond()

optimize for common case where condition has been evaluated for
the request and a cached result exists

(also: begin isolating data_config)


# 47a758f9 13-Oct-2019 Glenn Strauss <[email protected]>

[core] inline buffer key for *_patch_connection()

handle buffer key as part of DATA_UNSET in *_patch_connection()
(instead of key being (buffer *))


Revision tags: lighttpd-1.4.54
# 6a988bb0 27-Feb-2019 Mohammed Sadiq <[email protected]>

[multiple] cleaner calloc use in SETDEFAULTS_FUNC

github: closes #99

x-ref:
"cleaner calloc use in SETDEFAULTS_FUNC"
https://github.com/lighttpd/lighttpd1.4/pull/99


# b8532fe0 04-Feb-2019 Glenn Strauss <[email protected]>

[mod_staticfile] search ext array if not empty


Revision tags: lighttpd-1.4.53, lighttpd-1.4.52, lighttpd-1.4.51
# d61f3381 16-Sep-2018 Glenn Strauss <[email protected]>

[multiple] code reuse: employ array_match_*()


Revision tags: lighttpd-1.4.50, lighttpd-1.4.49, lighttpd-1.4.48, lighttpd-1.4.47, lighttpd-1.4.46
# cafb091c 22-Jun-2017 Glenn Strauss <[email protected]>

[core] remove unused includes of stat_cache.h


123