[multiple] store ptrs to remote addr in request_st (#3192)

adds two pointers to (request_st *) (cost: 16 bytes in 64-bit builds)

prepares for upcoming changes to mod_extforward to manage remote add

[multiple] store ptrs to remote addr in request_st (#3192)

adds two pointers to (request_st *) (cost: 16 bytes in 64-bit builds)

prepares for upcoming changes to mod_extforward to manage remote addr
per request for HTTP/2 requests, rather than remote addr per connection.

Modern load balancers often provide options to reuse connections for
*different* clients, and therefore mod_extforward might change the
remote addr per request.

x-ref:
"RFE: mod_extforward and multiplexed requests via HTTP/2"
https://redmine.lighttpd.net/issues/3192
"Evaluation of remote_addr for mod_maxminddb for multiplexed connections"
https://redmine.lighttpd.net/issues/3191

show more ...

[multiple] employ ck_calloc, ck_malloc shared code

employ ck_calloc(), ck_malloc() shared code to slightly reduce code size
(centralize the ck_assert() to check that memory allocation succeeded)

[multiple] mark mod_*_plugin_init() funcs cold

[mod_magnet] remove lighty.r.req_attr["response.*"]

remove experimental lighty.r.req_attr["response.*"] accessors
(added in lighttpd 1.4.56 (2020) and replaced in lighttpd 1.4.65 (2022))

[core] http_response_body_clear clears body flags

http_response_body_clear() clears body flags
r->resp_body_started
r->resp_body_finished

[core] buffer_append_bs_escaped_json()

separate func from buffer_append_bs_escaped() so that both
buffer_append_bs_escaped() and buffer_append_bs_escaped_json()
can be slightly more specialized and

[core] buffer_append_bs_escaped_json()

separate func from buffer_append_bs_escaped() so that both
buffer_append_bs_escaped() and buffer_append_bs_escaped_json()
can be slightly more specialized and optimized

show more ...

[multiple] fix json encoding

(thx helmut)

fix json encoding to operate on unicode code points

[mod_magnet] reset for http-response-send-file

reset r->http_status and clear response body for http-response-send-file
called from magnet.attract-response-start-to in order to match
http_response_s

[mod_magnet] reset for http-response-send-file

reset r->http_status and clear response body for http-response-send-file
called from magnet.attract-response-start-to in order to match
http_response_send_file() behavior to send ETag, replace response body

show more ...

[mod_magnet] skip req body collect warn if modsec3

skip req body collect warning if handler is already mod_security3
(prototype mod_security3 uses similar technique to collect req body)

[mod_magnet] r.req_body .collect .get .set .add

[mod_magnet] quiet coverity false positive

[multiple] rename status_counter -> plugin_stats

[mod_magnet] backspace-escape encode/decode

lighty.c.bsdec
lighty.c.bsenc
lighty.c.bsenc_json

[mod_magnet] read-only access to r->server_name

read-only access to r->server_name for coverage

setting r.req_attr["uri.authority"] in lua sets both r->uri.authority
and points r->server_name to r-

[mod_magnet] read-only access to r->server_name

read-only access to r->server_name for coverage

setting r.req_attr["uri.authority"] in lua sets both r->uri.authority
and points r->server_name to r->uri.authority, and there is not an
obvious (to me) need to be able to set r->server_name separately.

(r->server_name might be set in lighttpd.conf, or else is the same as
r->uri.authority, unless modified by mod_simple_vhost default_host)

show more ...

[multiple] simplify bytes_in/bytes_out accounting

encapsulate accounting calculations in
http_request_stats_bytes_in()
http_request_stats_bytes_out()

more accurate accounting for HTTP/1.1 bytes_i

[multiple] simplify bytes_in/bytes_out accounting

encapsulate accounting calculations in
http_request_stats_bytes_in()
http_request_stats_bytes_out()

more accurate accounting for HTTP/1.1 bytes_in on keep-alive requests
(affects case where client pipelines HTTP/1.1 requests)

remove con->bytes_read and con->bytes_written
(no longer needed since request_st was split from connection struct
and request bytes_read_ckpt and bytes_written_ckpt are maintained
for HTTP/1.x bytes_in and bytes_out accounting. Also, further back,
chunkqueue internal accounting was simplified to maintain bytes_in
and bytes_out to always match chunkqueue length)

show more ...

[multiple] use buffer_append_char()

[mod_magnet] further isolate legacy API result tbl

[mod_magnet] adjust p->conf.stage checks

[mod_magnet] format multiline err traceback

[mod_magnet] lighty.c.stat high precision time

lighty.c.stat returns high precision timestamps, when available

[mod_magnet] separate funcs for uri_path_raw

separate funcs to get/set uri_path_raw in target (r->target)
without modifying the query-string part of the target (r->target)

[mod_magnet] deprecate r.req_attr["response.*]

deprecate lighty.r.req_attr["response.*] which returned strings
These experimental interfaces were added in lighttpd 1.4.56
along with addition of conf

[mod_magnet] deprecate r.req_attr["response.*]

deprecate lighty.r.req_attr["response.*] which returned strings
These experimental interfaces were added in lighttpd 1.4.56
along with addition of config magnet.attract-response-start-to = "...",
so this only affects new users of experimental interfaces in a new hook

deprecated experimental interfaces will be removed in next lighttpd rel

replacements:
r.req_attr["response.http-status"] -> r.req_item.http_status -- (int)
r.req_attr["response.body-length"] -> r.resp_body.len -- (int)
r.req_attr["response.body"] -> r.resp_body.get -- (str)

show more ...

[mod_magnet] lighty.r.resp_body.get

(replacement for lighty.r.req_attr["response.body"])

[mod_magnet] lighty.c.hrtime high-resolution time

[mod_magnet] expose r->keep_alive to lua scripts

lighty.r.req_item.keep_alive

Allow lua scripts to set to 0 or -1. Setting to -1 might be used when
rejecting authentication, and this value will ca

[mod_magnet] expose r->keep_alive to lua scripts

lighty.r.req_item.keep_alive

Allow lua scripts to set to 0 or -1. Setting to -1 might be used when
rejecting authentication, and this value will cause lighttpd to delay
the 401 Unauthorized response if the server feature is enabled (default)
server.feature-flags += ("auth.delay-invalid-creds" => "enable")

show more ...