test: fix UB in evbuffer/empty_reference_prepend_buffer

UBSAN reports:
test/regress_buffer.c:2360:2: runtime error: null pointer passed as argument 1, which is declared to never be null
/usr/inc

test: fix UB in evbuffer/empty_reference_prepend_buffer

UBSAN reports:
test/regress_buffer.c:2360:2: runtime error: null pointer passed as argument 1, which is declared to never be null
/usr/include/string.h:140:33: note: nonnull attribute specified here

(cherry picked from commit ba19b356bf8a9be2a5bddfa264dee61ffc9573a7)

show more ...

buffer: do not pass NULL to memcpy() from evbuffer_pullup()

UBSAN reports:

evbuffer/remove_buffer_with_empty3: ../buffer.c:1443:3: runtime error: null pointer passed as argument 2, which is decla

buffer: do not pass NULL to memcpy() from evbuffer_pullup()

UBSAN reports:

evbuffer/remove_buffer_with_empty3: ../buffer.c:1443:3: runtime error: null pointer passed as argument 2, which is declared to never be null
#0 0x7ffff6cd0410 in evbuffer_pullup ../buffer.c:1443
#1 0x5555556d68b9 in test_evbuffer_remove_buffer_with_empty3 ../test/regress_buffer.c:408
#2 0x5555557b95ee in testcase_run_bare_ ../test/tinytest.c:173
#3 0x5555557ba048 in testcase_run_one ../test/tinytest.c:333
#4 0x5555557bc0f8 in tinytest_main ../test/tinytest.c:527
#5 0x555555787702 in main ../test/regress_main.c:528
#6 0x7ffff606c001 in __libc_start_main (/usr/lib/libc.so.6+0x27001)
#7 0x55555569436d in _start (/src/le/libevent/.cmake-debug/bin/regress+0x14036d)

(cherry picked from commit a0c642ac04487d8cda809bd6e233b0fbd043806d)

show more ...

Merge branch 'upstream/pr/899' (evbuffer_freeze testcase enhancements)

* upstream/pr/899:
improve the description of parameter to evbuffer_read()
regress_buffer: improve testcase for evbuffer_fr

Merge branch 'upstream/pr/899' (evbuffer_freeze testcase enhancements)

* upstream/pr/899:
improve the description of parameter to evbuffer_read()
regress_buffer: improve testcase for evbuffer_freeze()

(cherry picked from commit a977d6963611c729b75108d31bf74718b7b3e06d)

show more ...

buffer: fix possible NULL dereference in evbuffer_setcb() on ENOMEM

[ @azat:

- add return heredoc for evbuffer_setcb()
- add unit test with event_set_mem_functions()
- look through the report

buffer: fix possible NULL dereference in evbuffer_setcb() on ENOMEM

[ @azat:

- add return heredoc for evbuffer_setcb()
- add unit test with event_set_mem_functions()
- look through the report from abi-compliance-checker/abi-dumper
]

Closes: #855
(cherry picked from commit bdcade47224f154052c927aed3c363a18b37112e)

show more ...

Merge branch 'evbuffer-fixes-806-v2'

* evbuffer-fixes-806-v2:
evbuffer: fix last_with_datap after prepend with empty chain
test: regression for evbuffer_expand_fast_() with invalid last_with_dat

Merge branch 'evbuffer-fixes-806-v2'

* evbuffer-fixes-806-v2:
evbuffer: fix last_with_datap after prepend with empty chain
test: regression for evbuffer_expand_fast_() with invalid last_with_datap
test: cover adjusting of last_with_datap in evbuffer_prepend()

Fixes: #806
(cherry picked from commit 3b1864b625ec37c3051512845982f347f4cc5621)

show more ...

Merge branch 'evbuffer-empty-chain-handling'

* evbuffer-empty-chain-handling:
buffer: do not rely on ->off in advance_last_with_data()
buffer: fix evbuffer_remove_buffer() with empty chain in fr

Merge branch 'evbuffer-empty-chain-handling'

* evbuffer-empty-chain-handling:
buffer: do not rely on ->off in advance_last_with_data()
buffer: fix evbuffer_remove_buffer() with empty chain in front
test: verify content of the buffer in evbuffer/remove_buffer_with_empty*

(cherry picked from commit b69524c004fb68bcd9475e7aa61f5a7cdb45d304)

show more ...

test/buffer: cover evbuffer_expand() for overflow

Refs: #306
Refs: #340

test/buffer: evbuffer_add_buffer() with empty chains

Reported-by: @EMPanisset
Link: https://github.com/libevent/libevent/issues/358#issuecomment-225345697

test/buffer: evbuffer_remove_buffer() with empty chains (prepend)

Using:
- evbuffer_add()
- evbuffer_prepend_buffer()
- evbuffer_add_reference()
- evbuffer_remove_buffer()

test/buffer: evbuffer_remove_buffer() with empty chains (evbuffer_add_buffer())

Using:
- evbuffer_add()
- evbuffer_add_buffer() -- the one that has problem
- evbuffer_add_reference() -- the only one

test/buffer: evbuffer_remove_buffer() with empty chains (evbuffer_add_buffer())

Using:
- evbuffer_add()
- evbuffer_add_buffer() -- the one that has problem
- evbuffer_add_reference() -- the only one that allows empty chains to be added
- evbuffer_remove_buffer()

show more ...

test/buffer: fix leak in test_evbuffer_prepend()

test/buffer: avoid errors with --no-fork (reinitialize static vars)

test/buffer: cover n_add_for_cb when evbuffer_prepend() need to allocate buffer

Regression-for: 0abd0393eaf029e1ead8a09b479ea6830f7152ee ("Fix n_add_for_cb in
evbuffer_prepend() in case of new buffe

test/buffer: cover n_add_for_cb when evbuffer_prepend() need to allocate buffer

Regression-for: 0abd0393eaf029e1ead8a09b479ea6830f7152ee ("Fix n_add_for_cb in
evbuffer_prepend() in case of new buffer required")

show more ...

test/regress: add tests for evbuffer_add() breakage on empty last chain

The evbuffer/add* tests currenly break on 2.0.21, 2.0.22 and 2.1 HEAD
due to issue #335. The evbuffer/reference2 test breaks o

test/regress: add tests for evbuffer_add() breakage on empty last chain

The evbuffer/add* tests currenly break on 2.0.21, 2.0.22 and 2.1 HEAD
due to issue #335. The evbuffer/reference2 test breaks on 2.0.21 and
2.0.22 due to commit b18c04dd not being applied.

show more ...

test/regress_buffer: fix clang compilation warnings

../test/regress_buffer.c:201:12: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]

test/regress_buffer: fix clang compilation warnings

../test/regress_buffer.c:201:12: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
tt_assert(!memcmp((char*)EVBUFFER_DATA(evb), "1/hello", 7) != 0);

show more ...

Don't use BSD u_* types.

These types are not part of POSIX. As we only use them in a small number
of places, we'd better replace them by C standard types. This makes a
larger part of the code build

Don't use BSD u_* types.

These types are not part of POSIX. As we only use them in a small number
of places, we'd better replace them by C standard types. This makes a
larger part of the code build for CloudABI.

show more ...

More evbuffer_peek() test cases

test/evbuffer_peek: add regress in case we have first buffer greater

Fix several memory leaks in the unit tests.

Also add a comment to buffer.c about why we call
evbuffer_file_segment_free on failure to add the segment.

Make a buffer larger in the tests to avoid a scary evbuffer_copyout_from()

The call was safe, but coverity couldn't tell. CID 1239294.

Fix a use-after-free in unit tests. CID 752027

regress_buffer: fix 'memcmp' compare size

Update to a more recent tinytest_macros.

This one has less of a tendency to suppress important type warnings.

Fix an illegal read error in the evbuffer_add_reference tests

Found with AddressSanitizer

Fix even more coverity warnings.