suppress -Wunused-variable when HAVE_SENDFILE is undefined

Suppress following compiler warning when there is no HAVE_SENDFILE
support:

/lib/iperf3/src/net.c: In function 'Nsendfile':
/lib/iperf

suppress -Wunused-variable when HAVE_SENDFILE is undefined

Suppress following compiler warning when there is no HAVE_SENDFILE
support:

/lib/iperf3/src/net.c: In function 'Nsendfile':
/lib/iperf3/src/net.c:449:11: warning: unused variable 'offset' [-Wunused-variable]
449 | off_t offset;
| ^~~~~~

show more ...

trim excess whitespace

Fix --bind-dev options for TCP streams. (#1099)

netdial() honors --bind-dev option but iperf_tcp_connect() doesn't,
as a result, only the control socket is bound to the device, but not
the data sock

Fix --bind-dev options for TCP streams. (#1099)

netdial() honors --bind-dev option but iperf_tcp_connect() doesn't,
as a result, only the control socket is bound to the device, but not
the data socket.

Instead of duplicaing code from netdial to iperf_tcp_connect(), this
fix extracts a common util function create_socket() from netdial() and
let iperf_tcp_connect() call create_socket() to create a socket with
optional bindings.

Tested on Raspberry Pi 3 with eth0 and wlan0.

show more ...

fix: Remove the inclusion of tcp.h as it is included by iperf.h (#1122)

This fixes a build breakage on Alpine Linux, where tcp.h was explicitly included in src/net.c before _GNU_SOURCE was defined i

fix: Remove the inclusion of tcp.h as it is included by iperf.h (#1122)

This fixes a build breakage on Alpine Linux, where tcp.h was explicitly included in src/net.c before _GNU_SOURCE was defined in iperf.h.

show more ...

enh: Support SO_BINDTODEVICE (#1097)

This lets iperf work better with multi-homed machines and
VRF.

Fixes #1089.

Based on a patch by Ben Greear <[email protected]> via PR #817.

Co-au

enh: Support SO_BINDTODEVICE (#1097)

This lets iperf work better with multi-homed machines and
VRF.

Fixes #1089.

Based on a patch by Ben Greear <[email protected]> via PR #817.

Co-authored-by: Ben Greear <[email protected]>

show more ...

chore: Change applicable function arguments from 'char *' to 'const char *' (#1006)

Fixes #946. Should not present any functional changes.

fix hotn?, strcasecmp and timeval isn't defined error

by including arpa/inet.h, strings.h and sys/timer.h

Part of #935.

Change-Id: Ibac8d3a992457f2a7cc10f74b144e3ebe69976d8
Signed-off-by: Xiang Xi

fix hotn?, strcasecmp and timeval isn't defined error

by including arpa/inet.h, strings.h and sys/timer.h

Part of #935.

Change-Id: Ibac8d3a992457f2a7cc10f74b144e3ebe69976d8
Signed-off-by: Xiang Xiao <[email protected]>
(cherry picked from commit b9aa6cef43b338666a72bf6425fc88ed7602bce5)
Signed-off-by: Bruce A. Mah <[email protected]>

show more ...

fix: Emit appropriate error messages from getaddrinfo(3). (#888)

* fix: Emit appropriate error messages from getaddrinfo(3).

This fixes an omission likely caused when switching resolver
library

fix: Emit appropriate error messages from getaddrinfo(3). (#888)

* fix: Emit appropriate error messages from getaddrinfo(3).

This fixes an omission likely caused when switching resolver
library calls. Fixes #846.

show more ...

Make --cport work without --bind (#697).

This commit also adds SCTP support for --cport.

Fixes #616.

Fix large values of -p on FreeBSD by setting a large listen(2) backlog. (#693)

Might be useful for other platforms as well (no effects on Linux
because the semantics of listen(2) are subtly differe

Fix large values of -p on FreeBSD by setting a large listen(2) backlog. (#693)

Might be useful for other platforms as well (no effects on Linux
because the semantics of listen(2) are subtly different there).
Submitted by Matt Macy. Fixes #691.

show more ...

Add missing saved_errno dance around some close(2) calls. (#669)

Remove unused functions (#668)

Namely, getsock_tcp_mss(), set_tcp_options() and iperf_test_reset().
Also fix a typo in the libiperf manual;
iperf_test_reset() was listed instead of iperf_reset_te

Remove unused functions (#668)

Namely, getsock_tcp_mss(), set_tcp_options() and iperf_test_reset().
Also fix a typo in the libiperf manual;
iperf_test_reset() was listed instead of iperf_reset_test().

show more ...

Fix 3.3 build warnings (#664)

* Fix warnings about _GNU_SOURCE being redefined.

Signed-off-by: Philip Prindeville <[email protected]>

* Fix warnings of format-specified mismatching

Fix 3.3 build warnings (#664)

* Fix warnings about _GNU_SOURCE being redefined.

Signed-off-by: Philip Prindeville <[email protected]>

* Fix warnings of format-specified mismatching type

Signed-off-by: Philip Prindeville <[email protected]>

* Simplify endianness checks

Linux can be built with too many types of C run-time library and it's
not reasonable to have to enumerate all of them, especially since at
least one of them (MUSL) goes out of its way to not be easily
detectable.

Instead, leverage autoconf better for Linux/BSD to detect either
<endian.h> or <sys/endian.h> directly.

Signed-off-by: Philip Prindeville <[email protected]>

* Sys headers should not be included directly

There's usually a top-level header which then includes the sys/
descendent.

Signed-off-by: Philip Prindeville <[email protected]>

show more ...

Fix another compiler warning.

Issue 216 (#581)

* Add configurable timeout for the setup of the control connection.
This is specified using the new --connect-timeout option, with an
integer parameter in ms. The iperf3 client w

Issue 216 (#581)

* Add configurable timeout for the setup of the control connection.
This is specified using the new --connect-timeout option, with an
integer parameter in ms. The iperf3 client will wait for this
amount of time for the setup of the control connection to the
server. If this option is not given, the OS default for TCP
connection setup is used. Specifying a smaller connection timeout
allows faster detection of a down / unresponsive iperf3 server.

The implementation uses a variation on the timeout_connect()
function from OpenBSD's netcat utility.

Fixes #216.

show more ...

Fixes a smashing stack problem as described in https://bugzilla.kernel.org/show_bug.cgi?id=104601

Handle the case where EAGAIN != EWOULDBLOCK

Fixes #268, suggested by @tvastri.

Drop out of multisend loop if none of the streams are accepting data

Fix calculation of sendfile throughput on OSX

Note that sendfile can return -1 for EINTR whilst having already sent
partial results; these were not being counted previously.

Update license and copyright text to conform to LBNL standards.

Note that the license remains a 3-clause BSD license; the only
license changes were to add the name of the program and to add
some pun

Update license and copyright text to conform to LBNL standards.

Note that the license remains a 3-clause BSD license; the only
license changes were to add the name of the program and to add
some punctuation.

show more ...

specify client-side port: UDP support

--cport can be specified for udp connections

Signed-off-by: Kevin Constantine <[email protected]>

Don't try to do IPV6_V6ONLY on OpenBSD either.

setsockopt(3) returns an error if passing 0 to this option (which
we do if no address family is specified when we bind to the wildcard
address, say by

Don't try to do IPV6_V6ONLY on OpenBSD either.

setsockopt(3) returns an error if passing 0 to this option (which
we do if no address family is specified when we bind to the wildcard
address, say by invoking "iperf3 -s" with no other options). This
is because OpenBSD explicitly does not support IPv4-mapped addresses,
so even though the IPV6_V6ONLY socket options exists, it only works
with a non-zero argument.

Fixes #196.

show more ...

Only do the IPV6_V6ONLY setsockopt(3) stuff if that option is available.

Should fix #177, in which compilation failed on older Solaris systems
that didn't have it. This is a different approach than

Only do the IPV6_V6ONLY setsockopt(3) stuff if that option is available.

Should fix #177, in which compilation failed on older Solaris systems
that didn't have it. This is a different approach than a patch
suggested in that issue.

Weakly regression-tested on other platforms (test this by specifying
-6, -4, or neither to the server when binding to the wildcard address,
and seeing if a client can connect with various of -6, -4, or neither).

show more ...

Fix a problem with binding to the wildcard address.

On CentOS 6 and MacOS, if no address family was specified, we'd
get back an IPv4 address from getaddrinfo(3), with the result that
we couldn't acc

Fix a problem with binding to the wildcard address.

On CentOS 6 and MacOS, if no address family was specified, we'd
get back an IPv4 address from getaddrinfo(3), with the result that
we couldn't accept IPv6 connections in the default server configuration.

There was an earlier attempt at fixing this problem that caused
Issue #193. This change is a follow-up fix to that issue.

While here, put lots of comments around the fix so we remember
why we're doing these shenanigans.

show more ...

Fix two related bugs with -B and IPv4 addresses.

If specifying -B with an IPv4 literal address or with an FQDN that
resolved to an IPv4 address, but we had not explicitly specified an
address family

Fix two related bugs with -B and IPv4 addresses.

If specifying -B with an IPv4 literal address or with an FQDN that
resolved to an IPv4 address, but we had not explicitly specified an
address family with -4, we failed to set up the socket correctly
because we assumed binding to an IPv6 address, and instead (after some
error spewage) wound up binding to wildcard address.

The fix in this commit has multiple parts: First, if the address
family hasn't been explictly specified, don't force AF_INET6 in the
hints to getaddrinfo(3). AF_UNSPEC should generate the correct
(according to RFC 6724) behavior.

Second, iperf_reset_test() should not discard members that were passed
from command-line parameters, because that alters the behavior of the
iperf3 when it tries to recreate the listening socket. In the failure
situation described in this issue (and possibly other as well), the
value of -B gets discarded, so on subsequent attempts to set up the
listening socket it just binds to the wildcard address.

While here, fix on-line help related to the -B option to match
reality.

Note that we're not completely in compliance with RFC 6724, which
states that we should actually try all of the addresses in returned by
getaddrinfo(3), rather than just the first one.

Fixes Issue #193.

show more ...