trim excess whitespace

enh: Support SO_BINDTODEVICE (#1097)

This lets iperf work better with multi-homed machines and
VRF.

Fixes #1089.

Based on a patch by Ben Greear <[email protected]> via PR #817.

Co-au

enh: Support SO_BINDTODEVICE (#1097)

This lets iperf work better with multi-homed machines and
VRF.

Fixes #1089.

Based on a patch by Ben Greear <[email protected]> via PR #817.

Co-authored-by: Ben Greear <[email protected]>

show more ...

Fix warning: "HAVE_SCTP" redefined (#1010)

The netinet/sctp.h header file defines HAVE_SCTP, so we have this
warning while building:

In file included from ../../src/iperf.h:30,

Fix warning: "HAVE_SCTP" redefined (#1010)

The netinet/sctp.h header file defines HAVE_SCTP, so we have this
warning while building:

In file included from ../../src/iperf.h:30,
from ../../src/iperf_sctp.c:46:
./iperf_config.h:44: warning: "HAVE_SCTP" redefined
44 | #define HAVE_SCTP 1
|
In file included from ../../src/iperf_sctp.c:43:
/usr/include/netinet/sctp.h:56: note: this is the location of the previous definition
56 | #define HAVE_SCTP
|

This patch replaces our HAVE_SCTP definition with HAVE_SCTP_H to avoid
this warning.

Signed-off-by: Stefano Garzarella <[email protected]>

show more ...

Fix for possible leaks or double frees (#968)

add window size support for sctp (#926)

fix: Emit appropriate error messages from getaddrinfo(3). (#888)

* fix: Emit appropriate error messages from getaddrinfo(3).

This fixes an omission likely caused when switching resolver
library

fix: Emit appropriate error messages from getaddrinfo(3). (#888)

* fix: Emit appropriate error messages from getaddrinfo(3).

This fixes an omission likely caused when switching resolver
library calls. Fixes #846.

show more ...

tcp sctp: Let the system pick the largest possible backlog value for `listen()` (#827)

This commit applies the same changes made by b481169 (#693), to the
TCP and SCTP server sockets.

Fix -B with some SCTP tests, which is part of #678 (#715)

Got the following error when running server side with -B option:

Server side:
./iperf3 -s -B <server_ipv4_address>
------------

Fix -B with some SCTP tests, which is part of #678 (#715)

Got the following error when running server side with -B option:

Server side:
./iperf3 -s -B <server_ipv4_address>
-----------------------------------------------------------
Server listening on 5201
-----------------------------------------------------------
iperf3: error - unable to start stream listener: Bad file descriptor
-----------------------------------------------------------

Client side:
./iperf3 -c <server_ipv4_address> --sctp
iperf3: error - unable to start stream listener: No such file or directory

Similar fix as below for TCP:
commit eb1cfe5e162d08efdf18fa12cd6627cfdcd675a7
Author: Bruce A. Mah <[email protected]>
Date: Fri Aug 1 16:24:14 2014 -0700

Another iteration on issue #193, fixes -B with some TCP tests.

Signed-off-by: Jianwen Ji <[email protected]>

show more ...

Fix issue 692 (#705)

Don't count data for tests received after the end of a test.
This prevents is from reporting an incorrect number of bytes
received at the end of the test, which doesn't match

Fix issue 692 (#705)

Don't count data for tests received after the end of a test.
This prevents is from reporting an incorrect number of bytes
received at the end of the test, which doesn't match up with the
sum of the data received during the test intervals.
Log late receives if debugging mode enabled.

Fixes #692.

show more ...

Make --cport work without --bind (#697).

This commit also adds SCTP support for --cport.

Fixes #616.

Add missing saved_errno dance around some close(2) calls. (#669)

Fix compiler warning with clang.

Fix header includes and build failures on musl (#518)

* Include stdint.h in files where its types are used

Signed-off-by: Moritz Kick <[email protected]>

* Fix type of len para

Fix header includes and build failures on musl (#518)

* Include stdint.h in files where its types are used

Signed-off-by: Moritz Kick <[email protected]>

* Fix type of len parameter passed to getsockopt

getsockopt expects socklen_t instead of int as its fifth argument

Signed-off-by: Moritz Kick <[email protected]>

* Remove unnecassary includes of netinet/tcp.h

also cleanup the second include of stdint.h in main.c

This commit fixes #331 and is a replacement for #344.

Signed-off-by: Moritz Kick <[email protected]>

show more ...

Unbreak (partially) SCTP on Solaris.

Solaris implements an (older?) version of the API for SCTP_MAXSEG,
which takes an integer argument rather than a struct sctp_assoc_val.
We need to test for that

Unbreak (partially) SCTP on Solaris.

Solaris implements an (older?) version of the API for SCTP_MAXSEG,
which takes an integer argument rather than a struct sctp_assoc_val.
We need to test for that and handle it appropriately. There are some
signs it doesn't even work correctly if we do this, so quietly ignore
errors that happen if the OS complains it's unsupported.

Also, Solaris doesn't support SCTP_DISABLE_FRAGMENTS even though it
defines the preprocessor symbol for this. Rather than aborting when
we try to unsuccessfully unset this option, just ignore the error.

Lightly tested with SCTP over IPv6 on localhost.

show more ...

Add -X to restrict SCTP binding to a subset of interfaces.

Contains an alternate implementation of previously-submitted patches
to set the maximum segment size and no-delay options.

As a result of

Add -X to restrict SCTP binding to a subset of interfaces.

Contains an alternate implementation of previously-submitted patches
to set the maximum segment size and no-delay options.

As a result of this change, SCTP functionality on Linux will generally
require the libsctp library (on CentOS and similar distributions this
is provided by the lksctp-tools RPM).

Part of #131.

Submitted by: Bruce Simpson <[email protected]>

show more ...

Update license and copyright text to conform to LBNL standards.

Note that the license remains a 3-clause BSD license; the only
license changes were to add the name of the program and to add
some pun

Update license and copyright text to conform to LBNL standards.

Note that the license remains a 3-clause BSD license; the only
license changes were to add the name of the program and to add
some punctuation.

show more ...

Don't try to do IPV6_V6ONLY on OpenBSD either.

setsockopt(3) returns an error if passing 0 to this option (which
we do if no address family is specified when we bind to the wildcard
address, say by

Don't try to do IPV6_V6ONLY on OpenBSD either.

setsockopt(3) returns an error if passing 0 to this option (which
we do if no address family is specified when we bind to the wildcard
address, say by invoking "iperf3 -s" with no other options). This
is because OpenBSD explicitly does not support IPv4-mapped addresses,
so even though the IPV6_V6ONLY socket options exists, it only works
with a non-zero argument.

Fixes #196.

show more ...

Only do the IPV6_V6ONLY setsockopt(3) stuff if that option is available.

Should fix #177, in which compilation failed on older Solaris systems
that didn't have it. This is a different approach than

Only do the IPV6_V6ONLY setsockopt(3) stuff if that option is available.

Should fix #177, in which compilation failed on older Solaris systems
that didn't have it. This is a different approach than a patch
suggested in that issue.

Weakly regression-tested on other platforms (test this by specifying
-6, -4, or neither to the server when binding to the wildcard address,
and seeing if a client can connect with various of -6, -4, or neither).

show more ...

Fix breakage due to iperf.h depending on the autoconf config.h file but
not including it.

To fix this required us to change config.h to iperf_config.h (to
avoid potential filename collisions with th

Fix breakage due to iperf.h depending on the autoconf config.h file but
not including it.

To fix this required us to change config.h to iperf_config.h (to
avoid potential filename collisions with this generic name). Then
iperf.h could include this.

Adjust the existing header file inclusions to track this, and also
canonicalize their inclusion to be at the top of *.c files.

show more ...

Rework detection / enabling of SCTP support.

Rather than doing checks for platforms that we believe support SCTP,
instead look for an indication (notably the presence of <netinet/sctp.h>)
that it's

Rework detection / enabling of SCTP support.

Rather than doing checks for platforms that we believe support SCTP,
instead look for an indication (notably the presence of <netinet/sctp.h>)
that it's supported. This makes the conditionals for SCTP more obvious.
In addition, it opens up the possibility that SCTP might work on some
new OS that's not FreeBSD or Linux.

This change may force some additional build-time requirements on Linux,
such as lksctp-tools-devel on CentOS / Fedora or libsctp-dev on
Ubuntu.

Committing this first cut for review and to enable testing on multiple
platforms. So far this works correctly on Linux (SCTP support) and
MacOS (no SCTP support).

show more ...

Add SCTP support with the --sctp flag (Linux and FreeBSD only).

Note this option only has a long option flag; we're running out of
letters for short options.

Based heavily on a patch submitted in I

Add SCTP support with the --sctp flag (Linux and FreeBSD only).

Note this option only has a long option flag; we're running out of
letters for short options.

Based heavily on a patch submitted in Issue 131 (SCTP support for
iperf); I added support for FreeBSD and did some other packaging and
documentation improvements.

We probably shouldn't tie SCTP support to looking specifically for
Linux or FreeBSD; we probably leave support enabled all the time if
possible, possibly with some configure-time checks.

show more ...