bsdinstall partedit: Use snprintf instead of sprintf for error messages

When generating a message for a dialog box into a static buffer, use
snprintf instead of sprintf to avoid buffer overflows.

R

bsdinstall partedit: Use snprintf instead of sprintf for error messages

When generating a message for a dialog box into a static buffer, use
snprintf instead of sprintf to avoid buffer overflows.

Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D42240

(cherry picked from commit 6e8bf24073a1867c4b21bd84438a8b01ce91d82d)

show more ...

bsdinstall partedit: Use asprintf to build wrapper command for newfs

Don't abuse the message[] static buffer used elsewhere for error
messages to generate the command that actually newfs's each
file

bsdinstall partedit: Use asprintf to build wrapper command for newfs

Don't abuse the message[] static buffer used elsewhere for error
messages to generate the command that actually newfs's each
filesystem. Use asprintf to a more aptly-named 'char *command'
variable to construct the string instead. This avoids potential bugs
from truncation of the command string.

Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D42239

(cherry picked from commit a8676bf367b099dcc97ff61031cbf4ceb5e37899)

show more ...

bsdinstall partedit: Replace malloc + sprintf with asprintf

This avoids potential bugs with the length passed to malloc not
matching the string written via sprintf.

Reviewed by: emaste
Differential

bsdinstall partedit: Replace malloc + sprintf with asprintf

This avoids potential bugs with the length passed to malloc not
matching the string written via sprintf.

Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D42238

(cherry picked from commit 51749e05e96eb07134a38984a8c06608b20f07ea)

show more ...

bsdinstall partedit: Avoid potential buffer overflow in newfs_command

Allocate the buffer holding the newfs command string dynamically
(building the string via open_memstream) rather than storing th

bsdinstall partedit: Avoid potential buffer overflow in newfs_command

Allocate the buffer holding the newfs command string dynamically
(building the string via open_memstream) rather than storing the
command into a caller-supplied buffer of unknown length.

Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D42237

(cherry picked from commit ae2fc74fe76ca8b89c5ef0081ef3f4008f83de41)

show more ...

bsdinstall partedit: Apply changes from scripted installs

I got a check inverted in a previous cleanup commit and as a result
partedit was only applying GEOM changes (and generating an /etc/fstab)
i

bsdinstall partedit: Apply changes from scripted installs

I got a check inverted in a previous cleanup commit and as a result
partedit was only applying GEOM changes (and generating an /etc/fstab)
if it got an error reading the current GEOM mesh. Instead, it needed
to do those actions if it succeeded in reading the mesh.

The lack of /etc/fstab meant that bsdinstall mount didn't mount
anything in a scripted install.

PR: 273723
Reported by: Andrey Fesenko <[email protected]>
Reported by: Michal Nowak <[email protected]>
Reviewed by: cognet, brooks
Fixes: 230990991965 bsdinstall: Handle errors from geom_gettree.
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D42236

(cherry picked from commit 5307bbcc038f878b4b3714f03a2c824a0caeba4f)

show more ...