| 431d8b78 | 07-Dec-2023 |
Warner Losh <[email protected]> |
sort: Only build FreeBSD-specific ALTMON_x stuff when ATLMON_1 is defined
On MacOS, we bootstrap sort. Since ALTMON_* are not defined there, the build blows up. Since we don't need this feature for
sort: Only build FreeBSD-specific ALTMON_x stuff when ATLMON_1 is defined
On MacOS, we bootstrap sort. Since ALTMON_* are not defined there, the build blows up. Since we don't need this feature for the FreeBSD build process, and since we won't use it unless we actually install the NL files that have this data in it, just #ifdef it out for now. In the extremely unlikely event that the FreeBSD bootstrap/build process grows this dependency, we can evaluate the best solution then (which most likely is going to be not depend on the local's month names).
Fixes: 3d44dce90a69 (MacOS builds and github CI) Sponsored by: Netflix Reviewed by: jrtc27, [email protected], markj Differential Revision: https://reviews.freebsd.org/D42868
(cherry picked from commit bd234c0d4c8256db7e5a1fdda9ef311c9e0080e4)
show more ...
|
| 8b907136 | 13-Oct-2022 |
Baptiste Daroussin <[email protected]> |
sort: unify the code to read from FILE *
Previously the code to read from a local file or stdin was sperarated After the change to remove the home made line reader used for stdin (replaced by getdel
sort: unify the code to read from FILE *
Previously the code to read from a local file or stdin was sperarated After the change to remove the home made line reader used for stdin (replaced by getdelim) it apprears that the rest of the code which is used to read from any FILE * but stdin can benefit from the exact same change.
show more ...
|
| b58094c0 | 12-Oct-2022 |
Baptiste Daroussin <[email protected]> |
sort: replace home made line reader by getdelim(3)
The previous code had bug when reading lines with an unexpected encoding, returning without the full line being captured. This result in sort compl
sort: replace home made line reader by getdelim(3)
The previous code had bug when reading lines with an unexpected encoding, returning without the full line being captured. This result in sort complaining with "sort: Illegal byte sequence"
Using getdelim(3) instead of the home made code, fixes the situation.
PR: 241679 Reported by: Ronald F. Guilmette <[email protected]> MFC After: 1 week Reviewed by: markj, imp Differential Revision: https://reviews.freebsd.org/D36948
show more ...
|