ena: Upgrade ena-com to freebsd v2.8.0

Merge commit '0fd934a2fd12fa74ae409d3de1313e449be5d97e'

Approved by: cperciva (mentor)
Sponsored by: Amazon, Inc.

(cherry picked from commit f5f8d7c9cdf0341f

ena: Upgrade ena-com to freebsd v2.8.0

Merge commit '0fd934a2fd12fa74ae409d3de1313e449be5d97e'

Approved by: cperciva (mentor)
Sponsored by: Amazon, Inc.

(cherry picked from commit f5f8d7c9cdf0341f7c5fdb3a7c3358ec0ed67a0c)

show more ...

LinuxKPI based WiFi drivers: scripts to extract fwget(8) and port details

Add a "zzz_fw_ports_fwget.sh" script to each LinuxKPI based wireless
driver which in essential are all the same and in detai

LinuxKPI based WiFi drivers: scripts to extract fwget(8) and port details

Add a "zzz_fw_ports_fwget.sh" script to each LinuxKPI based wireless
driver which in essential are all the same and in detail all different.
They extract information for fwget(8), wifi-firmware-* ports, man pages
and for iwlwififw also for the wiki.

Sponsored by: The FreeBSD Foundation
Suggested by: imp (to have automation in D44918)

(cherry picked from commit 96190b4fef3b4a0cc3ca0606b0c4e3e69a5e6717)

show more ...

iwlwifi: FreeBSD specific sysctl export update

Update the sysctl export (also adding a mapping function) to also
print (1) for all lines the "flavor" (device_family) name and (2)
also print lines wh

iwlwifi: FreeBSD specific sysctl export update

Update the sysctl export (also adding a mapping function) to also
print (1) for all lines the "flavor" (device_family) name and (2)
also print lines where we only have the trans cfg and not iwl cfg
as with the flavor we can match PCI IDs to firmware package and so
we can have an increased number of matches.
A side effect is that we can also have fwget(8) PCI ID matches for
firmware (flavors) not yet (publicly) existing. That will allow
us to add them at a later point while a previous release already
supports the chipsets and knows how to get the firmware for them.

Sponsored by: The FreeBSD Foundation

(cherry picked from commit b4c8f251d65fa99601da000e586933a6df662839)

show more ...

ice_ddp: Update to 1.3.41.0

Primarily adds support for E830 devices, unlocking all of their
functionality.

As well, update the README and remove the non-FreeBSD sections
from it.

Signed-off-by: Er

ice_ddp: Update to 1.3.41.0

Primarily adds support for E830 devices, unlocking all of their
functionality.

As well, update the README and remove the non-FreeBSD sections
from it.

Signed-off-by: Eric Joyner <[email protected]>

Sponsored by: Intel Corporation

(cherry picked from commit f9a039060e834e89e0b2de1e8a442d78bd5c083d)

show more ...

Fix gcc uninitialized warning in FreeBSD zio_crypt.c

With gcc we are seeing the following -Werror warning:

In file included from /workspace/src/sys/contrib/openzfs/include/os/freebsd/spl/sys/su

Fix gcc uninitialized warning in FreeBSD zio_crypt.c

With gcc we are seeing the following -Werror warning:

In file included from /workspace/src/sys/contrib/openzfs/include/os/freebsd/spl/sys/sunddi.h:28,
from /workspace/src/sys/contrib/openzfs/include/sys/zfs_context.h:69:
In function 'zfs_uio_init',
inlined from 'zio_do_crypt_data' at /workspace/src/sys/contrib/openzfs/module/os/freebsd/zfs/zio_crypt.c:1690:2:
/workspace/src/sys/contrib/openzfs/include/os/freebsd/spl/sys/uio.h:102:45: error: 'puio_s.uio_offset' is used uninitialized [-Werror=uninitialized]
102 | zfs_uio_soffset(uio) = uio_s->uio_offset;
| ~~~~~^~~~~~~~~~~~
/workspace/src/sys/contrib/openzfs/module/os/freebsd/zfs/zio_crypt.c: In function 'zio_do_crypt_data':
/workspace/src/sys/contrib/openzfs/module/os/freebsd/zfs/zio_crypt.c:1683:20: note: 'puio_s' declared here
1683 | struct uio puio_s, cuio_s;
| ^~~~~~
In function 'zfs_uio_init',
inlined from 'zio_do_crypt_data' at /workspace/src/sys/contrib/openzfs/module/os/freebsd/zfs/zio_crypt.c:1691:2:
/workspace/src/sys/contrib/openzfs/include/os/freebsd/spl/sys/uio.h:102:45: error: 'cuio_s.uio_offset' is used uninitialized [-Werror=uninitialized]
102 | zfs_uio_soffset(uio) = uio_s->uio_offset;
| ~~~~~^~~~~~~~~~~~
/workspace/src/sys/contrib/openzfs/module/os/freebsd/zfs/zio_crypt.c: In function 'zio_do_crypt_data':
/workspace/src/sys/contrib/openzfs/module/os/freebsd/zfs/zio_crypt.c:1683:28: note: 'cuio_s' declared here
1683 | struct uio puio_s, cuio_s;
| ^~~~~~

Indeed, `zfs_uio_init()` does:

static __inline void
zfs_uio_init(zfs_uio_t *uio, struct uio *uio_s)
{
memset(uio, 0, sizeof (zfs_uio_t));
if (uio_s != NULL) {
GET_UIO_STRUCT(uio) = uio_s;
zfs_uio_soffset(uio) = uio_s->uio_offset;
}
}

while the code in `zio_crypt.c` has:

/*
* Primary encryption / decryption entrypoint for zio data.
*/
int
zio_do_crypt_data(boolean_t encrypt, zio_crypt_key_t *key,
dmu_object_type_t ot, boolean_t byteswap, uint8_t *salt, uint8_t *iv,
uint8_t *mac, uint_t datalen, uint8_t *plainbuf, uint8_t *cipherbuf,
boolean_t *no_crypt)
{
int ret;
boolean_t locked = B_FALSE;
uint64_t crypt = key->zk_crypt;
uint_t keydata_len = zio_crypt_table[crypt].ci_keylen;
uint_t enc_len, auth_len;
zfs_uio_t puio, cuio;
struct uio puio_s, cuio_s;
uint8_t enc_keydata[MASTER_KEY_MAX_LEN];
crypto_key_t tmp_ckey, *ckey = NULL;
freebsd_crypt_session_t *tmpl = NULL;
uint8_t *authbuf = NULL;

zfs_uio_init(&puio, &puio_s);
zfs_uio_init(&cuio, &cuio_s);
memset(GET_UIO_STRUCT(&puio), 0, sizeof (struct uio));
memset(GET_UIO_STRUCT(&cuio), 0, sizeof (struct uio));

So between the declaration of `puio_s` and `cuio_s`, there is no
initialization of these variables before `zfs_uio_init()` gets called.

Similar to the Linux variant of zio_crypt.c, I think it would be better
to memset the structs `puio_s` and `cuis_s` _before_ calling
`zfs_uio_init()`.

Reviewed by: tsoome
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D47281

(cherry picked from commit 3ceba58a7509418b47b8fca2d2b6bbf088714e26)

show more ...

rtw89fw: remove module build dirs and firmware

rtw89 firmware files were removed from main a year ago after core members
asked to not import more biinary blobs into main.
Also remove the module buil

rtw89fw: remove module build dirs and firmware

rtw89 firmware files were removed from main a year ago after core members
asked to not import more biinary blobs into main.
Also remove the module build framework for them on stable/14 to
avoid any confusion (it was never attached to the build).

People are asked to use fwget(8) to automatically install firmware
from ports according to the man page. A solution for the install
media is still pending.

X-MFC after: rtw89 only
Sponsored by: The FreeBSD Foundation

(cherry picked from commit cf94672363d6638b7268c05b4628b62bbfc8dbe5)
(cherry picked from commit 7ff12dd25ada486c4d33e854977514b2db690e7f)

show more ...

rtw89: add missing bsddriver.name assignments for two chipsets

On FreeBSDs we locally set bsddriver.name in struct pci_driver to have
the same name for all chipsets. This helps with, e.g., device
e

rtw89: add missing bsddriver.name assignments for two chipsets

On FreeBSDs we locally set bsddriver.name in struct pci_driver to have
the same name for all chipsets. This helps with, e.g., device
enumeration. For two chipsets the manual entry was missing.

Sponsored by: The FreeBSD Foundation

(cherry picked from commit ce15215befa1022d9a20ec15bdb0739dbe55f10f)

show more ...

mt76: add mt7615 to the pile of buildable drivers

Ignoring page_pools with the few needed adjustments and ignoring 7622
mt7615 seems to build as well. Add it so once we can connect it to
the build

mt76: add mt7615 to the pile of buildable drivers

Ignoring page_pools with the few needed adjustments and ignoring 7622
mt7615 seems to build as well. Add it so once we can connect it to
the build people can start testing and debugging.
(The actual work was done on a newer version of the mt76 drivers but
it seems the to-build-changes equally apply here already).

Requested by: Radu-Cristian Fotescu (freebsd-wireless, 2024-07-31)
Sponsored by: The FreeBSD Foundation

(cherry picked from commit 7728586800bd5bb4655cff6d661133ed10cc2ff7)

show more ...

vchiq(4): Stop checking for failures from malloc(M_WAITOK)

MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D45852

(cherry picked from commit 778ea7ed5a23db9c4f9d8dc43a5cea26ded

vchiq(4): Stop checking for failures from malloc(M_WAITOK)

MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D45852

(cherry picked from commit 778ea7ed5a23db9c4f9d8dc43a5cea26ded6231c)

show more ...

krping: Stop checking for failures from malloc(M_WAITOK)

MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D45852

(cherry picked from commit 66c35a6675ff987b52a2018871231658b1980

krping: Stop checking for failures from malloc(M_WAITOK)

MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D45852

(cherry picked from commit 66c35a6675ff987b52a2018871231658b1980a6c)

show more ...

MFC jail: unbreak the zfs.mount_snapshot option

The change of its description from integer to boolean didn't actually
change it to a boolean, but only made it impossible to set as either
a boolean o

MFC jail: unbreak the zfs.mount_snapshot option

The change of its description from integer to boolean didn't actually
change it to a boolean, but only made it impossible to set as either
a boolean or an integer.

Rather than make it work as a boolean parameter should, just revert
to the old (working) integer parameter, and change the documentation
to match.

PR: 274263
Reported by: andrew.hotlab at hotmail

(cherry picked from commit ae1a0648b05acf798816e7b83b3c10856de5c8e5)

show more ...

zfs: cherry-pick change from openzfs

Vendor PR:
#16210 FreeBSD: Add const qualifier to members of struct
opensolaris_utsname

Obtained from: OpenZFS
OpenZFS commit: e2357561b9499296bff758

zfs: cherry-pick change from openzfs

Vendor PR:
#16210 FreeBSD: Add const qualifier to members of struct
opensolaris_utsname

Obtained from: OpenZFS
OpenZFS commit: e2357561b9499296bff758afe4868dbc39735675

Note: this is required by the following up MFC [1]. No functional change.

1. 356be1348dac kernel: Make some compile time constant variables const

show more ...

libnv: correct the calculation of the structure's size

Reported by: Milosz Kaniewski <[email protected]>

(cherry picked from commit 7f4731ab67f1d3345aee6626eb83cc5ce00010f0)

zfs: fix build without MAC

(cherry picked from commit b458ddf27fd87afa57575cdad68f6b4183916666)

zfs: merge openzfs/zfs@33174af15 (zfs-2.2-release) into stable/14

OpenZFS release 2.2.6

Notable upstream pull request merges:
#15557 bce36e21c module/icp/asm-arm/sha2: auto detect __ARM_ARCH
#156

zfs: merge openzfs/zfs@33174af15 (zfs-2.2-release) into stable/14

OpenZFS release 2.2.6

Notable upstream pull request merges:
#15557 bce36e21c module/icp/asm-arm/sha2: auto detect __ARM_ARCH
#15623 2ca151537 module/icp/asm-arm/sha2: enable non-SIMD asm kernels on
armv5/6
#16308 ac6500389 zfs: add bounds checking to zil_parse
#16316 859f906a4 Fix null ptr deref when renaming a zvol with snaps and
snapdev=visible
#16343 cd42e992b Enable L2 cache of all (MRU+MFU) metadata but MFU data
only
#16382 3a36797ad FreeBSD: Fix RLIMIT_FSIZE handling for block cloning

Obtained from: OpenZFS
OpenZFS commit: 33174af15112ed5c53299da2d28e763b0163f428
OpenZFS tag: zfs-2.2.6

show more ...

libnv: verify that string is null terminated

During unpacking, we ensure that we do not read beyond the
declared size. However, unpack uses a function that copies
null-terminated strings. Prior to t

libnv: verify that string is null terminated

During unpacking, we ensure that we do not read beyond the
declared size. However, unpack uses a function that copies
null-terminated strings. Prior to this commit, if the last string
was not null-terminated, it could result in copying data into a
buffer smaller than the allocated size.

Security: FreeBSD-24:09.libnv
Security: CVE-2024-45288
Security: CAP-03
Reported by: Synacktiv
Sponsored by: The Alpha-Omega Project
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D46138

(cherry picked from commit 3aaaca1b51ad844ef9e9b3d945217ab3dd189bae)

show more ...

libnv: allocate buffer in a safe way

Ensure that the calculation of size of array doesn't
overflow.

Security: FreeBSD-24:09.libnv
Security: CVE-2024-45287
Security: CAP-02
Reported by: Synacktiv
Re

libnv: allocate buffer in a safe way

Ensure that the calculation of size of array doesn't
overflow.

Security: FreeBSD-24:09.libnv
Security: CVE-2024-45287
Security: CAP-02
Reported by: Synacktiv
Reported by: Taylor R Campbell (NetBSD)
Sponsored by: The Alpha-Omega Project
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D46131

(cherry picked from commit 36fa90dbde0060aacb5677d0b113ee168e839071)

show more ...

zdb: Fix printf formatting of a uint64_t

This fixes the build on 32-bit platforms.

Fixes: dc91e7452482 ("zdb: dump ZAP_FLAG_UINT64_KEY ZAPs properly (#16334)")
(cherry picked from commit f029f62779

zdb: Fix printf formatting of a uint64_t

This fixes the build on 32-bit platforms.

Fixes: dc91e7452482 ("zdb: dump ZAP_FLAG_UINT64_KEY ZAPs properly (#16334)")
(cherry picked from commit f029f6277996760be4be42148295231af425cc2d)

show more ...

Fix enum warnings in ath_hal's ar9300

This fixes a number of clang 19 warnings:

sys/contrib/dev/ath/ath_hal/ar9300/ar9300_eeprom.c:709:25: error: comparison of different enumeration types ('HAL

Fix enum warnings in ath_hal's ar9300

This fixes a number of clang 19 warnings:

sys/contrib/dev/ath/ath_hal/ar9300/ar9300_eeprom.c:709:25: error: comparison of different enumeration types ('HAL_BOOL' and 'HAL_FREQ_BAND') [-Werror,-Wenum-compare]
709 | freq_array[i] = FBIN2FREQ(p_freq_bin[i], is_2ghz);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sys/contrib/dev/ath/ath_hal/ar9300/ar9300eep.h:148:11: note: expanded from macro 'FBIN2FREQ'
148 | (((y) == HAL_FREQ_BAND_2GHZ) ? (2300 + x) : (4800 + 5 * x))
| ~~~ ^ ~~~~~~~~~~~~~~~~~~
sys/contrib/dev/ath/ath_hal/ar9300/ar9300_eeprom.c:745:25: error: comparison of different enumeration types ('HAL_BOOL' and 'HAL_FREQ_BAND') [-Werror,-Wenum-compare]
745 | freq_array[i] = FBIN2FREQ(p_freq_bin[i], is_2ghz);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sys/contrib/dev/ath/ath_hal/ar9300/ar9300eep.h:148:11: note: expanded from macro 'FBIN2FREQ'
148 | (((y) == HAL_FREQ_BAND_2GHZ) ? (2300 + x) : (4800 + 5 * x))
| ~~~ ^ ~~~~~~~~~~~~~~~~~~
sys/contrib/dev/ath/ath_hal/ar9300/ar9300_eeprom.c:781:25: error: comparison of different enumeration types ('HAL_BOOL' and 'HAL_FREQ_BAND') [-Werror,-Wenum-compare]
781 | freq_array[i] = FBIN2FREQ(p_freq_bin[i], is_2ghz);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sys/contrib/dev/ath/ath_hal/ar9300/ar9300eep.h:148:11: note: expanded from macro 'FBIN2FREQ'
148 | (((y) == HAL_FREQ_BAND_2GHZ) ? (2300 + x) : (4800 + 5 * x))
| ~~~ ^ ~~~~~~~~~~~~~~~~~~

The `FBIN2FREQ()` and `FREQ2FBIN()` macros in `ar9300eep.h` are invoked
in most places around the `ath_hal` code with a (effectively) boolean
second argument, corresponding to "is this 2GHz?". But in the code that
is warned about, the value `HAL_FREQ_BAND_2GHZ` is of a different
non-boolean type, `HAL_FREQ_BAND`.

Update the `FBIN2FREQ()` and `FREQ2FBIN()` macros to interpret the
second argument as boolean value, and rename the macro parameter names
to better describe their meaning.

Reviewed by: adrian, bz
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D46201

(cherry picked from commit 82246ac5d890e031c9978052e5a431e0960182d5)

show more ...

zfs: merge openzfs/zfs@33174af15 (zfs-2.2-release) into stable/14

OpenZFS release 2.2.5

Notable upstream pull request merges:
#15609 566841171 Only provide execvpe(3) when needed
#15940 9edf6af4a

zfs: merge openzfs/zfs@33174af15 (zfs-2.2-release) into stable/14

OpenZFS release 2.2.5

Notable upstream pull request merges:
#15609 566841171 Only provide execvpe(3) when needed
#15940 9edf6af4a Replace P2ALIGN with P2ALIGN_TYPED and delete P2ALIGN
#16038 0f1e8ba2f L2ARC: Cleanup buffer re-compression
#16104 b474dfad0 Refactor dbuf_read() for safer decryption
#16118 938d1588e Make more taskq parameters writable
#16131 672474659 Slightly improve dnode hash
#16138 4c0fbd8d6 FreeBSD: Add zfs_link_create() error handling
#16159 fa4b1a404 ZAP: Fix leaf references on zap_expand_leaf() errors
#16162 41f2a9c81 Fix scn_queue races on very old pools
#16165 4c484d66b Fix ZIL clone records for legacy holes
#16206 27cc6df76 Use memset to zero stack allocations containing unions
#16207 2eab4f7b3 Fix assertion in Persistent L2ARC
#16214 13ccbbb47 Some improvements to metaslabs eviction
#16216 ba3c7692c Destroy ARC buffer in case of fill error
#16258 4d2f7f983 vdev_open: clear async fault flag after reopen
#16264 ef08cb26d Fix long_free_dirty accounting for small files
#16273 54ef0fdf6 head_errlog: fix use-after-free
#16284 14cce09a6 FreeBSD: Use a statement expression to implement
SET_ERROR()
#16406 6f27c4cad Make 'rmmod zfs' work after zfs-2.2.4

Obtained from: OpenZFS
OpenZFS commit: 33174af15112ed5c53299da2d28e763b0163f428
OpenZFS tag: zfs-2.2.5

show more ...