libsa: Remove redundant sys/cdefs.h

Sponsored by: Netflix

(cherry picked from commit 3e15b01d6914c927e37d1699645783acf286655c)

loader: return errors from writing ZFS labels

vdev_write_bootenv_impl can only return success. Instead, return the
last error. This will make any write errors more visible. The old code
masked kboo

loader: return errors from writing ZFS labels

vdev_write_bootenv_impl can only return success. Instead, return the
last error. This will make any write errors more visible. The old code
masked kboot's inability to write bootenv.

Sponsored by: Netflix
Differential Revision: https://reviews.freebsd.org/D44018

and

loader/zfs: Fix to actually return the last error

The last fix, to try to return the last error, really returns the first
return code after the last error, which could be zero. Instead, return
the last error. Also, change rc to err to make it visually distinct from
rv, which is the cause of my error in e54bb0ad8058.

Reported by: Bill Sommerfeld <[email protected]>
Fixes: e54bb0ad8058
Sponsored by: Netflix

(cherry picked from commit e54bb0ad8058c0f84ceb08b49bb1d22af829a9e8)
(cherry picked from commit 525e6d6c890f6aee898ac70347e5bb49da6638a1)

show more ...

stand: Automated cleanup of cdefs and other formatting

Apply the following automated changes to try to eliminate
no-longer-needed sys/cdefs.h includes as well as now-empty
blank lines in a row.

Rem

stand: Automated cleanup of cdefs and other formatting

Apply the following automated changes to try to eliminate
no-longer-needed sys/cdefs.h includes as well as now-empty
blank lines in a row.

Remove /^#if.*\n#endif.*\n#include\s+<sys/cdefs.h>.*\n/
Remove /\n+#include\s+<sys/cdefs.h>.*\n+#if.*\n#endif.*\n+/
Remove /\n+#if.*\n#endif.*\n+/
Remove /^#if.*\n#endif.*\n/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/types.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/param.h>/
Remove /\n+#include\s+<sys/cdefs.h>\n#include\s+<sys/capsicum.h>/

Sponsored by: Netflix

(cherry picked from commit 7c43148a974877188a930e4078a164f83da8e652)

show more ...

loader: we can only env_discard() existing variable

While dropping nvpair from nvstore, we also remove the corresponding
environment variable. By doing so, we should be careful not to try
to unset n

loader: we can only env_discard() existing variable

While dropping nvpair from nvstore, we also remove the corresponding
environment variable. By doing so, we should be careful not to try
to unset non-existing variable.

Reviewed by: imp
MFC after: 2 week
Differential revision: https://reviews.freebsd.org/D44083

(cherry picked from commit 1b3f4ccb7dd8600d010fc6a09b09ee7d74872809)

show more ...