Remove $FreeBSD$: one-line .c pattern

Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/

bootpd: Use C89 function definitions.

Trim a few duplicate (but incomplete) function prototypes as well.

Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D39520

bootp: remove the USE_BFUNCS knob

We'd likely be better served by converting these to the equivalent mem*
calls, but just kill the knob for now. The b* macros being defined get
in the way of _FORTIF

bootp: remove the USE_BFUNCS knob

We'd likely be better served by converting these to the equivalent mem*
calls, but just kill the knob for now. The b* macros being defined get
in the way of _FORTIFY_SOURCE.

Reviewed by: imp, markj
Differential Revision: https://reviews.freebsd.org/D32235

show more ...

Correctly align usage: output

Marginally improve usage() message style in bootpd.

- Remove an extra space after "usage:".
- Avoid lines exceeding 80 columns.

Based on notes from rgrimes.

MFC with: r348066
Event: Waterloo Hack

Marginally improve usage() message style in bootpd.

- Remove an extra space after "usage:".
- Avoid lines exceeding 80 columns.

Based on notes from rgrimes.

MFC with: r348066
Event: Waterloo Hackathon 2019

show more ...

bootpd: Add an option to skip modifications to the ARP table.

PR: 30854
Submitted by: Dan Lukes <[email protected]>
Reviewed by: imp (previous version)
MFC after: 1 week
Event: Waterloo Hackathon 2019

bootpd: Add an option to skip modifications to the ARP table.

PR: 30854
Submitted by: Dan Lukes <[email protected]>
Reviewed by: imp (previous version)
MFC after: 1 week
Event: Waterloo Hackathon 2019
Differential Revision: https://reviews.freebsd.org/D2581

show more ...

bootpd: validate hardware type

Due to insufficient validation of network-provided data it may have been
possible for a malicious actor to craft a bootp packet which could cause
a stack buffer overfl

bootpd: validate hardware type

Due to insufficient validation of network-provided data it may have been
possible for a malicious actor to craft a bootp packet which could cause
a stack buffer overflow.

admbugs: 850
Reported by: Reno Robert
Reviewed by: markj
Approved by: so
Security: FreeBSD-SA-18:15.bootpd
Sponsored by: The FreeBSD Foundation

show more ...

Spelling fixes for libexec/

Make tv_sec a time_t on all platforms but alpha. Brings us more in line with
POSIX. This also makes the struct correct we ever implement an i386-time64
architecture. Not that we need too.

Reviewe

Make tv_sec a time_t on all platforms but alpha. Brings us more in line with
POSIX. This also makes the struct correct we ever implement an i386-time64
architecture. Not that we need too.

Reviewed by: imp, brooks
Approved by: njl (acpica), des (no objects, touches procfs)
Tested with: make universe

show more ...

Fix most cases where the address of an int is passed to a function expecting a
socklen_t * argument.

Add the '-h hostname' to usage(), too.
While I'm here, sync the usage() synopsis with the manual page synopsis:
make the [-i | -s] explicit and sort the options alphabetically.

Reminded by: ru
MFC

Add the '-h hostname' to usage(), too.
While I'm here, sync the usage() synopsis with the manual page synopsis:
make the [-i | -s] explicit and sort the options alphabetically.

Reminded by: ru
MFC after: 3 days

show more ...

fix a couple typos in the comments

From NetBSD's bootpd (in src/usr.sbin/bootp)

fix bootpd to use fd_set. For some reason on Sparc, using int with
select is broken.

Add FBSDID. udp/bootps -> bootps/udp. Use err(3).

This code defined a private __P, nuke it.

Assume __STDC__, remove non-__STDC__ code.

Reviewed by: md5

Mark report() as printflike and fix resulting warnings, including one bug
(get_errmsg -> get_errmsg())

RFC2132 is not clear about whether the "Maximum DHCP Message Size"
refers to the size of the whole ethernet packet, just the DHCP
message within the UDP payload, or something else. bootpd interpreted

RFC2132 is not clear about whether the "Maximum DHCP Message Size"
refers to the size of the whole ethernet packet, just the DHCP
message within the UDP payload, or something else. bootpd interpreted
it as a maximum UDP payload size, so it could end up sending
fragmented packets to clients (such as some versions of Etherboot)
that used different interpretations of the maximum message size.

Switch to the most conservative interpretation: ensure that the
ethernet packet containing the response is no larger than the
specified maximum message size. This matches the behaviour of
the ISC dhcpd.

MFC after: 1 week

show more ...

Add `_PATH_DEVZERO'.
Use _PATH_* where where possible.

$Id$ -> $FreeBSD$

More egcs warning fixes:
o main returns int not void
o use return 0 at end of main when needed
o use braces to avoid potentially ambiguous else
o don't default to type int (and also remove a usel

More egcs warning fixes:
o main returns int not void
o use return 0 at end of main when needed
o use braces to avoid potentially ambiguous else
o don't default to type int (and also remove a useless register
modifier).

Reviewed by: obrien and chuckr

show more ...

Ensure that things returned by gethostname() and
friends are terminated and allow for a maximum
host name length of MAXHOSTNAMELEN - 1.
Put parenthesis around sizeof args.
Make some variables static.

Ensure that things returned by gethostname() and
friends are terminated and allow for a maximum
host name length of MAXHOSTNAMELEN - 1.
Put parenthesis around sizeof args.
Make some variables static.
Fix telnetd -u (broken by my last commit)

Prompted by: bde

show more ...

Block for buffer overflow.

PR: bin/9031

Changed unbounded strcpy() to snprintf() to fix buffer overrun exploit

Use gethostname(3) to obtain the local host name, as opposed to uname(3).
Otherwise the length of the name is limited to 32 characters only.