iscsid: set max_recv_data_segment_length to what we advertisePreviously we updated the conection's conn_max_recv_data_segment_lengthonly when we received a response containing MaxRecvDataSegmentLe
iscsid: set max_recv_data_segment_length to what we advertisePreviously we updated the conection's conn_max_recv_data_segment_lengthonly when we received a response containing MaxRecvDataSegmentLengthfrom the target. If the target did not send MaxRecvDataSegmentLengththen we left conn_max_recv_data_segment_length at the default (i.e.,8192). A target could then send more data than that defult (up to ouradvertised maximum), and we would drop the connection.RFC 7143 specifies that MaxRecvDataSegmentLength is Declarative, notnegotiated. Just set conn_max_recv_data_segment_length to ouradvertised value in login_negotiate().PR: 259355Reviewed by: mavMFC after: 1 weekFixes: a15fbc904a4d ("Alike to r312190 decouple iSCSI...")Sponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.freebsd.org/D32605(cherry picked from commit fc79cf4fea7221fa62d480648f05e30f7df73f92)
show more ...
iscsid: Disable TCP DDP for connection sockets.cxgbei is not able to offload PDU processing for a socket using TCPDDP offload.Sponsored by: Chelsio Communications(cherry picked from commit 91c
iscsid: Disable TCP DDP for connection sockets.cxgbei is not able to offload PDU processing for a socket using TCPDDP offload.Sponsored by: Chelsio Communications(cherry picked from commit 91c62d626d0e9995da9dc424120a4f1b0b987eea)
iscsid(8): fix memory leak by freeing the 'addr'Reviewed By: mavSponsored by: NetApp, Inc.Sponsored by: Klara, Inc.Differential Revision: https://reviews.freebsd.org/D27328
iscsid(8): free data allocated by getaddrinfo(3)Reviewed By: mavSponsored by: NetApp, Inc.Sponsored by: Klara, Inc.Differential Revision: https://reviews.freebsd.org/D27329
Drop "All rights reserved" from all my stuff. This includesFoundation copyrights, approved by emaste@. It does not includefiles which carry other people's copyrights; if you're oneof those peopl
Drop "All rights reserved" from all my stuff. This includesFoundation copyrights, approved by emaste@. It does not includefiles which carry other people's copyrights; if you're oneof those people, feel free to make similar change.Reviewed by: emaste, imp, gbe (manpages)Differential Revision: https://reviews.freebsd.org/D26980
Add network QoS support for PCP to iscsi initiator.Make the Ethernet PCP codepoint configurablefor L2 local traffic, to allow lower latency foriSCSI block IO. This addresses the initiatorside on
Add network QoS support for PCP to iscsi initiator.Make the Ethernet PCP codepoint configurablefor L2 local traffic, to allow lower latency foriSCSI block IO. This addresses the initiatorside only.Reviewed by: mav, trasz, bcrSponsored by: NetApp, Inc.Differential Revision: https://reviews.freebsd.org/D26739
Negotiate iSCSIProtocolLevel of 2 (RFC 7144) in initiator.It does not change anything immediately, but allows further support ofCommand Priority, Status Qualifier and new task management functions
Negotiate iSCSIProtocolLevel of 2 (RFC 7144) in initiator.It does not change anything immediately, but allows further support ofCommand Priority, Status Qualifier and new task management functions.MFC after: 1 monthSponsored by: iXsystems, Inc.
Add DSCP support for network QoS to iscsi initiator.Allow the DSCP codepoint also to be configurablefor the traffic in the direction from the initiatorto the target, such that writes and any requ
Add DSCP support for network QoS to iscsi initiator.Allow the DSCP codepoint also to be configurablefor the traffic in the direction from the initiatorto the target, such that writes and any requestsare also treated in the appropriate QoS class.Reviewed by: mavMFC after: 2 weeksSponsored by: NetApp, Inc.Differential Revision: https://reviews.freebsd.org/D26714
Fix string overflow that could occur during redirection due to passingthe wrong length to strlcpy(3). It looks like it could overflow intothe next field, isc_user, which is properly long to accomod
Fix string overflow that could occur during redirection due to passingthe wrong length to strlcpy(3). It looks like it could overflow intothe next field, isc_user, which is properly long to accomodate for it;I don't think it could cause any harm other than breaking the connection.Reviewed by: mavMFC after: 2 weeksSponsored by: NetApp, Inc.Sponsored by: Klara, Inc.Differential Revision: https://reviews.freebsd.org/D26247
Stop hardcoding WARNS in iscsid(8).MFC after: 2 weeksSponsored by: DARPA
iscsi: simplify the capsicumizationApproved by: traszDifferential Revision: https://reviews.freebsd.org/D17962
Add missing SPDX identifier in iscsid(8).MFC after: 2 weeks
various: general adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - error
various: general adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - errorprone - task.The Software Package Data Exchange (SPDX) group provides a specificationto make it easier for automated tools to detect and summarize well knownopensource licenses. We are gradually adopting the specification, notingthat the tags are considered only advisory and do not, in any way,superceed or replace the license texts.No functional change intended.
DIRDEPS_BUILD: Update dependencies.Sponsored by: Dell EMC Isilon
Minor tweaks to iscsi(4) and iscsid(8).MFC after: 2 weeks
Use nitems() from sys/param.h.MFC after: 3 weeks.
usr.sbin: normalize paths using SRCTOP-relative paths or :H when possibleThis simplifies make logic/outputMFC after: 1 monthSponsored by: Dell EMC Isilon
Remove ISCSI_MAX_DATA_SEGMENT_LENGTH, using negotiated value.MFC after: 2 weeks
Alike to r312190 decouple iSCSI connection limits from defaults.Connection parameters should remain at defaults until negotiated.While there, remove sythetic limits, applied if kernel provided no
Alike to r312190 decouple iSCSI connection limits from defaults.Connection parameters should remain at defaults until negotiated.While there, remove sythetic limits, applied if kernel provided none.iscsid has no own limitations, no configuration and no any idea whatvalues are good. Assume kernel knows what it requests.
Make the iSCSI parameter negotiation more flexible.Decouple the send and receive limits on the amount of data in a singleiSCSI PDU. MaxRecvDataSegmentLength is declarative, not negotiated, andis
Make the iSCSI parameter negotiation more flexible.Decouple the send and receive limits on the amount of data in a singleiSCSI PDU. MaxRecvDataSegmentLength is declarative, not negotiated, andis direction-specific so there is no reason for both ends to limitthemselves to the same min(initiator, target) value in both directions.Allow iSCSI drivers to report their send, receive, first burst, and maxburst limits explicitly instead of using hardcoded values or trying toderive all of them from the receive limit (which was the only limitreported by the drivers prior to this change).Display the send and receive limits separately in the userspace iSCSIutilities.Reviewed by: jpaetzel@ (earlier version), trasz@Sponsored by: Chelsio CommunicationsDifferential Revision: https://reviews.freebsd.org/D7279
Fix calloc(3) argument order.Reviewed by: traszMFC after: 4 weeks.Differential Revision: https://reviews.freebsd.org/D7532
Decouple MaxBurstLength and FirstBurstLength from MaxRecvDataSegmentLengthreported by the ICL module in iscsid(8). This harmed performance and wasjust wrong.MFC after: 1 month
Build iscsid(8) with ICL_KERNEL_PROXY defined by default, as requiredfor iSER.Obtained from: Mellanox TechnologiesMFC after: 1 monthSponsored by: The FreeBSD Foundation
When iscsid(8) is running in ICL proxy mode, don't try to send Logout PDUs.The kernel already does this for us when we ask it to terminate the session.MFC after: 1 monthSponsored by: The FreeBSD
When iscsid(8) is running in ICL proxy mode, don't try to send Logout PDUs.The kernel already does this for us when we ask it to terminate the session.MFC after: 1 monthSponsored by: The FreeBSD Foundation
Add initial support for negotiating iSER parameters to iscsid(8). Somerework might be needed to support asymetrical limits, but this should beok for now.Obtained from: Mellanox Technologies (ear
Add initial support for negotiating iSER parameters to iscsid(8). Somerework might be needed to support asymetrical limits, but this should beok for now.Obtained from: Mellanox Technologies (earlier version)MFC after: 1 monthSponsored by: The FreeBSD Foundation
123