binmiscctl: Avoid segfault with "binmiscctl add" and no extra params(cherry picked from commit c7fcb36f5670b1d6c1f80c3c29d9d2ba374807f7)
binmiscctl(8): miscellaneous cleanup- Bad whitespace in Makefile.- Reordered headers, sys/ first.- Annotated fatal/usage __dead2 to help `make analyze` out a little bit.- Spell a couple of sizeo
binmiscctl(8): miscellaneous cleanup- Bad whitespace in Makefile.- Reordered headers, sys/ first.- Annotated fatal/usage __dead2 to help `make analyze` out a little bit.- Spell a couple of sizeof constructs as "nitems" and "howmany" instead.MFC after: 1 week
show more ...
Add RISC-V interpreter exampleNow that RISC-V support has landed in qemu-user-static, add to the listof examples in the binmiscctl(8) manpage.Reviewed by: kevansMFC after: 3 daysDifferential R
Add RISC-V interpreter exampleNow that RISC-V support has landed in qemu-user-static, add to the listof examples in the binmiscctl(8) manpage.Reviewed by: kevansMFC after: 3 daysDifferential Revision: https://reviews.freebsd.org/D24646
Remove sparc64 example.Reivewed by: cy@, bcr@Differential Revision: https://reviews.freebsd.org/D23593
Improve the binmiscctl manual page- Use "Fl -" instead of "Cm --" for long options.- Sort options alphabetically.- Pet "mandoc -Tlint".- Clean up the description of the "--interpreter" option.-
Improve the binmiscctl manual page- Use "Fl -" instead of "Cm --" for long options.- Sort options alphabetically.- Pet "mandoc -Tlint".- Clean up the description of the "--interpreter" option.- Clean up the description of the first example in the examples section.- Use ".Bd -literal -offset indent" for all example code blocks for consistency.- Use "Nm" instead of "Cm binmiscctl".- Indent all examples for consistency.Reviewed by: allanjudeApproved by: mat (mentor)Differential Revision: https://reviews.freebsd.org/D15589
Don't leak resources on duplicate -m or -M arguments. Last one wins.CID: 1204385, 1204384
DIRDEPS_BUILD: Update dependencies.Sponsored by: Dell EMC Isilon
Correct the binmiscctl(8) man page for powerpc64Magic for powerpc64 erroneously specified ELFCLASS32 instead of ELFCLASS64.Submitted by: luca.pizzamiglio _AT_ gmail DOT comMFC after: 3 days
binmiscctl should use modfind instead of kldfindkldfind() only matches kernel modules, so if you link imgact_binmisc directlyinto the kernel, binmiscctl can't find it, tries to load it, and errors
binmiscctl should use modfind instead of kldfindkldfind() only matches kernel modules, so if you link imgact_binmisc directlyinto the kernel, binmiscctl can't find it, tries to load it, and errorsout with: Can't load imgact_binmisc kernel module: File existsA quick search of other base commands shows that the correct procedure is tocall modfind(), and then try kldload() if that fails.PR: 218593Submitted by: Dan Nelson <[email protected]>MFC after: 1 week
Another attempt at resolving CID 1305629. The test of cmd == -1may make Coverity think that other negative values of cmd (usedas an index) are possible. Testing < 0 is a more common idiomin any
Another attempt at resolving CID 1305629. The test of cmd == -1may make Coverity think that other negative values of cmd (usedas an index) are possible. Testing < 0 is a more common idiomin any case.Reported by: CoverityCID: 1305629
Revert r299584: Mark usage() as __dead2 so that Coverity doesn't think that execution continues after the call and uses a negative array subscript.Requested by: bde
Mark usage() as __dead2 so that Coverity doesn't think that executioncontinues after the call and uses a negative array subscript.Reported by: CoverityCID: 1305629
META MODE: Update dependencies with 'the-lot' and add missing directories.This is not properly respecting WITHOUT or ARCH dependencies in target/.Doing so requires a massive effort to rework targe
META MODE: Update dependencies with 'the-lot' and add missing directories.This is not properly respecting WITHOUT or ARCH dependencies in target/.Doing so requires a massive effort to rework targets/ to do so. Abetter approach will be to either include the SUBDIR Makefiles directlyand map to DIRDEPS or just dynamically lookup the SUBDIR. These losethe benefit of having a userland/lib, userland/libexec, etc, though andresults in a massive package. The current implementation of targets/ isvery unmaintainable.Currently rescue/rescue and sys/modules are still not connected.Sponsored by: EMC / Isilon Storage Division
Add example for upcoming aarch64/arm64 targets.
If no arguments are passed to a subcommand that requires arguments,error out before we deref a null pointer in the check for max length.Thanks to otis in IRC for the bug report.MFC after: 3 days
Check for invalid length or more than max length for the interpreter, insteadof the validity of the string pointer holding the interpreter.Submitted by: ssonReviewed by: dimMFC after: 3 days
Move the explanation for examples before the example itself. Addnumerous QEMU examples and explanations supplied by sbruno, with thanksto Ingo Schwarze for help with the mdoc markup. Code, text,
Move the explanation for examples before the example itself. Addnumerous QEMU examples and explanations supplied by sbruno, with thanksto Ingo Schwarze for help with the mdoc markup. Code, text, testing,proofreading, cinematography, stunts, and the haunting theme songsupplied by sbruno.Submitted by: sbrunoReviewed by: sbrunoMFC after: 1 week
mdoc: kill EOL whitespace.
mdoc: use display block in the beginning of the EXAMPLES section.
More mdoc/spelling/grammar cleanup.
Quick mdoc/whitespace/spelling pass, this needs some more work.
Add Stacey Son's binary activation patches that allow remapping ofexecution to a emumation program via parsing of ELF header information.With this kernel module and userland tool, poudriere is abl
Add Stacey Son's binary activation patches that allow remapping ofexecution to a emumation program via parsing of ELF header information.With this kernel module and userland tool, poudriere is able to buildports packages via the QEMU userland tools (or another emulator program)in a different architecture chroot, e.g. TARGET=mips TARGET_ARCH=mipsI'm not connecting this to GENERIC for obvious reasons, but this shouldallow the kernel module to be built by default and enable the buildingof the userland tool (which automatically loads the kernel module).Submitted by: sson@Reviewed by: jhb@