sed: fix hex_subst test after after r363679r363679 is in-fact the future change referenced by the comment, helpfullyleft and forgotten by kevans. Instead of just silently not matching, weshould n
sed: fix hex_subst test after after r363679r363679 is in-fact the future change referenced by the comment, helpfullyleft and forgotten by kevans. Instead of just silently not matching, weshould now be erroring out with vigor.
show more ...
sed: treat '[' as ordinary character in 'y' command'y' does not handle bracket expressions, treat '[' as ordinary characterand do not apply bracket expression checks (GNU sed agrees).PR: 247931
sed: treat '[' as ordinary character in 'y' command'y' does not handle bracket expressions, treat '[' as ordinary characterand do not apply bracket expression checks (GNU sed agrees).PR: 247931Reviewed by: pfg, kevansTested by: antoine (exp-run), Quentin L'Hours <[email protected]>Differential Revision: https://reviews.freebsd.org/D25640
sed/multi_test: print comment for current test, not next oneThis is visible when e.g. 8.20 is failing:not ok 96 8.20 # \ in y command8.20's comment should be '[ as an s delimiter and its escape
sed/multi_test: print comment for current test, not next oneThis is visible when e.g. 8.20 is failing:not ok 96 8.20 # \ in y command8.20's comment should be '[ as an s delimiter and its escapes'.
Remove some more duplicate test cases I accidentally committedReported by: markj, yuripvMFC after: 2 weeksX-MFC-With: 362017
Remove duplicate lines from sed testsReported by: yuripvApproved by: pfg (src)MFC after: 2 weeksX-MFC-With: 362017
Read commands from stdin when -f - is passed to sed(1)This patch teaches sed to interpret a "-" in a special way when givenas an argument to the -f flag.This behavior is also present in GNU sed.
Read commands from stdin when -f - is passed to sed(1)This patch teaches sed to interpret a "-" in a special way when givenas an argument to the -f flag.This behavior is also present in GNU sed.PR: 244872Tested by: antoine (exp-run)Reviewed by: pfg, tobik (older version)Approved by: pfg (src)Relnotes: yesMFC after: 2 weeksDifferential Revision: https://reviews.freebsd.org/D24079
sed: attempt to learn about hex escapes (e.g. \x27)Somewhat predictably, software often wants to use \x27/\x24 among others sothat they can decline worrying about ugly escaping, if said escaping i
sed: attempt to learn about hex escapes (e.g. \x27)Somewhat predictably, software often wants to use \x27/\x24 among others sothat they can decline worrying about ugly escaping, if said escaping is evenpossible. Right now, this software is using these and getting the wrongresults, as we'll interpret those as x27 and x24 respectively. Some examplesof this, when an exp-run was ran, were science/octopus and misc/vifm.Go ahead and process these at all times. We allow either one or two digits,and the tests account for both. If extra digits are specified, e.g. \x2727,then the third and fourth digits are interpreted literally as one mightexpect.PR: 229925MFC after: 2 weeks
sed: process \r, \n, and \tThis is both reasonable and a common GNUism that a lot of ported softwareexpects.Universally process \r, \n, and \t into carriage return, newline, and tabrespectively
sed: process \r, \n, and \tThis is both reasonable and a common GNUism that a lot of ported softwareexpects.Universally process \r, \n, and \t into carriage return, newline, and tabrespectively. Newline still doesn't function in contexts where it can't(e.g. BRE), but we process it anyways rather than passingUB \n (escaped ordinary) through to the underlying regex engine.Adding a --posix flag to disable these was considered, but sed.1 alreadydeclares this version of sed a super-set of POSIX specification and thisbehavior is the most likely expected when one attempts to use one of theseescape sequences in pattern space.This differs from pre-r197362 behavior in that we now honor the threearguably most common escape sequences used with sed(1) and we do so outsideof character classes, too.Other escape sequences, like \s and \S, will come later when GNU extensionsare added to libregex; sed will likely link against libregex by default,since the GNU extensions tend to be fairly un-intrusive.PR: 229925Reviewed by: bapt, emaste, pfgDifferential Revision: https://reviews.freebsd.org/D22750
usr.bin/sed/tests: fix one of the regression test cases by adding itsresults file to the build.Reviewed by: kevansApproved by: kib (mentor, implicit)Differential Revision: https://reviews.freebs
usr.bin/sed/tests: fix one of the regression test cases by adding itsresults file to the build.Reviewed by: kevansApproved by: kib (mentor, implicit)Differential Revision: https://reviews.freebsd.org/D17776
sed: Fix -i option behavior with 'q' command.Don't just exit when encountering the 'q' command if we edit fileinplace, and give mf_fgets() a chance to actually handle theinplace case.Also add a
sed: Fix -i option behavior with 'q' command.Don't just exit when encountering the 'q' command if we edit fileinplace, and give mf_fgets() a chance to actually handle theinplace case.Also add a regression test.Submitted by: Yuri Pankov <[email protected]>Approved by: re (kib)MFC after: 1 weekDifferential Revision: https://reviews.freebsd.org/D16798
Renumber copyright clause 4Renumber cluase 4 to 3, per what everybody else did when BSD grantedthem permission to remove clause 3. My insistance on keeping the samenumbering for legal reasons is
Renumber copyright clause 4Renumber cluase 4 to 3, per what everybody else did when BSD grantedthem permission to remove clause 3. My insistance on keeping the samenumbering for legal reasons is too pedantic, so give up on that point.Submitted by: Jan Schaumann <[email protected]>Pull Request: https://github.com/freebsd/freebsd/pull/96
Don't expect :inplace_symlink_src to fail anymore (post-r313277)The S_ISREG check was restored, such that the code will again fail within-place replacements on symlinksMFC after: 12 daysX-MFC w
Don't expect :inplace_symlink_src to fail anymore (post-r313277)The S_ISREG check was restored, such that the code will again fail within-place replacements on symlinksMFC after: 12 daysX-MFC with: r313277Sponsored by: Dell EMC Isilon
Add testcases for -i with hardlinks and symlinksThe symlink testcase is expected to fail, post-r312519 (the revert ofr312404); mark it so.MFC after: 3 weeksSponsored by: Dell EMC Isilon
Integrate contrib/netbsd-tests/usr.bin/sed/t_sed.sh into the FreeBSD testsuite as usr.bin/sed/sed_testDon't expect :emptybackref to fail -- it succeeds on FreeBSDMFC after: 3 weeksSponsored by:
Integrate contrib/netbsd-tests/usr.bin/sed/t_sed.sh into the FreeBSD testsuite as usr.bin/sed/sed_testDon't expect :emptybackref to fail -- it succeeds on FreeBSDMFC after: 3 weeksSponsored by: Dell EMC Isilon
Testcase 7.8 no longer needs to be marked TODOIt passes out of the box todayMFC after: 2 monthsSponsored by: EMC / Isilon Storage Division
Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installedafter r298107Summary of changes:- Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that na
Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installedafter r298107Summary of changes:- Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that namespacing is kept with FILES appropriately, and that this shouldn't need to be repeated if the namespace changes -- only the definition of PACKAGE needs to be changed- Allow PACKAGE to be overridden by callers instead of forcing it to always be `tests`. In the event we get to the point where things can be split up enough in the base system, it would make more sense to group the tests with the blocks they're a part of, e.g. byacc with byacc-tests, etc- Remove PACKAGE definitions where possible, i.e. where FILES wasn't used previously.- Remove unnecessary TESTSPACKAGE definitions; this has been elided into bsd.tests.mk- Remove unnecessary BINDIRs used previously with ${PACKAGE}FILES; ${PACKAGE}FILESDIR is now automatically defined in bsd.test.mk.- Fix installation of files under data/ subdirectories in lib/libc/tests/hash and lib/libc/tests/net/getaddrinfo- Remove unnecessary .include <bsd.own.mk>s (some opportunistic cleanup)Document the proposed changes in share/examples/tests/tests/... via examplesso it's clear that ${PACKAGES}FILES is the suggested way forward in terms ofreplacing FILES. share/mk/bsd.README didn't seem like the appropriate methodof communicating that info.MFC after: never probablyX-MFC with: r298107PR: 209114Relnotes: yesTested with: buildworld, installworld, checkworld; buildworld, packageworldSponsored by: EMC / Isilon Storage Division
DIRDEPS_BUILD: Connect MK_TESTS.Sponsored by: EMC / Isilon Storage Division
Avoid adding the '-release' suffix to non-debug kernel packages.Sponsored by: The FreeBSD Foundation
Refactor the test/ Makefiles after recent changes to bsd.test.mk (r289158) andnetbsd-tests.test.mk (r289151)- Eliminate explicit OBJTOP/SRCTOP setting- Convert all ad hoc NetBSD test integration
Refactor the test/ Makefiles after recent changes to bsd.test.mk (r289158) andnetbsd-tests.test.mk (r289151)- Eliminate explicit OBJTOP/SRCTOP setting- Convert all ad hoc NetBSD test integration over to netbsd-tests.test.mk- Remove unnecessary TESTSDIR setting- Use SRCTOP where possible for clarityMFC after: 2 weeksSponsored by: EMC / Isilon Storage Divison
Add a regression test for PR 192108.I won't go through the hassle of MFCing it since I expect all changes to gofirst through HEAD anyway.PR: 192108
sed(1): Don't force a newline on last line, if input stream doesn't have oneWhile here, change how we check if the current line is the last one.Before, we just checked if there were more files aft
sed(1): Don't force a newline on last line, if input stream doesn't have oneWhile here, change how we check if the current line is the last one.Before, we just checked if there were more files after the current one.Now, we check the actual content of those files: they files may not havea line at all. This matches the definition of the "last line" by theOpen Group.The new behavior is closer to GNU sed.PR: 160745Phabric: https://phabric.freebsd.org/D431Reviewed by: jillesApproved by: jillesExp-run by: antoine
Mark multi_test as requiring /usr/share/dict/words.The file may not be present if MK_DICT=no. Pointed out by Casey Peel.
Migrate most of tools/regression/usr.bin/ to the new tests layout.I'm starting with the easy cases. The leftovers need to be looked at abit more closely.Note that this change _does_ modify the
Migrate most of tools/regression/usr.bin/ to the new tests layout.I'm starting with the easy cases. The leftovers need to be looked at abit more closely.Note that this change _does_ modify the code of the old tests. This isrequired in order to allow the code to locate the data files in thesource directory instead of the current directory, because Kyuaautomatically changes the latter to a temporary directory.Also note that at least one test is known to be broken here. Actually,the test is not really broken: it's marked as a TODO but unfortunatelyKyua's TAP parser currently does not understand that. Will have to befixed separately.