grep: tests: stop testing for a nonexistent version of grepDifferential Revision: https://reviews.freebsd.org/D27732
grep: tests: stop expecting a failure of gnuext w/ bsdgreplibregex now supports these and we no longer offer to not link againstlibregex.
bsdgrep(1): add some basic tests for some GNU Extension supportThese will be expanded later as I come up with good test cases; for now,these seem to be enough to trigger bugs in base gnugrep and e
bsdgrep(1): add some basic tests for some GNU Extension supportThese will be expanded later as I come up with good test cases; for now,these seem to be enough to trigger bugs in base gnugrep and expose missingfeatures in bsdgrep.
show more ...
Standardize SPDX tag on files I've added
Remove "All Rights Reserved" on files that I hold sole copyright onSee r333391 for more detail; in summary: it holds no weight and may beremoved.
grep test: Fix copyright noticeThe copyright notice was erroneously introduced as one from the NetBSDfoundation due to it being copied from a file in the NetBSD test suite, butthis file itself is
grep test: Fix copyright noticeThe copyright notice was erroneously introduced as one from the NetBSDfoundation due to it being copied from a file in the NetBSD test suite, butthis file itself is not derived from or supplied with the NetBSD test suite.MFC after: 3 days
Update copyright e-mail address to @FreeBSD.org addressApproved by: emaste (mentor)Differential Revision: https://reviews.freebsd.org/D11508
:rgrep : use atf-check to check the exit code/save the output of grep -r insteadof calling grep -r without it, and saving the output to a fileThis ensures that any errors thrown via grep -r are ca
:rgrep : use atf-check to check the exit code/save the output of grep -r insteadof calling grep -r without it, and saving the output to a fileThis ensures that any errors thrown via grep -r are caught, not lost, and usesexisting atf-sh idioms for saving files.Tested with: bsdgrep, gnu grep (base, ports)Sponsored by: Dell EMC Isilon
bsdgrep: fix -w flag matching with an empty pattern-w flag matching with an empty pattern was generally 'broken', allowingmatches to occur on any line whether or not it actually matches -wcriteri
bsdgrep: fix -w flag matching with an empty pattern-w flag matching with an empty pattern was generally 'broken', allowingmatches to occur on any line whether or not it actually matches -wcriteria.This fix required a good amount of refactoring to address. procline()is altered to *only* process the line and return whether it was a matchor not, necessary to be able to short-circuit the whole function in caseof this matchall flag. -m flag handling is moved out as well because itsuffers from the same fate as context handling if we bypass any actualpattern matching.The matching context (matches, mostly) didn't previously exist outsideof procline(), so we go ahead and create context object for fileprocessing bits to pass around. grep_printline() was created due tothis, for the scenarios where the matches don't actually matter and wejust want to print a line or two, a la flushing the context queue andno -o or --color specified.Damage from this broken behavior would have been mitigated by the factthat it is unlikely users would invoke grep -w with an empty pattern.This was identified while checking PR 105221 for problems it this maycause in BSD grep, but PR 105221 is *not* a report of this behavior.Submitted by: Kyle Evans <kevans91 at ksu.edu>Differential Revision: https://reviews.freebsd.org/D10433
Only expect :grep_r_implied to pass with bsdgrep(1)The test fails with gnu grep from base and ports.Sponsored by: Dell EMC Isilon
bsdgrep: for -r, use the working directory if none specifiedThis is more sensible than the previous behaviour of grepping stdin,and matches newer GNU grep behaviour.PR: 216307Submitted by: Kyl
bsdgrep: for -r, use the working directory if none specifiedThis is more sensible than the previous behaviour of grepping stdin,and matches newer GNU grep behaviour.PR: 216307Submitted by: Kyle Evans <kevans91 at ksu.edu>Reviewed by: cem, emaste, ngieRelnotes: YesDifferential Revision: https://reviews.freebsd.org/
bsdgrep: create additional tests for coverage on recent fixesCreate additional tests to cover regressions that were discovered byPRs linked to reviews D10098, D10102, and D10104.It is worth noti
bsdgrep: create additional tests for coverage on recent fixesCreate additional tests to cover regressions that were discovered byPRs linked to reviews D10098, D10102, and D10104.It is worth noting that neither bsdgrep(1) nor gnugrep(1) in the basesystem currently pass all of these tests, and gnugrep(1) not quite beingup to snuff was also noted in at least one of the PRs.PR: 175314 202022 195763 180990 197555 197531 181263 209116Submitted by: Kyle Evans <[email protected]>Reviewed by: cem, ngie, emasteMFC after: 1 monthDifferential Revision: https://reviews.freebsd.org/D10112
Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installedafter r298107Summary of changes:- Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that na
Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installedafter r298107Summary of changes:- Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that namespacing is kept with FILES appropriately, and that this shouldn't need to be repeated if the namespace changes -- only the definition of PACKAGE needs to be changed- Allow PACKAGE to be overridden by callers instead of forcing it to always be `tests`. In the event we get to the point where things can be split up enough in the base system, it would make more sense to group the tests with the blocks they're a part of, e.g. byacc with byacc-tests, etc- Remove PACKAGE definitions where possible, i.e. where FILES wasn't used previously.- Remove unnecessary TESTSPACKAGE definitions; this has been elided into bsd.tests.mk- Remove unnecessary BINDIRs used previously with ${PACKAGE}FILES; ${PACKAGE}FILESDIR is now automatically defined in bsd.test.mk.- Fix installation of files under data/ subdirectories in lib/libc/tests/hash and lib/libc/tests/net/getaddrinfo- Remove unnecessary .include <bsd.own.mk>s (some opportunistic cleanup)Document the proposed changes in share/examples/tests/tests/... via examplesso it's clear that ${PACKAGES}FILES is the suggested way forward in terms ofreplacing FILES. share/mk/bsd.README didn't seem like the appropriate methodof communicating that info.MFC after: never probablyX-MFC with: r298107PR: 209114Relnotes: yesTested with: buildworld, installworld, checkworld; buildworld, packageworldSponsored by: EMC / Isilon Storage Division
DIRDEPS_BUILD: Connect MK_TESTS.Sponsored by: EMC / Isilon Storage Division
Avoid adding the '-release' suffix to non-debug kernel packages.Sponsored by: The FreeBSD Foundation
Refactor the test/ Makefiles after recent changes to bsd.test.mk (r289158) andnetbsd-tests.test.mk (r289151)- Eliminate explicit OBJTOP/SRCTOP setting- Convert all ad hoc NetBSD test integration
Refactor the test/ Makefiles after recent changes to bsd.test.mk (r289158) andnetbsd-tests.test.mk (r289151)- Eliminate explicit OBJTOP/SRCTOP setting- Convert all ad hoc NetBSD test integration over to netbsd-tests.test.mk- Remove unnecessary TESTSDIR setting- Use SRCTOP where possible for clarityMFC after: 2 weeksSponsored by: EMC / Isilon Storage Divison
Integrate usr.bin/grep/tests from NetBSD into atf/kyuaSponsored by: EMC / Isilon Storage Division