wbwd: Mark sysctls with CTLFLAG_MPSAFE.MFC after: 2 weeks(cherry picked from commit fdec27ed82ea3f6406a7089e5e1ffd99bb4929e0)
wbwd: clean up empty lines in .c and .h files
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that arestill not MPSAFE (or already are but aren’t properly mark
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that arestill not MPSAFE (or already are but aren’t properly marked).Use it in preparation for a general review of all nodes.This is non-functional change that adds annotations to SYSCTL_NODE andSYSCTL_PROC nodes using one of the soon-to-be-required flags.Mark all obvious cases as MPSAFE. All entries that haven't been markedas MPSAFE before are by default marked as NEEDGIANTApproved by: kib (mentor, blanket)Commented by: kib, gallatin, melifaroDifferential Revision: https://reviews.freebsd.org/D23718
show more ...
wbwd: small clean-ups and improvementsThis change applies some suggestions by delphij from D21979.A write-only variable is removed.There is a diagnostic message if the driver does not recognize t
wbwd: small clean-ups and improvementsThis change applies some suggestions by delphij from D21979.A write-only variable is removed.There is a diagnostic message if the driver does not recognize the chip.A chained if-statement is converted to a switch.MFC after: 3 weeks
wbwd: move to superio(4) busThis allows to remove a bunch of low level code.Also, superio(4) provides safer interaction with other driversthat work with Super I/O configuration registers.Tested
wbwd: move to superio(4) busThis allows to remove a bunch of low level code.Also, superio(4) provides safer interaction with other driversthat work with Super I/O configuration registers.Tested only on PCengines APU2:superio0: <Nuvoton NCT5104D/NCT6102D/NCT6106D (rev. B+)> at port 0x2e-0x2f on isa0wbwd0: <Nuvoton NCT6102 (0xc4/0x53) Watchdog Timer> at WDT ldn 0x08 on superio0The watchdog output is incorrectly wired on that system and the watchdogdoes not really do it its job, but the pulse can be seen with a signalanalyzer.Reviewed by: delphij, bcr (man page)MFC after: 19 daysDifferential Revision: https://reviews.freebsd.org/D21979
Add IDs for Nuvoton NCT6793/NCT6795.MFC after: 2 weeks
sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - error
sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - errorprone - task.The Software Package Data Exchange (SPDX) group provides a specificationto make it easier for automated tools to detect and summarize well knownopensource licenses. We are gradually adopting the specification, notingthat the tags are considered only advisory and do not, in any way,superceed or replace the license texts.
etc: minor spelling fixes.Mostly comments but also some user-visible strings.MFC after: 2 weeks
sys/dev: use our nitems() macro when it is avaliable through param.h.No functional change, only trivial cases are done in this sweep,Drivers that can get further enhancements will be done independ
sys/dev: use our nitems() macro when it is avaliable through param.h.No functional change, only trivial cases are done in this sweep,Drivers that can get further enhancements will be done independently.Discussed in: freebsd-current
Remove watchdog timer stop check.There are bunch of reports that this check fails at least on NuvotonNCT6776 chips. I don't see why this check needed there, and Linux doesnot have it either. So
Remove watchdog timer stop check.There are bunch of reports that this check fails at least on NuvotonNCT6776 chips. I don't see why this check needed there, and Linux doesnot have it either. So far this check only made watchdogd unstopable.MFC after: 1 month
Polish wbwd(4) driver and add more supported chips.MFC after: 1 month
Revert r279933; this is going to be fixed in sbuf instead.PR: 195668
Nullterminate strings returned via sysctl.PR: 195668
Add ID for Nuvoton WPCM450RA0BX found on Supermicro X9SCA-F motherboards.While I'm there, also make this driver to attach to devices that havean unknown device ID.MFC after: 1 month
Add DEVICE_IDENTIFY method for wbwd(4), required on most of recentSupermicro motherboards.Tested on X8STi and X8DTH boards.Sponsored by: iXsystems, Inc.MFC after: 2 weeks
Use DEVMETHOD_END.MFC after: 2 weeks
sbuf_trim() cannot be used on sbuf with drain function set.This fixes panic when listing sysctls on INVARIANTS-enabled kernel whilehaving wbwd loaded.This panic was not fatal, at worst one additi
sbuf_trim() cannot be used on sbuf with drain function set.This fixes panic when listing sysctls on INVARIANTS-enabled kernel whilehaving wbwd loaded.This panic was not fatal, at worst one additional space was printed.Also sbuf_trim() makes some sense even if drain function is set. The drainfunction is called only when buffer is to be expanded. So we could still trimexisting buffer before drain is called. In this case it worked just fine - thetrailing space was correctly trimmed.Obtained from: WHEEL SystemsMFC after: 1 week
Add device ids for the Winbond 83627DHG-P chip and set the registers totrigger the keyboard reset line on timeout.Reviewed by: bzMFC after: 1 week
Fix a typo in wbwd so that CRF5 is actually written to the data registerrather than the index register.Reviewed by: bzMFC after: 3 days
Provide wbwd(4), a driver for the watchdog timer found on variousWinbond Super I/O chips.With minor efforts it should be possible the extend the driver to supportfurther chips/revisions available
Provide wbwd(4), a driver for the watchdog timer found on variousWinbond Super I/O chips.With minor efforts it should be possible the extend the driver to supportfurther chips/revisions available from Winbond. In the simplest caseonly new IDs need to be added, while different chipsets might requiretheir own function to enter extended function mode, etc.Sponsored by: Sandvine Incorporated ULC (in 2011)Reviewed by: emaste, bruefferMFC after: 2 weeks