crypto: Add a new type of crypto buffer for a single mbuf.This is intended for use in KTLS transmit where each TLS record isdescribed by a single mbuf that is itself queued in the socket buffer.U
crypto: Add a new type of crypto buffer for a single mbuf.This is intended for use in KTLS transmit where each TLS record isdescribed by a single mbuf that is itself queued in the socket buffer.Using the existing CRYPTO_BUF_MBUF would result inbus_dmamap_load_crp() walking additional mbufs in the socket bufferthat are not relevant, but generating a S/G list that potentiallyexceeds the limit of the tag (while also wasting CPU cycles).Reviewed by: markjSponsored by: NetflixDifferential Revision: https://reviews.freebsd.org/D30136(cherry picked from commit 883a0196b629a07e52562b4103cc0f6391083080)
show more ...
sec: clean up empty lines in .c and .h files
[PowerPC] Fix build failure in sec.cFix a typo in r364799 that was breaking powerpc and powerpcspe build.MFC with: 364799
crypto(9): add CRYPTO_BUF_VMPAGEcrypto(9) functions can now be used on buffers composed of an array ofvm_page_t structures, such as those stored in an unmapped struct bio. Itrequires the running
crypto(9): add CRYPTO_BUF_VMPAGEcrypto(9) functions can now be used on buffers composed of an array ofvm_page_t structures, such as those stored in an unmapped struct bio. Itrequires the running to kernel to support the direct memory map, so not allarchitectures can use it.Reviewed by: markj, kib, jhb, mjg, mat, bcr (manpages)MFC after: 1 weekSponsored by: AxcientDifferential Revision: https://reviews.freebsd.org/D25671
Update sec(4) for separate output buffers changes in r361481.This does not add support for separate output buffers but updates thedriver to cope with the changes.Pointy hat to: jhb
Remove MD5 HMAC from OCF.There are no in-kernel consumers.Reviewed by: cemRelnotes: yesSponsored by: Chelsio CommunicationsDifferential Revision: https://reviews.freebsd.org/D24775
Remove support for DES and Triple DES from OCF.It no longer has any in-kernel consumers via OCF. smbfs still usessingle DES directly, so sys/crypto/des remains for that use case.Reviewed by: ce
Remove support for DES and Triple DES from OCF.It no longer has any in-kernel consumers via OCF. smbfs still usessingle DES directly, so sys/crypto/des remains for that use case.Reviewed by: cemRelnotes: yesSponsored by: Chelsio CommunicationsDifferential Revision: https://reviews.freebsd.org/D24773
Remove incomplete support for plain MD5 from OCF.Although a few drivers supported this algorithm, there were never anyin-kernel consumers. cryptosoft and cryptodev never supported it,and there w
Remove incomplete support for plain MD5 from OCF.Although a few drivers supported this algorithm, there were never anyin-kernel consumers. cryptosoft and cryptodev never supported it,and there was not a software xform auth_hash for it.Reviewed by: cemRelnotes: yesSponsored by: Chelsio CommunicationsDifferential Revision: https://reviews.freebsd.org/D24767
Retire the CRYPTO_F_IV_GENERATE flag.The sole in-tree user of this flag has been retired, so remove thiscomplexity from all drivers. While here, add a helper routine driverscan use to read the c
Retire the CRYPTO_F_IV_GENERATE flag.The sole in-tree user of this flag has been retired, so remove thiscomplexity from all drivers. While here, add a helper routine driverscan use to read the current request's IV into a local buffer. Usethis routine to replace duplicated code in nearly all drivers.Reviewed by: cemSponsored by: NetflixDifferential Revision: https://reviews.freebsd.org/D24450
Refactor driver and consumer interfaces for OCF (in-kernel crypto).- The linked list of cryptoini structures used in session initialization is replaced with a new flat structure: struct crypto_
Refactor driver and consumer interfaces for OCF (in-kernel crypto).- The linked list of cryptoini structures used in session initialization is replaced with a new flat structure: struct crypto_session_params. This session includes a new mode to define how the other fields should be interpreted. Available modes include: - COMPRESS (for compression/decompression) - CIPHER (for simply encryption/decryption) - DIGEST (computing and verifying digests) - AEAD (combined auth and encryption such as AES-GCM and AES-CCM) - ETA (combined auth and encryption using encrypt-then-authenticate) Additional modes could be added in the future (e.g. if we wanted to support TLS MtE for AES-CBC in the kernel we could add a new mode for that. TLS modes might also affect how AAD is interpreted, etc.) The flat structure also includes the key lengths and algorithms as before. However, code doesn't have to walk the linked list and switch on the algorithm to determine which key is the auth key vs encryption key. The 'csp_auth_*' fields are always used for auth keys and settings and 'csp_cipher_*' for cipher. (Compression algorithms are stored in csp_cipher_alg.)- Drivers no longer register a list of supported algorithms. This doesn't quite work when you factor in modes (e.g. a driver might support both AES-CBC and SHA2-256-HMAC separately but not combined for ETA). Instead, a new 'crypto_probesession' method has been added to the kobj interface for symmteric crypto drivers. This method returns a negative value on success (similar to how device_probe works) and the crypto framework uses this value to pick the "best" driver. There are three constants for hardware (e.g. ccr), accelerated software (e.g. aesni), and plain software (cryptosoft) that give preference in that order. One effect of this is that if you request only hardware when creating a new session, you will no longer get a session using accelerated software. Another effect is that the default setting to disallow software crypto via /dev/crypto now disables accelerated software. Once a driver is chosen, 'crypto_newsession' is invoked as before.- Crypto operations are now solely described by the flat 'cryptop' structure. The linked list of descriptors has been removed. A separate enum has been added to describe the type of data buffer in use instead of using CRYPTO_F_* flags to make it easier to add more types in the future if needed (e.g. wired userspace buffers for zero-copy). It will also make it easier to re-introduce separate input and output buffers (in-kernel TLS would benefit from this). Try to make the flags related to IV handling less insane: - CRYPTO_F_IV_SEPARATE means that the IV is stored in the 'crp_iv' member of the operation structure. If this flag is not set, the IV is stored in the data buffer at the 'crp_iv_start' offset. - CRYPTO_F_IV_GENERATE means that a random IV should be generated and stored into the data buffer. This cannot be used with CRYPTO_F_IV_SEPARATE. If a consumer wants to deal with explicit vs implicit IVs, etc. it can always generate the IV however it needs and store partial IVs in the buffer and the full IV/nonce in crp_iv and set CRYPTO_F_IV_SEPARATE. The layout of the buffer is now described via fields in cryptop. crp_aad_start and crp_aad_length define the boundaries of any AAD. Previously with GCM and CCM you defined an auth crd with this range, but for ETA your auth crd had to span both the AAD and plaintext (and they had to be adjacent). crp_payload_start and crp_payload_length define the boundaries of the plaintext/ciphertext. Modes that only do a single operation (COMPRESS, CIPHER, DIGEST) should only use this region and leave the AAD region empty. If a digest is present (or should be generated), it's starting location is marked by crp_digest_start. Instead of using the CRD_F_ENCRYPT flag to determine the direction of the operation, cryptop now includes an 'op' field defining the operation to perform. For digests I've added a new VERIFY digest mode which assumes a digest is present in the input and fails the request with EBADMSG if it doesn't match the internally-computed digest. GCM and CCM already assumed this, and the new AEAD mode requires this for decryption. The new ETA mode now also requires this for decryption, so IPsec and GELI no longer do their own authentication verification. Simple DIGEST operations can also do this, though there are no in-tree consumers. To eventually support some refcounting to close races, the session cookie is now passed to crypto_getop() and clients should no longer set crp_sesssion directly.- Assymteric crypto operation structures should be allocated via crypto_getkreq() and freed via crypto_freekreq(). This permits the crypto layer to track open asym requests and close races with a driver trying to unregister while asym requests are in flight.- crypto_copyback, crypto_copydata, crypto_apply, and crypto_contiguous_subsegment now accept the 'crp' object as the first parameter instead of individual members. This makes it easier to deal with different buffer types in the future as well as separate input and output buffers. It's also simpler for driver writers to use.- bus_dmamap_load_crp() loads a DMA mapping for a crypto buffer. This understands the various types of buffers so that drivers that use DMA do not have to be aware of different buffer types.- Helper routines now exist to build an auth context for HMAC IPAD and OPAD. This reduces some duplicated work among drivers.- Key buffers are now treated as const throughout the framework and in device drivers. However, session key buffers provided when a session is created are expected to remain alive for the duration of the session.- GCM and CCM sessions now only specify a cipher algorithm and a cipher key. The redundant auth information is not needed or used.- For cryptosoft, split up the code a bit such that the 'process' callback now invokes a function pointer in the session. This function pointer is set based on the mode (in effect) though it simplifies a few edge cases that would otherwise be in the switch in 'process'. It does split up GCM vs CCM which I think is more readable even if there is some duplication.- I changed /dev/crypto to support GMAC requests using CRYPTO_AES_NIST_GMAC as an auth algorithm and updated cryptocheck to work with it.- Combined cipher and auth sessions via /dev/crypto now always use ETA mode. The COP_F_CIPHER_FIRST flag is now a no-op that is ignored. This was actually documented as being true in crypto(4) before, but the code had not implemented this before I added the CIPHER_FIRST flag.- I have not yet updated /dev/crypto to be aware of explicit modes for sessions. I will probably do that at some point in the future as well as teach it about IV/nonce and tag lengths for AEAD so we can support all of the NIST KAT tests for GCM and CCM.- I've split up the exising crypto.9 manpage into several pages of which many are written from scratch.- I have converted all drivers and consumers in the tree and verified that they compile, but I have not tested all of them. I have tested the following drivers: - cryptosoft - aesni (AES only) - blake2 - ccr and the following consumers: - cryptodev - IPsec - ktls_ocf - GELI (lightly) I have not tested the following: - ccp - aesni with sha - hifn - kgssapi_krb5 - ubsec - padlock - safe - armv8_crypto (aarch64) - glxsb (i386) - sec (ppc) - cesa (armv7) - cryptocteon (mips64) - nlmsec (mips64)Discussed with: cemRelnotes: yesSponsored by: Chelsio CommunicationsDifferential Revision: https://reviews.freebsd.org/D23677
OpenCrypto: Convert sessions to opaque handles instead of integersTrack session objects in the framework, and pass handles between theframework (OCF), consumers, and drivers. Avoid redundancy and
OpenCrypto: Convert sessions to opaque handles instead of integersTrack session objects in the framework, and pass handles between theframework (OCF), consumers, and drivers. Avoid redundancy and complexity inindividual drivers by allocating session memory in the framework andproviding it to drivers in ::newsession().Session handles are no longer integers with information encoded in varioushigh bits. Use of the CRYPTO_SESID2FOO() macros should be replaced with theappropriate crypto_ses2foo() function on the opaque session handle.Convert OCF drivers (in particular, cryptosoft, as well as myriad others) tothe opaque handle interface. Discard existing session tracking as much aspossible (quick pass). There may be additional code ripe for deletion.Convert OCF consumers (ipsec, geom_eli, krb5, cryptodev) to handle-styleinterface. The conversion is largely mechnical.The change is documented in crypto.9.Inspired byhttps://lists.freebsd.org/pipermail/freebsd-arch/2018-January/018835.html .No objection from: ae (ipsec portion)Reported by: jhb
sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - error
sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - errorprone - task.The Software Package Data Exchange (SPDX) group provides a specificationto make it easier for automated tools to detect and summarize well knownopensource licenses. We are gradually adopting the specification, notingthat the tags are considered only advisory and do not, in any way,superceed or replace the license texts.
Accidentally dropped the 0 padding.Pointed out by: cmeyer
Fix a couple printf formats.This was found when working on 64-bit PowerPC book-e support.
Follow r261352 by updating all drivers which are children of simplebusto check the status property in their probe routines.Simplebus used to only instantiate its children whose status="okay"but t
Follow r261352 by updating all drivers which are children of simplebusto check the status property in their probe routines.Simplebus used to only instantiate its children whose status="okay"but that was improper behavior, fixed in r261352. Now that it doesn'tcheck anymore and probes all its children; the children all have todo the check because really only the children know how to properlyinterpret their status property strings.Right now all existing drivers only understand "okay" versus something-that's-not-okay, so they all use the new ofw_bus_status_okay() helper.
Recognize version 3.1 of the SEC crypto engine.
- There's no need to overwrite the default device method with the default one. Interestingly, these are actually the default for quite some time (bus_generic_driver_added(9) since r52045 and bus_
- There's no need to overwrite the default device method with the default one. Interestingly, these are actually the default for quite some time (bus_generic_driver_added(9) since r52045 and bus_generic_print_child(9) since r52045) but even recently added device drivers do this unnecessarily. Discussed with: jhb, marcel- While at it, use DEVMETHOD_END. Discussed with: jhb- Also while at it, use __FBSDID.
Convert Freescale PowerPC platforms to FDT convention.The following systems are affected: - MPC8555CDS - MPC8572DSThis overhaul covers the following major changes: - All integrated periph
Convert Freescale PowerPC platforms to FDT convention.The following systems are affected: - MPC8555CDS - MPC8572DSThis overhaul covers the following major changes: - All integrated peripherals drivers for Freescale MPC85XX SoC, which are currently in the FreeBSD source tree are reworked and adjusted so they derive config data out of the device tree blob (instead of hard coded / tabelarized values). - This includes: LBC, PCI / PCI-Express, I2C, DS1553, OpenPIC, TSEC, SEC, QUICC, UART, CFI. - Thanks to the common FDT infrastrucutre (fdtbus, simplebus) we retire ocpbus(4) driver, which was based on hard-coded config data.Note that world for these platforms has to be built WITH_FDT.Reviewed by: impSponsored by: The FreeBSD Foundation
Fix Book-E/MPC85XX build. Some prototypes were wrong and got revealed withthe recent kobj signature checking.
Initial version of the sec(4) driver for the integrated security engine foundin Freescale system-on-chip devices.The following algorithms and schemes are currently supported: - 3DES, AES, DES
Initial version of the sec(4) driver for the integrated security engine foundin Freescale system-on-chip devices.The following algorithms and schemes are currently supported: - 3DES, AES, DES - MD5, SHA1, SHA256, SHA384, SHA512Reviewed by: philipObtained from: Freescale, Semihalf