| 120ba9ec | 04-Mar-2022 |
Ram Kishore Vegesna <[email protected]> |
ocs_fc: Ignore flogi failure when the remote node is pt2pt winner
Updated commit 79c56c9af583, do not proceed with discovery
if flogi fails in pt2pt winner case.
MFC after: 3 days
(cherry picked f
ocs_fc: Ignore flogi failure when the remote node is pt2pt winner
Updated commit 79c56c9af583, do not proceed with discovery
if flogi fails in pt2pt winner case.
MFC after: 3 days
(cherry picked from commit 625a8bfb047a94459b4ab41f08fe5a2c23694039)
show more ...
|
| 4a90d6c8 | 03-Mar-2022 |
Ram Kishore Vegesna <[email protected]> |
ocs_fc: Do not respond to unsolicited NOP BLS command.
Summary: Drop unsolicited BLS commands other than ABTS.
Reviewed by: mav
MFC after: 3 days
Differential Revision: https://reviews.freebsd.or
ocs_fc: Do not respond to unsolicited NOP BLS command.
Summary: Drop unsolicited BLS commands other than ABTS.
Reviewed by: mav
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D34423
(cherry picked from commit 57e4b677559a742031c7478d801c1e218afae239)
show more ...
|
| de7809c1 | 06-Dec-2021 |
Ram Kishore Vegesna <[email protected]> |
ocs_fc: Remove unused function delarations.
Remove unused function declarations.
Changes required for internal tool.
Approved by: ken
(cherry picked from commit 6f78736cb12026fcb423e1b313e83efb805
ocs_fc: Remove unused function delarations.
Remove unused function declarations.
Changes required for internal tool.
Approved by: ken
(cherry picked from commit 6f78736cb12026fcb423e1b313e83efb80597f21)
show more ...
|
| 161148e6 | 24-Sep-2021 |
Ram Kishore Vegesna <[email protected]> |
ocs_fc: Fix device lost timer where device is not getting deleted.
Issue: Devices wont go away after the link down.
Device lost timer functionality in ocs_fc is broken,
`is_target` flag is not set
ocs_fc: Fix device lost timer where device is not getting deleted.
Issue: Devices wont go away after the link down.
Device lost timer functionality in ocs_fc is broken,
`is_target` flag is not set in the target database and target delete is skipped.
Fix: Remove unused flags and delete the device when timer expires.
Reported by: [email protected]
Reviewed by: mav, ken
(cherry picked from commit 41e946694333bcc6f64242f294312553f2ef2dcd)
show more ...
|
| 0fff0289 | 24-Sep-2021 |
Ram Kishore Vegesna <[email protected]> |
ocs_fc: When commands complete with an error, freeze the device queue.
Proper error recovery depends on freezing the device queue when an
error occurs, so we can recover from an error before sending
ocs_fc: When commands complete with an error, freeze the device queue.
Proper error recovery depends on freezing the device queue when an
error occurs, so we can recover from an error before sending
additional commands.
The ocs_fc(4) driver was not freezing the device queue for most
SCSI errors, and that broke error recovery.
sys/dev/ocs_fc/ocs_cam.c:
In ocs_scsi_initiator_io_cb(), freeze the device queue if
we're passing back status other than CAM_REQ_CMP.
Submitted by: [email protected]
Reviewed by: mav, ken
(cherry picked from commit d063d1bc928165e7798df5ec1c424794a1ec41e9)
show more ...
|
| 4821da88 | 24-Sep-2021 |
Ram Kishore Vegesna <[email protected]> |
ocs_fc: Fix CAM status reporting in ocs_fc(4) when no data is returned.
In ocs_scsi_initiator_io_cb(), if the SCSI command that is
getting completed had a residual equal to the trans
ocs_fc: Fix CAM status reporting in ocs_fc(4) when no data is returned.
In ocs_scsi_initiator_io_cb(), if the SCSI command that is
getting completed had a residual equal to the transfer length,
it was setting the CCB status to CAM_REQ_CMP.
That breaks the expected behavior for commands like READ ATTRIBUTE.
For READ ATTRIBUTE, if the first attribute requested doesn't exist,
the command is supposed to return an error (Illegal Request,
Invalid Field in CDB). The broken behavior for READ ATTRIBUTE
caused LTFS tape formatting to fail. It looks for attribute
0x1623, and expects to see an error if the attribute isn't present.
In addition, if the residual is negative (indicating an overrun),
only set the CCB status to CAM_DATA_RUN_ERR if we have not already
reported an error. The SCSI sense data will have more detail about
what went wrong.
sys/dev/ocs_fc/ocs_cam.c:
In ocs_scsi_initiator_io_cb(), don't set the status to
CAM_REQ_CMP if the residual is equal to the transfer length.
Also, only set CAM_DATA_RUN_ERR if we didn't get SCSI
status.
Submitted by: [email protected]
Reviewed by: mav, ken
(cherry picked from commit 1af49c2eeb4a05f524ed9a6657c741bc96fbaf87)
show more ...
|
| 44a78c21 | 24-Jun-2021 |
Ram Kishore Vegesna <[email protected]> |
ocs_fc: Add gendump and dump_to_host ioctl command support.
Support to generate firmware dump.
Approved by: mav(mentor)
(cherry picked from commit 29e2dbd42c3e2e10e606b3414f4d0c53021d4e86)
Add oc
ocs_fc: Add gendump and dump_to_host ioctl command support.
Support to generate firmware dump.
Approved by: mav(mentor)
(cherry picked from commit 29e2dbd42c3e2e10e606b3414f4d0c53021d4e86)
Add ocs_gendump.c to the build, missed in 29e2dbd42c3e.
(cherry picked from commit d0732fa81963d336099a6b134a1eb4be867bfa8b)
show more ...
|
| 5749a573 | 28-May-2021 |
Ram Kishore Vegesna <[email protected]> |
ocs_fc: Fix use after free bug in ocs_hw_async_call()
Freed ctx is used in the later callee ocs_hw_command(),
which is a use after free bug.
Return error if sli_cmd_common_nop() failed.
PR: 255865
ocs_fc: Fix use after free bug in ocs_hw_async_call()
Freed ctx is used in the later callee ocs_hw_command(),
which is a use after free bug.
Return error if sli_cmd_common_nop() failed.
PR: 255865
Reported by: [email protected]
Approved by:: markj
(cherry picked from commit 7377d3831bc8abec2d6e5fee359d7383d4551feb)
show more ...
|
| 88364968 | 25-Oct-2020 |
Alexander Motin <[email protected]> |
Introduce support of SCSI Command Priority.
SAM-3 specification introduced concept of Task Priority, that was renamed
to Command Priority in SAM-4, and supported by all modern SCSI transports.
It pr
Introduce support of SCSI Command Priority.
SAM-3 specification introduced concept of Task Priority, that was renamed
to Command Priority in SAM-4, and supported by all modern SCSI transports.
It provides 15 levels of relative priorities: 1 - highest, 15 - lowest and
0 - default. SAT specification for SATA devices translates priorities 1-3
into NCQ high priority.
This change adds new "priority" field into empty spots of struct ccb_scsiio
and struct ccb_accept_tio of CAM and struct ctl_scsiio of CTL. Respective
support is added into iscsi(4), isp(4), mpr(4), mps(4) and ocs_fc(4) drivers
for both initiator and where applicable target roles. Minimal support was
added to CTL to receive the priority value from different frontends, pass it
between HA controllers and report in few places.
This patch does not add consumers of this functionality, so nothing should
really change yet, since the field is still set to 0 (default) on initiator
and not actively used on target. Those are to be implemented separately.
I've confirmed priority working on WD Red SATA disks connected via mpr(4)
and properly transferred to CTL target via iscsi(4), isp(4) and ocs_fc(4).
While there, added missing tag_action support to ocs_fc(4) initiator role.
MFC after: 1 month
Relnotes: yes
Sponsored by: iXsystems, Inc.
show more ...
|