Fix some common typos in source code comments- s/struture/structure/- s/structre/structure/(cherry picked from commit 17db4b52fb41aeabeb945c68c1b5edd4db4eac31)
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that arestill not MPSAFE (or already are but aren’t properly mark
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that arestill not MPSAFE (or already are but aren’t properly marked).Use it in preparation for a general review of all nodes.This is non-functional change that adds annotations to SYSCTL_NODE andSYSCTL_PROC nodes using one of the soon-to-be-required flags.Mark all obvious cases as MPSAFE. All entries that haven't been markedas MPSAFE before are by default marked as NEEDGIANTApproved by: kib (mentor, blanket)Commented by: kib, gallatin, melifaroDifferential Revision: https://reviews.freebsd.org/D23718
show more ...
Mark lio taskqueue as requiring network epoch.
Convert to if_foreach_llmaddr() KPI.
Separate kernel crc32() implementation to its own header (gsb_crc32.h) andrename the source to gsb_crc32.c.This is a prerequisite of unifying kernel zlib instances.PR: 229763Submitted by: Yosh
Separate kernel crc32() implementation to its own header (gsb_crc32.h) andrename the source to gsb_crc32.c.This is a prerequisite of unifying kernel zlib instances.PR: 229763Submitted by: Yoshihiro Ota <ota at j.email.ne.jp>Differential Revision: https://reviews.freebsd.org/D20193
Extract eventfilter declarations to sys/_eventfilter.hThis allows replacing "sys/eventfilter.h" includes with "sys/_eventfilter.h"in other header files (e.g., sys/{bus,conf,cpu}.h) and reduces hea
Extract eventfilter declarations to sys/_eventfilter.hThis allows replacing "sys/eventfilter.h" includes with "sys/_eventfilter.h"in other header files (e.g., sys/{bus,conf,cpu}.h) and reduces headerpollution substantially.EVENTHANDLER_DECLARE and EVENTHANDLER_LIST_DECLAREs were moved out of .cfiles into appropriate headers (e.g., sys/proc.h, powernv/opal.h).As a side effect of reduced header pollution, many .c files and headers nolonger contain needed definitions. The remainder of the patch addressesadding appropriate includes to fix those files.LOCK_DEBUG and LOCK_FILE_LINE_ARG are moved to sys/_lock.h, as required bysys/mutex.h since r326106 (but silently protected by header pollution priorto this change).No functional change (intended). Of course, any out of tree modules thatrelied on header pollution for sys/eventhandler.h, sys/lock.h, orsys/mutex.h inclusion need to be fixed. __FreeBSD_version has been bumped.
Eliminate the arena parameter to kmem_free(). Implicitly this corrects anerror in the function hypercall_memfree(), where the wrong arena was beingpassed to kmem_free().Introduce a per-page flag
Eliminate the arena parameter to kmem_free(). Implicitly this corrects anerror in the function hypercall_memfree(), where the wrong arena was beingpassed to kmem_free().Introduce a per-page flag, VPO_KMEM_EXEC, to mark physical pages that aremapped in kmem with execute permissions. Use this flag to determine whicharena the kmem virtual addresses are returned to.Eliminate UMA_SLAB_KRWX. The introduction of VPO_KMEM_EXEC makes itredundant.Update the nearby comment for UMA_SLAB_KERNEL.Reviewed by: kib, markjDiscussed with: jeffApproved by: re (marius)Differential Revision: https://reviews.freebsd.org/D16845
Eliminate kmem_alloc_contig()'s unused arena parameter.Reviewed by: hselasky, kib, markjDiscussed with: jeffDifferential Revision: https://reviews.freebsd.org/D16799
Fix build of liquidio with base gcc on i386Some casts from pointers to uint64_t and back in lio_main.c cause basegcc on i386 to warn "cast from pointer to integer of different size",and vice vers
Fix build of liquidio with base gcc on i386Some casts from pointers to uint64_t and back in lio_main.c cause basegcc on i386 to warn "cast from pointer to integer of different size",and vice versa. Add additional casts to uintptr_t to suppress these.Reviewed by: sbrunoMFC after: 3 daysDifferential Revision: https://reviews.freebsd.org/D15754
tcp_lro.h requires <netinet/in.h>, include it directly instead ofindirect inclusion trough if_gif.h
ifnet: Replace if_addr_lock rwlock with epoch + mutexRun on LLNW canaries and tested by pho@gallatin:Using a 14-core, 28-HTT single socket E5-2697 v3 with a 40GbE MLX5based ConnectX 4-LX NIC, I
ifnet: Replace if_addr_lock rwlock with epoch + mutexRun on LLNW canaries and tested by pho@gallatin:Using a 14-core, 28-HTT single socket E5-2697 v3 with a 40GbE MLX5based ConnectX 4-LX NIC, I see an almost 12% improvement in receivedpacket rate, and a larger improvement in bytes delivered all the wayto userspace.When the host receiving 64 streams of netperf -H $DUT -t UDP_STREAM -- -m 1,I see, using nstat -I mce0 1 before the patch:InMpps OMpps InGbs OGbs err TCP Est %CPU syscalls csw irq GBfree4.98 0.00 4.42 0.00 4235592 33 83.80 4720653 2149771 1235 247.324.73 0.00 4.20 0.00 4025260 33 82.99 4724900 2139833 1204 247.324.72 0.00 4.20 0.00 4035252 33 82.14 4719162 2132023 1264 247.324.71 0.00 4.21 0.00 4073206 33 83.68 4744973 2123317 1347 247.324.72 0.00 4.21 0.00 4061118 33 80.82 4713615 2188091 1490 247.324.72 0.00 4.21 0.00 4051675 33 85.29 4727399 2109011 1205 247.324.73 0.00 4.21 0.00 4039056 33 84.65 4724735 2102603 1053 247.32After the patchInMpps OMpps InGbs OGbs err TCP Est %CPU syscalls csw irq GBfree5.43 0.00 4.20 0.00 3313143 33 84.96 5434214 1900162 2656 245.515.43 0.00 4.20 0.00 3308527 33 85.24 5439695 1809382 2521 245.515.42 0.00 4.19 0.00 3316778 33 87.54 5416028 1805835 2256 245.515.42 0.00 4.19 0.00 3317673 33 90.44 5426044 1763056 2332 245.515.42 0.00 4.19 0.00 3314839 33 88.11 5435732 1792218 2499 245.525.44 0.00 4.19 0.00 3293228 33 91.84 5426301 1668597 2121 245.52Similarly, netperf reports 230Mb/s before the patch, and 270Mb/s after the patchReviewed by: gallatinSponsored by: Limelight NetworksDifferential Revision: https://reviews.freebsd.org/D15366
Revert r327828, r327949, r327953, r328016-r328026, r328041:Uses of mallocarray(9).The use of mallocarray(9) has rocketed the required swap to build FreeBSD.This is likely caused by the allocation
Revert r327828, r327949, r327953, r328016-r328026, r328041:Uses of mallocarray(9).The use of mallocarray(9) has rocketed the required swap to build FreeBSD.This is likely caused by the allocation size attributes which put extra pressureon the compiler.Given that most of these checks are superfluous we have to choose betterwhere to use mallocarray(9). We still have more uses of mallocarray(9) buthopefully this is enough to bring swap usage to a reasonable level.Reported by: woschPR: 225197
dev: make some use of mallocarray(9).Focus on code where we are doing multiplications within malloc(9). None ofthese is likely to overflow, however the change is still useful as somestatic checke
dev: make some use of mallocarray(9).Focus on code where we are doing multiplications within malloc(9). None ofthese is likely to overflow, however the change is still useful as somestatic checkers can benefit from the allocation attributes we use formallocarray.This initial sweep only covers malloc(9) calls with M_NOWAIT. No goodreason but I started doing the changes before r327796 and at that time itwas convenient to make sure the sorrounding code could handle NULL values.
Enable i386 build of the Cavium LiquidIO driver (lio) module.Submitted by: [email protected] (Prasad V Kanneganti)MFC after: 1 weekSponsored by: Cavium NetworksDifferential Revision: https:
Enable i386 build of the Cavium LiquidIO driver (lio) module.Submitted by: [email protected] (Prasad V Kanneganti)MFC after: 1 weekSponsored by: Cavium NetworksDifferential Revision: https://reviews.freebsd.org/D12415
The diff is the initial submission of Cavium Liquidio 2350/2360 10/25GIntelligent NIC driver.The submission conconsists of firmware binary file and driver sources.Submitted by: pkanneganti@caviu
The diff is the initial submission of Cavium Liquidio 2350/2360 10/25GIntelligent NIC driver.The submission conconsists of firmware binary file and driver sources.Submitted by: [email protected] (Prasad V Kanneganti)Relnotes: YesSponsored by: Cavium NetworksDifferential Revision: https://reviews.freebsd.org/D11927