ichwd: Add Atom C3000 watchdog ID.MFC after: 3 daysSponsored by: Juniper Networks, Inc
Extract eventfilter declarations to sys/_eventfilter.hThis allows replacing "sys/eventfilter.h" includes with "sys/_eventfilter.h"in other header files (e.g., sys/{bus,conf,cpu}.h) and reduces hea
Extract eventfilter declarations to sys/_eventfilter.hThis allows replacing "sys/eventfilter.h" includes with "sys/_eventfilter.h"in other header files (e.g., sys/{bus,conf,cpu}.h) and reduces headerpollution substantially.EVENTHANDLER_DECLARE and EVENTHANDLER_LIST_DECLAREs were moved out of .cfiles into appropriate headers (e.g., sys/proc.h, powernv/opal.h).As a side effect of reduced header pollution, many .c files and headers nolonger contain needed definitions. The remainder of the patch addressesadding appropriate includes to fix those files.LOCK_DEBUG and LOCK_FILE_LINE_ARG are moved to sys/_lock.h, as required bysys/mutex.h since r326106 (but silently protected by header pollution priorto this change).No functional change (intended). Of course, any out of tree modules thatrelied on header pollution for sys/eventhandler.h, sys/lock.h, orsys/mutex.h inclusion need to be fixed. __FreeBSD_version has been bumped.
show more ...
ichwd: add a few assertions about tco_versionThose should ensure correctness of ichwd_find_ich_lpc_bridge() andichwd_find_ich_lpc_bridge() as well as make it easier for both humansand static anal
ichwd: add a few assertions about tco_versionThose should ensure correctness of ichwd_find_ich_lpc_bridge() andichwd_find_ich_lpc_bridge() as well as make it easier for both humansand static analyzers to see the relation between tco_version and ich andsmb variables in ichwd_identify().Reported by: CoverityCID: 1396314, 1396317MFC after: 10 days
ichwd: add Sunrise Point-LP IDSubmitted by: Tetsuya Uemura <[email protected]>Tested by: Tetsuya Uemura <[email protected]>MFC after: 2 weeksRelnotes: maybe
ichwd: add support for clearing No Reboot bit in TCOv4This is based on a patch developed byTetsuya Uemura <[email protected]>.Many thanks!Submitted by: Tetsuya Uemura <[email protected]
ichwd: add support for clearing No Reboot bit in TCOv4This is based on a patch developed byTetsuya Uemura <[email protected]>.Many thanks!Submitted by: Tetsuya Uemura <[email protected]> (earlier version)Tested by: Tetsuya Uemura <[email protected]>MFC after: 2 weeks
ichwd: add support for TCO watchdog timer in Lewisburg PCH (C620)The change is based on public documents listed below as well as Linuxchanges and the code developed by Kostik.The documents:- In
ichwd: add support for TCO watchdog timer in Lewisburg PCH (C620)The change is based on public documents listed below as well as Linuxchanges and the code developed by Kostik.The documents:- Intel® C620 Series Chipset Platform Controller Hub Datasheet- Intel® 100 Series and Intel® C230 Series Chipset Family Platform Controller Hub (PCH) Datasheet - Volume 2 of 2Interesting Linux commits:- https://github.com/torvalds/linux/commit/9424693035a57961a8eb09e96aab315a7096535d- https://github.com/torvalds/linux/commit/2a7a0e9bf7b32e838d873226808ab8a6c00148f7The peculiarity of the new chipsets is that the watchdog resources areconfigured in PCI registers of SMBus controller and Power Managementfunction as opposed to the LPC bridge. I took a simplistic approach ofquerying the resources from the respective PCI devices. ichwd is stilla device on isa bus. The PCI devices are found by their slot andfunction defined in the datasheets as siblings of the upstream LPCbridge.There are some shortcuts and missing features.First of all, I have not implemented the functionality required to clearthe no-reboot bit. That would require writing to a special PCIconfiguration register of a hidden / invisible PCI device after whichthe device would start responding to accesses to other registers. Theno-reboot bit was not set on my test hardware, so I decided to leave itshandling for the later time.Also, I did not try to handle the case where the watchdog resources arenot configured by the hardware as well as the case where ACPI definedoperational region conflicts with the watchdog resources. My testsystem did not have either of those problem, so, again, I decided toleave those cases until later.See this Linux commit for some details of the ACPI problem:https://github.com/torvalds/linux/commit/a7ae81952cdab56a1277bd2f9ed7284c0f575120Finally, I have added only the PCI ID found on my test system. I thinkthat more IDs can be added as the change gets tested.Tested on Dell PowerEdge R740.PR: 222079Reviewed by: mav, kibMFC after: 3 weeksRelnotes: maybeSponsored by: PanzuraDifferential Revision: https://reviews.freebsd.org/D17585
sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - error
sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - errorprone - task.The Software Package Data Exchange (SPDX) group provides a specificationto make it easier for automated tools to detect and summarize well knownopensource licenses. We are gradually adopting the specification, notingthat the tags are considered only advisory and do not, in any way,superceed or replace the license texts.
Fix typo, TC0->TCO.Submitted by: jhbMFC after: 1 week
Add definitions of (new) bits for TCO registers from theLewisburg/Sunrise Point documentation.Sponsored by: The FreeBSD FoundationMFC after: 1 week
Style: tab after #define.Sponsored by: The FreeBSD FoundationMFC after: 1 week
Add explicit check for PCI bus to r321720.Reported by: jhbMFC after: 6 days
Attach ichwd(4) only to ISA bus of the LPC bridge.Resource allocation for parent device does not look good by itself, butattempt to allocate them for unrelated device just does not end up good.On
Attach ichwd(4) only to ISA bus of the LPC bridge.Resource allocation for parent device does not look good by itself, butattempt to allocate them for unrelated device just does not end up good.On Asus X99-E WS/USB3.1 system reporting ISA bridge via both PCI and ACPIthis reported to cause kernel panic on shutdown due to messed resources:https://bugs.freenas.org/issues/25237.MFC after: 1 week
Fixed TCO v3 tick convertTCO v3's internal timer is stored as seconds.Submitted by: Denir Li <[email protected]>Pull Request: https://github.com/freebsd/freebsd/pull/51Pull Requ
Fixed TCO v3 tick convertTCO v3's internal timer is stored as seconds.Submitted by: Denir Li <[email protected]>Pull Request: https://github.com/freebsd/freebsd/pull/51Pull Request: https://github.com/freebsd/freebsd/pull/52
Unify ichwd(4) attachment messages in dmesg.MFC after: 2 weeks
Add ichwd TCO version 3 support (Bay Trail / Rangeley...)Reviewed by: jhbObtained from: Cas-wellSponsored by: Stormshield
Actually recognize all Intel Lynx Point devices we have device IDs for.PR: 195851Submitted by: [email protected]MFC after: 1 week
Add bunch of PCI IDs of Intel Wildcat Point (9 Series) chipsets.MFC after: 1 week
Add new Coleto Creek device support: SATA, SMBus, and Watchdog devices.MFC after: 1 week
Don't log a message when the watchdog is reloaded. It's not useful to do soand these messages flood the log when bootverbose is enabled.Approved by: rstone (co-mentor)
Add support for new Intel Lynx Point PCH - Watchdog Timer Device IDs
Remove use of explicit bus space tags and handles and use methods thatoperate on resource objects instead.MFC after: 1 week
Fix a bug in ichwd(4) which prevents it from beig enabled if the newtimeout is the same timeout.Submitted by: Dmitrij Tejblum <tejblum yandex-team.ru>PR: kern/139604MFC after: 2 weeksApproved
Fix a bug in ichwd(4) which prevents it from beig enabled if the newtimeout is the same timeout.Submitted by: Dmitrij Tejblum <tejblum yandex-team.ru>PR: kern/139604MFC after: 2 weeksApproved by: re (kib)
Chipset support for the new Intel Panther Point PCH, thanksto Seth Heasley for preparing the changes.
Add missing bit in r221015.Sponsored by: Sandvine IncorporatedReviewed by: desMFC after: 1 weekX-MFC: r221015
Don't assume that SMI are enabled when attaching ichwd and then docorrect unwind based on former state.Sponsored by: Sandvine IncorporatedReviewed by: desMFC after: 1 week
123