asmc: clean up empty lines in .c and .h files

asmc(4): Handle errors from asmc_key_read() properly.

asmc_key_read() returns only 0 and 1, some callers were checking
incorrectly for failure.

PR: 248939
Submitted by: Tong Zhang <ztong0001@gmail

asmc(4): Handle errors from asmc_key_read() properly.

asmc_key_read() returns only 0 and 1, some callers were checking
incorrectly for failure.

PR: 248939
Submitted by: Tong Zhang <[email protected]>
MFC after: 1 week

show more ...

asmc(4): Add support for MacBook7,1.

PR: 248693
Submitted by: [email protected]
MFC after: 1 week

Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are
still not MPSAFE (or already are but aren’t properly mark

Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)

r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are
still not MPSAFE (or already are but aren’t properly marked).
Use it in preparation for a general review of all nodes.

This is non-functional change that adds annotations to SYSCTL_NODE and
SYSCTL_PROC nodes using one of the soon-to-be-required flags.

Mark all obvious cases as MPSAFE. All entries that haven't been marked
as MPSAFE before are by default marked as NEEDGIANT

Approved by: kib (mentor, blanket)
Commented by: kib, gallatin, melifaro
Differential Revision: https://reviews.freebsd.org/D23718

show more ...

asmc: Add support for Mac mini 2,1

PR: 235798
Submitted by: Trev <[email protected]>
Reported by: Trev <[email protected]>
MFC after: 1 week

asmc: Add support for Mac mini 4,1 (Mid-2010)

MFC after: 1 week

asmc: Patch to add MacBook Pro 9,2 support

PR: 211513
Submitted by: William Theesfeld Jr <[email protected]>
Reported by: William Theesfeld Jr <[email protected]>
MFC after: 1 week

asmc: Add support for MacPro1,1

PR: 203431
Submitted by: [email protected] & [email protected]
Reported by: [email protected]
MFC after: 1 week

asmc: Add support for mid-2011 Macmini 5,2

PR: 225911
Submitted by: trev <[email protected]>
Reported by: trev <[email protected]>
MFC after: 1 week

asmc: Add Support for Macbook Pro 8,1

PR: 217505
Submitted by: John O. Brickley <[email protected]>, updated by Maciej Pasternacki <[email protected]>
Reported by: John O. Brickley <ob

asmc: Add Support for Macbook Pro 8,1

PR: 217505
Submitted by: John O. Brickley <[email protected]>, updated by Maciej Pasternacki <[email protected]>
Reported by: John O. Brickley <[email protected]>
MFC after: 1 week

show more ...

asmc: Add Support for MacBookAir 7,1 and 7,2

PR: 226172
Submitted by: James Wright <[email protected]>
Reported by: James Wright <[email protected]>
MFC after: 1 week
Differ

asmc: Add Support for MacBookAir 7,1 and 7,2

PR: 226172
Submitted by: James Wright <[email protected]>
Reported by: James Wright <[email protected]>
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D18396

show more ...

Distinguish _CID match and _HID match and make lower priority probe
when _CID match.

Reviewed by: jhb, imp
Differential Revision:https://reviews.freebsd.org/D16468

Yank crufty INTR_FILTER option

It was introduced to the tree in r169320 and r169321 in May 2007.

It never got much use and never became a kernel default. The code
duplicates the default path quite

Yank crufty INTR_FILTER option

It was introduced to the tree in r169320 and r169321 in May 2007.

It never got much use and never became a kernel default. The code
duplicates the default path quite a bit, with slight modifications. Just
yank out the cruft. Whatever goals were being aimed for can probably be met
within the existing framework, without a flag day option.

Mostly mechanical change: 'unifdef -m -UINTR_FILTER'.

Reviewed by: mmacy
Sponsored by: Dell EMC Isilon
Differential Revision: https://reviews.freebsd.org/D15546

show more ...

sys/dev: further adoption of SPDX licensing ID tags.

Mainly focus on files that use BSD 2-Clause license, however the tool I
was using misidentified many licenses so this was mostly a manual - error

sys/dev: further adoption of SPDX licensing ID tags.

Mainly focus on files that use BSD 2-Clause license, however the tool I
was using misidentified many licenses so this was mostly a manual - error
prone - task.

The Software Package Data Exchange (SPDX) group provides a specification
to make it easier for automated tools to detect and summarize well known
opensource licenses. We are gradually adopting the specification, noting
that the tags are considered only advisory and do not, in any way,
superceed or replace the license texts.

show more ...

[asmc] Add support for MacBook Pro 11,2

This patch will add support for MacBookPro 11.2.
For the macros, the MBP11_* macros (for the existing MacBookPro11.3) did not
match so they have been renamed

[asmc] Add support for MacBook Pro 11,2

This patch will add support for MacBookPro 11.2.
For the macros, the MBP11_* macros (for the existing MacBookPro11.3) did not
match so they have been renamed to MBP113_* and a new MBP112_* has been
added (modified copy of MBP11_*).

Some trailing whitespaces may have been removed automatically.

PR: kern/214836
Obtained from: Johannes Lundberg <[email protected]

show more ...

[asmc] Add support for MacBookPro5,1

Tested by: Johannes Lundberg <[email protected]>
PR: kern/209179
Submitted by: Thomas Brierley <[email protected]>

sys/dev: minor spelling fixes.

Most affect comments, very few have user-visible effects.

[asmc] add support for more models and restore keyboard backlight after resume.

This patch adds support for restoring backlight after resume and adds models
Macbook3,1
MacbookAir5,1
MacbookAir5,2

I

[asmc] add support for more models and restore keyboard backlight after resume.

This patch adds support for restoring backlight after resume and adds models
Macbook3,1
MacbookAir5,1
MacbookAir5,2

It also incorporates fixes for bug #175260, bug #203610 and bug #203512
so those can be closed if this patch is applied.

PR: kern/209156
PR: kern/175260
PR: kern/203610
PR: kern/203512
Submitted by: Johannes Lundberg <[email protected]>

show more ...

Fix undefined behavior when using asmc_fan_getstring()

It was returning a pointer to stack-allocated memory, so make the
allocation at the caller instead.

Found by: clang static analyzer
Coverity:

Fix undefined behavior when using asmc_fan_getstring()

It was returning a pointer to stack-allocated memory, so make the
allocation at the caller instead.

Found by: clang static analyzer
Coverity: CID 1245774
Reviewed by: ed, rpaulo
Review URL: https://reviews.freebsd.org/D4740

show more ...

The SYSCTL data pointers can come from userspace and must not be
directly accessed. Although this will work on some platforms, it can
throw an exception if the pointer is invalid and then panic the k

The SYSCTL data pointers can come from userspace and must not be
directly accessed. Although this will work on some platforms, it can
throw an exception if the pointer is invalid and then panic the kernel.

Add a missing SYSCTL_IN() of "SCTP_BASE_STATS" structure.

MFC after: 3 days
Sponsored by: Mellanox Technologies

show more ...

Follow up to r225617. In order to maximize the re-usability of kernel code
in userland rename in-kernel getenv()/setenv() to kern_setenv()/kern_getenv().
This fixes a namespace collision with libc sy

Follow up to r225617. In order to maximize the re-usability of kernel code
in userland rename in-kernel getenv()/setenv() to kern_setenv()/kern_getenv().
This fixes a namespace collision with libc symbols.

Submitted by: kmacy
Tested by: make universe

show more ...

Improvements to asmc(4):

1. changed the code so that 2**16 keys are supported
2. changed the number of possible fans in a system from 2 to 6
3. added write support for some fan sysctls
4. added a ne

Improvements to asmc(4):

1. changed the code so that 2**16 keys are supported
2. changed the number of possible fans in a system from 2 to 6
3. added write support for some fan sysctls
4. added a new sysctl which shows the ID of the fan
5. added four more apple models with their temperature keys
6. changed the maxnumber of temperature keys from 36 to 80
7. replaced several fixed buf sizes to sizeof buf

Obtained from: Denis Ahrens denis at h3q.com
MFC after: 4 weeks

show more ...

Add support to asmc(4) for Macmini 3,1.

PR: 190195
Submitted by: fbsdbugs2 sentry.org
MFC after: 1 week
Relnotes: yes

Give device_printf format string to pacify clang warning.

This isn't functionally identical. In some cases a hint to disable
unit 0 would in fact disable all units.

This reverts r241856

Approved by: cperciva (implicit)