Remove "All Rights Reserved" from FreeBSD Foundation sys/ copyrightsThese ones were unambiguous cases where the Foundation was the onlylisted copyright holder (in the associated license block).S
Remove "All Rights Reserved" from FreeBSD Foundation sys/ copyrightsThese ones were unambiguous cases where the Foundation was the onlylisted copyright holder (in the associated license block).Sponsored by: The FreeBSD Foundation(cherry picked from commit 9feff969a01044c3083b552f06f7eb6416bc0524)
show more ...
armv8crypto: note derivation in armv8_crypto_wrap.cThis file inherits some boilerplate and structure from the analogousfile in aesni(4), aesni_wrap.c. Note the derivation and the copyrightholders
armv8crypto: note derivation in armv8_crypto_wrap.cThis file inherits some boilerplate and structure from the analogousfile in aesni(4), aesni_wrap.c. Note the derivation and the copyrightholders of that file.For example, the AES-XTS bits added in 4979620ece984 were ported fromaesni(4).Requested by: jmgReviewed by: imp, gnn(cherry picked from commit da45b462664148ff6f8adbe59847c6c06f295391)
armv8crypto: fix AES-XTS regression introduced by ed9b7f44Initialization of the XTS key schedule was accidentally droppedwhen adding AES-GCM support so all-zero schedule was used instead.This ren
armv8crypto: fix AES-XTS regression introduced by ed9b7f44Initialization of the XTS key schedule was accidentally droppedwhen adding AES-GCM support so all-zero schedule was used instead.This rendered previously created GELI partitions unusable.This change restores proper XTS key schedule initialization.Reported by: Peter Jeremy <[email protected]>MFC after: immediately(cherry picked from commit 748be78e60ccc4a26325a636347debb1f7e6749b)
armv8crypto: add missing newlineThe missing newline mildly garbles boot-time messages and this can betroublesome if you need those.Reported by: Mike Karels ([email protected])Reviewed By: gonzo
armv8crypto: add missing newlineThe missing newline mildly garbles boot-time messages and this can betroublesome if you need those.Reported by: Mike Karels ([email protected])Reviewed By: gonzo(cherry picked from commit 530d38441d55b7ac62ebae6ac8ea76903a4a3b0c)
armv8crypto: Extract GCM state into a structureThis makes it easier to refactor the GCM code to operate oncrypto_buffer_cursors rather than plain contiguous buffers, with the aimof minimizing the
armv8crypto: Extract GCM state into a structureThis makes it easier to refactor the GCM code to operate oncrypto_buffer_cursors rather than plain contiguous buffers, with the aimof minimizing the amount of copying and zeroing done today.No functional change intended.Reviewed by: jhbSponsored by: Ampere ComputingSubmitted by: Klara, Inc.Differential Revision: https://reviews.freebsd.org/D28500(cherry picked from commit 7509b677b413b9551c15b483ec2ed9ce655d2455)
armv8crypto: Fix some edge cases in the AES-GCM implementation- We were only hashing up to the first 16 bytes of the AAD.- When computing the digest during decryption, handle the case where len
armv8crypto: Fix some edge cases in the AES-GCM implementation- We were only hashing up to the first 16 bytes of the AAD.- When computing the digest during decryption, handle the case where len == trailer, i.e., len < AES_BLOCK_LEN, properly.While here:- trailer is always smaller than AES_BLOCK_LEN, so remove a pair of unnecessary modulus operations.- Replace some byte-by-byte loops with memcpy() and memset() calls. In particular, zero the full block before copying a partial block into it since we do that elsewhere and it means that the memset() length is known at compile time.Reviewed by: jhbSponsored by: Ampere ComputingSubmitted by: Klara, Inc.Differential Revision: https://reviews.freebsd.org/D28501(cherry picked from commit 0dc7076037a87100060309f7179ef6a01f32f99e)
armv8crypto: add AES-GCM supportAdd support for AES-GCM using OpenSSL's accelerated routines.Reviewed by: jhbDifferential Revision: https://reviews.freebsd.org/D27454Sponsored by: Ampere Comput
armv8crypto: add AES-GCM supportAdd support for AES-GCM using OpenSSL's accelerated routines.Reviewed by: jhbDifferential Revision: https://reviews.freebsd.org/D27454Sponsored by: Ampere ComputingSubmitted by: Klara, Inc.Approved by: re (kib)(cherry picked from commit ed9b7f4414663703e0e9581a730c4bdfaca5687f)
armv8crypto: print a message on probe failureSimilar to the message printed by aesni(4), let the user know if thedriver is unsupported by their CPU.PR: 252543Reported by: gbeMFC after: 3 days
armv8crypto: print a message on probe failureSimilar to the message printed by aesni(4), let the user know if thedriver is unsupported by their CPU.PR: 252543Reported by: gbeMFC after: 3 daysSponsored by: The FreeBSD Foundation
armv8crypto: add AES-XTS supportA straightforward(ish) port from aesni(4). This implementation does notperform loop unrolling on the input blocks, so this is left as a futureperformance improveme
armv8crypto: add AES-XTS supportA straightforward(ish) port from aesni(4). This implementation does notperform loop unrolling on the input blocks, so this is left as a futureperformance improvement.Submitted by: Greg V <greg AT unrelenting.technology>Looks good: jhb, jmgTested by: mhorneDifferential Revision: https://reviews.freebsd.org/D21017
[armv8crypto] Fix cryptodev probe logic in armv8cryptoAdd missing break to prevent falling through to the default case statementand returning EINVAL for all session configs.Sponsored by: Ampere
[armv8crypto] Fix cryptodev probe logic in armv8cryptoAdd missing break to prevent falling through to the default case statementand returning EINVAL for all session configs.Sponsored by: Ampere ComputingSubmitted by: Klara, Inc.
Don't return errors from the cryptodev_process() method.The cryptodev_process() method should either return 0 if it hascompleted a request, or ERESTART to defer the request until later. Ifa requ
Don't return errors from the cryptodev_process() method.The cryptodev_process() method should either return 0 if it hascompleted a request, or ERESTART to defer the request until later. Ifa request encounters an error, the error should be reported viacrp_etype before completing the request via crypto_done().Fix a few more drivers noticed by asomers@ similar to the fix inr365389. This is an old bug, but went unnoticed since crypto requestsdid not start failing as a normal part of operation until digestverification was introduced which can fail requests with EBADMSG.PR: 247986Reported by: asomersSponsored by: Chelsio CommunicationsDifferential Revision: https://reviews.freebsd.org/D26361
Use zfree() instead of bzero() and free().These bzero's should have been explicit_bzero's.Reviewed by: cem, delphijSponsored by: Chelsio CommunicationsDifferential Revision: https://reviews.fre
Use zfree() instead of bzero() and free().These bzero's should have been explicit_bzero's.Reviewed by: cem, delphijSponsored by: Chelsio CommunicationsDifferential Revision: https://reviews.freebsd.org/D25437
Add a crypto capability flag for accelerated software drivers.Use this in GELI to print out a different message when acceleratedsoftware such as AESNI is used vs plain software crypto.While here
Add a crypto capability flag for accelerated software drivers.Use this in GELI to print out a different message when acceleratedsoftware such as AESNI is used vs plain software crypto.While here, simplify the logic in GELI a bit for determing which typeof crypto driver was chosen the first time by examining thecapabilities of the matched driver after a single call tocrypto_newsession rather than making separate calls with differentflags.Reviewed by: delphijSponsored by: Chelsio CommunicationsDifferential Revision: https://reviews.freebsd.org/D25126
Retire the CRYPTO_F_IV_GENERATE flag.The sole in-tree user of this flag has been retired, so remove thiscomplexity from all drivers. While here, add a helper routine driverscan use to read the c
Retire the CRYPTO_F_IV_GENERATE flag.The sole in-tree user of this flag has been retired, so remove thiscomplexity from all drivers. While here, add a helper routine driverscan use to read the current request's IV into a local buffer. Usethis routine to replace duplicated code in nearly all drivers.Reviewed by: cemSponsored by: NetflixDifferential Revision: https://reviews.freebsd.org/D24450
Refactor driver and consumer interfaces for OCF (in-kernel crypto).- The linked list of cryptoini structures used in session initialization is replaced with a new flat structure: struct crypto_
Refactor driver and consumer interfaces for OCF (in-kernel crypto).- The linked list of cryptoini structures used in session initialization is replaced with a new flat structure: struct crypto_session_params. This session includes a new mode to define how the other fields should be interpreted. Available modes include: - COMPRESS (for compression/decompression) - CIPHER (for simply encryption/decryption) - DIGEST (computing and verifying digests) - AEAD (combined auth and encryption such as AES-GCM and AES-CCM) - ETA (combined auth and encryption using encrypt-then-authenticate) Additional modes could be added in the future (e.g. if we wanted to support TLS MtE for AES-CBC in the kernel we could add a new mode for that. TLS modes might also affect how AAD is interpreted, etc.) The flat structure also includes the key lengths and algorithms as before. However, code doesn't have to walk the linked list and switch on the algorithm to determine which key is the auth key vs encryption key. The 'csp_auth_*' fields are always used for auth keys and settings and 'csp_cipher_*' for cipher. (Compression algorithms are stored in csp_cipher_alg.)- Drivers no longer register a list of supported algorithms. This doesn't quite work when you factor in modes (e.g. a driver might support both AES-CBC and SHA2-256-HMAC separately but not combined for ETA). Instead, a new 'crypto_probesession' method has been added to the kobj interface for symmteric crypto drivers. This method returns a negative value on success (similar to how device_probe works) and the crypto framework uses this value to pick the "best" driver. There are three constants for hardware (e.g. ccr), accelerated software (e.g. aesni), and plain software (cryptosoft) that give preference in that order. One effect of this is that if you request only hardware when creating a new session, you will no longer get a session using accelerated software. Another effect is that the default setting to disallow software crypto via /dev/crypto now disables accelerated software. Once a driver is chosen, 'crypto_newsession' is invoked as before.- Crypto operations are now solely described by the flat 'cryptop' structure. The linked list of descriptors has been removed. A separate enum has been added to describe the type of data buffer in use instead of using CRYPTO_F_* flags to make it easier to add more types in the future if needed (e.g. wired userspace buffers for zero-copy). It will also make it easier to re-introduce separate input and output buffers (in-kernel TLS would benefit from this). Try to make the flags related to IV handling less insane: - CRYPTO_F_IV_SEPARATE means that the IV is stored in the 'crp_iv' member of the operation structure. If this flag is not set, the IV is stored in the data buffer at the 'crp_iv_start' offset. - CRYPTO_F_IV_GENERATE means that a random IV should be generated and stored into the data buffer. This cannot be used with CRYPTO_F_IV_SEPARATE. If a consumer wants to deal with explicit vs implicit IVs, etc. it can always generate the IV however it needs and store partial IVs in the buffer and the full IV/nonce in crp_iv and set CRYPTO_F_IV_SEPARATE. The layout of the buffer is now described via fields in cryptop. crp_aad_start and crp_aad_length define the boundaries of any AAD. Previously with GCM and CCM you defined an auth crd with this range, but for ETA your auth crd had to span both the AAD and plaintext (and they had to be adjacent). crp_payload_start and crp_payload_length define the boundaries of the plaintext/ciphertext. Modes that only do a single operation (COMPRESS, CIPHER, DIGEST) should only use this region and leave the AAD region empty. If a digest is present (or should be generated), it's starting location is marked by crp_digest_start. Instead of using the CRD_F_ENCRYPT flag to determine the direction of the operation, cryptop now includes an 'op' field defining the operation to perform. For digests I've added a new VERIFY digest mode which assumes a digest is present in the input and fails the request with EBADMSG if it doesn't match the internally-computed digest. GCM and CCM already assumed this, and the new AEAD mode requires this for decryption. The new ETA mode now also requires this for decryption, so IPsec and GELI no longer do their own authentication verification. Simple DIGEST operations can also do this, though there are no in-tree consumers. To eventually support some refcounting to close races, the session cookie is now passed to crypto_getop() and clients should no longer set crp_sesssion directly.- Assymteric crypto operation structures should be allocated via crypto_getkreq() and freed via crypto_freekreq(). This permits the crypto layer to track open asym requests and close races with a driver trying to unregister while asym requests are in flight.- crypto_copyback, crypto_copydata, crypto_apply, and crypto_contiguous_subsegment now accept the 'crp' object as the first parameter instead of individual members. This makes it easier to deal with different buffer types in the future as well as separate input and output buffers. It's also simpler for driver writers to use.- bus_dmamap_load_crp() loads a DMA mapping for a crypto buffer. This understands the various types of buffers so that drivers that use DMA do not have to be aware of different buffer types.- Helper routines now exist to build an auth context for HMAC IPAD and OPAD. This reduces some duplicated work among drivers.- Key buffers are now treated as const throughout the framework and in device drivers. However, session key buffers provided when a session is created are expected to remain alive for the duration of the session.- GCM and CCM sessions now only specify a cipher algorithm and a cipher key. The redundant auth information is not needed or used.- For cryptosoft, split up the code a bit such that the 'process' callback now invokes a function pointer in the session. This function pointer is set based on the mode (in effect) though it simplifies a few edge cases that would otherwise be in the switch in 'process'. It does split up GCM vs CCM which I think is more readable even if there is some duplication.- I changed /dev/crypto to support GMAC requests using CRYPTO_AES_NIST_GMAC as an auth algorithm and updated cryptocheck to work with it.- Combined cipher and auth sessions via /dev/crypto now always use ETA mode. The COP_F_CIPHER_FIRST flag is now a no-op that is ignored. This was actually documented as being true in crypto(4) before, but the code had not implemented this before I added the CIPHER_FIRST flag.- I have not yet updated /dev/crypto to be aware of explicit modes for sessions. I will probably do that at some point in the future as well as teach it about IV/nonce and tag lengths for AEAD so we can support all of the NIST KAT tests for GCM and CCM.- I've split up the exising crypto.9 manpage into several pages of which many are written from scratch.- I have converted all drivers and consumers in the tree and verified that they compile, but I have not tested all of them. I have tested the following drivers: - cryptosoft - aesni (AES only) - blake2 - ccr and the following consumers: - cryptodev - IPsec - ktls_ocf - GELI (lightly) I have not tested the following: - ccp - aesni with sha - hifn - kgssapi_krb5 - ubsec - padlock - safe - armv8_crypto (aarch64) - glxsb (i386) - sec (ppc) - cesa (armv7) - cryptocteon (mips64) - nlmsec (mips64)Discussed with: cemRelnotes: yesSponsored by: Chelsio CommunicationsDifferential Revision: https://reviews.freebsd.org/D23677
Fix the armv8 crypto driver after r354170.Sponsored by: DARPA, AFRL
armv8crypto: add missing unlock for session (after r336439)Attempts to use cryptodev (e.g. tests at /usr/src/tests/sys/opencryptowith armv8crypto added to the module lists) were causing a panic.
armv8crypto: add missing unlock for session (after r336439)Attempts to use cryptodev (e.g. tests at /usr/src/tests/sys/opencryptowith armv8crypto added to the module lists) were causing a panic.Submitted by: Greg V <greg_unrelenting.technology>Differential Revision: https://reviews.freebsd.org/D21012
Extract eventfilter declarations to sys/_eventfilter.hThis allows replacing "sys/eventfilter.h" includes with "sys/_eventfilter.h"in other header files (e.g., sys/{bus,conf,cpu}.h) and reduces hea
Extract eventfilter declarations to sys/_eventfilter.hThis allows replacing "sys/eventfilter.h" includes with "sys/_eventfilter.h"in other header files (e.g., sys/{bus,conf,cpu}.h) and reduces headerpollution substantially.EVENTHANDLER_DECLARE and EVENTHANDLER_LIST_DECLAREs were moved out of .cfiles into appropriate headers (e.g., sys/proc.h, powernv/opal.h).As a side effect of reduced header pollution, many .c files and headers nolonger contain needed definitions. The remainder of the patch addressesadding appropriate includes to fix those files.LOCK_DEBUG and LOCK_FILE_LINE_ARG are moved to sys/_lock.h, as required bysys/mutex.h since r326106 (but silently protected by header pollution priorto this change).No functional change (intended). Of course, any out of tree modules thatrelied on header pollution for sys/eventhandler.h, sys/lock.h, orsys/mutex.h inclusion need to be fixed. __FreeBSD_version has been bumped.
OpenCrypto: Convert sessions to opaque handles instead of integersTrack session objects in the framework, and pass handles between theframework (OCF), consumers, and drivers. Avoid redundancy and
OpenCrypto: Convert sessions to opaque handles instead of integersTrack session objects in the framework, and pass handles between theframework (OCF), consumers, and drivers. Avoid redundancy and complexity inindividual drivers by allocating session memory in the framework andproviding it to drivers in ::newsession().Session handles are no longer integers with information encoded in varioushigh bits. Use of the CRYPTO_SESID2FOO() macros should be replaced with theappropriate crypto_ses2foo() function on the opaque session handle.Convert OCF drivers (in particular, cryptosoft, as well as myriad others) tothe opaque handle interface. Discard existing session tracking as much aspossible (quick pass). There may be additional code ripe for deletion.Convert OCF consumers (ipsec, geom_eli, krb5, cryptodev) to handle-styleinterface. The conversion is largely mechnical.The change is documented in crypto.9.Inspired byhttps://lists.freebsd.org/pipermail/freebsd-arch/2018-January/018835.html .No objection from: ae (ipsec portion)Reported by: jhb
Create an empty stdint.h for arm_neon.h to include.The armv8crypto module includes arm_neon.h for the compiler intrinsicfunctions. This includes the userland stdint.h file that doesn't exist inth
Create an empty stdint.h for arm_neon.h to include.The armv8crypto module includes arm_neon.h for the compiler intrinsicfunctions. This includes the userland stdint.h file that doesn't exist inthe kernel. Fix this by providing an empty stdint.h to be used when weinclude arm_neon.h.Sponsored by: DARPA, AFRLDifferential Revision: https://reviews.freebsd.org/D16254
Remove unused error return from API that cannot failNo implementation of fpu_kern_enter() can fail, and it was causing needlesserror checking boilerplate and confusion. Change the return code to v
Remove unused error return from API that cannot failNo implementation of fpu_kern_enter() can fail, and it was causing needlesserror checking boilerplate and confusion. Change the return code to void tomatch reality.(This trivial change took nine days to land because of the commit hook onsys/dev/random. Please consider removing the hook or otherwise lowering thebar -- secteam never seems to have free time to review patches.)Reported by: Lachlan McIlroy <Lachlan.McIlroy AT isilon.com>Reviewed by: delphijApproved by: secteam (delphij)Sponsored by: Dell EMC IsilonDifferential Revision: https://reviews.freebsd.org/D14380
Add accelerated AES with using the ARMv8 crypto instructions. This is basedon the AES-NI code, and modified as needed for use on ARMv8. When loadedthe driver will check the appropriate field in the
Add accelerated AES with using the ARMv8 crypto instructions. This is basedon the AES-NI code, and modified as needed for use on ARMv8. When loadedthe driver will check the appropriate field in the id_aa64isar0_el1register to see if AES is supported, and if so the probe function willsignal the driver should attach.With this I have seen up to 2000Mb/s from the cryptotest test with a singlethread on a ThunderX Pass 2.0.Reviewed by: impObtained from: ABT Systems LtdMFC after: 1 weekSponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.freebsd.org/D8297