ping: fix parsing of options including '4' and '6'ping uses a two-pass option parser. The first pass determines whetheripv4 or ipv6 is desired, and the second parses the rest of the options.But
ping: fix parsing of options including '4' and '6'ping uses a two-pass option parser. The first pass determines whetheripv4 or ipv6 is desired, and the second parses the rest of the options.But the first pass wrongly detects a '4' or '6' in an option's value asa request to use ipv6 or ipv6 respectively, for example in an invocationlike "ping -c6 1.2.3.4".Fix this confusion by including all options in the first round ofparsing, but ignoring those unrelated to ipv4/ipv6 selection.PR: 258048Reported by: [email protected]Submitted by: [email protected]MFC after: 2 weeksReviewed by: emasteDifferential Revision: https://reviews.freebsd.org/D32344(cherry picked from commit 9ce201f2ee3ca340032d9cc71d91a36b3b45a4c3)
show more ...
ICMP checksum test: Fix for big endianThe in_cksum tests originally tried to simulate a BE environment byswapping the byte order of the input. But that's overcomplicated, anddidn't actually work
ICMP checksum test: Fix for big endianThe in_cksum tests originally tried to simulate a BE environment byswapping the byte order of the input. But that's overcomplicated, anddidn't actually work on real BE hardware. The correct testing strategyis just to test on the native endianness, and run the tests in both BEand LE environments.Submitted by: Renato Riolino <[email protected]>Reviewed By: asomersMFC after: 2 weeksDifferential Revision: https://reviews.freebsd.org/D23193
ping: add a ping6 hard link for backwards compatibilityWhen invoked as "ping6", ping will now attempt to use ICMPv6 for hostnamesthat resolve both IPv4 and IPv6 addresses.Reviewed by: bz, manuM
ping: add a ping6 hard link for backwards compatibilityWhen invoked as "ping6", ping will now attempt to use ICMPv6 for hostnamesthat resolve both IPv4 and IPv6 addresses.Reviewed by: bz, manuMFC-With: r368045Differential Revision: https://reviews.freebsd.org/D27384
Merge ping6 to pingThere is now a single ping binary, which chooses to use ICMP or ICMPv4based on the -4 and -6 options, and the format of the address.Submitted by: Ján Sučan <[email protected]
Merge ping6 to pingThere is now a single ping binary, which chooses to use ICMP or ICMPv4based on the -4 and -6 options, and the format of the address.Submitted by: Ján Sučan <[email protected]>Sponsored by: Google LLC (Google Summer of Code 2019)MFC after: NeverDifferential Revision: https://reviews.freebsd.org/D21377
Do a sweep and remove most WARNS=6 settingsRepeating the default WARNS here makes it slightly more difficult toexperiment with default WARNS changes, e.g. if we did something absolutelybananas an
Do a sweep and remove most WARNS=6 settingsRepeating the default WARNS here makes it slightly more difficult toexperiment with default WARNS changes, e.g. if we did something absolutelybananas and introduced a WARNS=7 and wanted to try lifting the default tothat.Drop most of them; there is one in the blake2 kernel module, but I suspectit should be dropped -- the default WARNS in the rest of the build doesn'tcurrently apply to kernel modules, and I haven't put too much thought intowhether it makes sense to make it so.
ping: By default, don't reverse lookup IP addressesping's default is now not to attempt reverse DNS lookups. The -H flag willenable them. This change is not quite a reversion of r351330. That c
ping: By default, don't reverse lookup IP addressesping's default is now not to attempt reverse DNS lookups. The -H flag willenable them. This change is not quite a reversion of r351330. That changemade the happy path and error path do reverse lookups consistently; thischange changes the default for both paths.Submitted by: Ján Sučan <[email protected]>Discussed with: cemMFC after: 2 weeksMFC-With: 351330Sponsored by: Google LLC (Google Summer of Code 2019)Differential Revision: https://reviews.freebsd.org/D21364
ping: add a basic functional testSubmitted by: Ján Sučan <[email protected]>MFC after: 2 weeksSponsored by: Google, inc. (Google Summer of Code 2019)Differential Revision: https://reviews.freeb
ping: add a basic functional testSubmitted by: Ján Sučan <[email protected]>MFC after: 2 weeksSponsored by: Google, inc. (Google Summer of Code 2019)Differential Revision: https://reviews.freebsd.org/D21289
ping: Add tests of the Internet checksum functionSubmitted by: Ján Sučan <[email protected]>MFC after: 2 weeksSponsored by: Google LLC (Google Summer of Code 2019)Differential Revision: https:/
ping: Add tests of the Internet checksum functionSubmitted by: Ján Sučan <[email protected]>MFC after: 2 weeksSponsored by: Google LLC (Google Summer of Code 2019)Differential Revision: https://reviews.freebsd.org/D21340