| 568f805c | 03-Apr-2022 |
Kyle Evans <[email protected]> |
bectl: push space-in-name check down into libbe
This check was previously in `create` only, not applying to renames. It should really be applied at the libbe level, so that we can avoid writing abo
bectl: push space-in-name check down into libbe
This check was previously in `create` only, not applying to renames. It should really be applied at the libbe level, so that we can avoid writing about this restriction over and over again.
While we're here: `bectl rename` always succeeds, even when it doesn't. Start returning the error.
Approved by: re (gjb) Reported By: Christian McDonald <cmcdonald netgate com>
(cherry picked from commit dadb9c70938c4ae2c260f6af65752c67ac752284) (cherry picked from commit 227e52a9c0b0be9656757fec47a2648f5619bf67)
show more ...
|
| 99931db6 | 31-Mar-2022 |
Kyle Evans <[email protected]> |
libbe: fix be_mounted_at() with props after bootonce
propinfo.bootonce was filled with garbage, leading to a segfault later during prop building. Initialize it to NULL.
Approved by: re (gjb)
(che
libbe: fix be_mounted_at() with props after bootonce
propinfo.bootonce was filled with garbage, leading to a segfault later during prop building. Initialize it to NULL.
Approved by: re (gjb)
(cherry picked from commit d155d8e138563c0b39c658684e6a4fe6e2e36f8a) (cherry picked from commit 6ce8e35cead46048d9ae3c1dabafe1ef4ed26f97)
show more ...
|
| 513bd2fc | 18-Oct-2020 |
Kyle Evans <[email protected]> |
libbe(3): document be_snapshot()
While toying around with lua bindings for libbe(3), I discovered that I apparently never documented this, despite having documented be_is_auto_snapshot_name that ref
libbe(3): document be_snapshot()
While toying around with lua bindings for libbe(3), I discovered that I apparently never documented this, despite having documented be_is_auto_snapshot_name that references it.
MFC after: 1 week
show more ...
|
| 1dc85563 | 16-Oct-2019 |
Kyle Evans <[email protected]> |
libbe(3): Fix destroy of imported BE w/ AUTOORIGIN
Imported BE, much like the activated BE, will not have an origin that we can fetch/examine for destruction. be_destroy should not return BE_ERR_NOO
libbe(3): Fix destroy of imported BE w/ AUTOORIGIN
Imported BE, much like the activated BE, will not have an origin that we can fetch/examine for destruction. be_destroy should not return BE_ERR_NOORIGIN for failure to get the origin property for BE_DESTROY_AUTOORIGIN, because we don't really know going into it that there's even an origin to be destroyed.
BE_DESTROY_NEEDORIGIN has been renamed to BE_DESTROY_WANTORIGIN because only a subset of it *needs* the origin, so 'need' is too strong of verbiage.
This was caught by jenkins and the bectl tests, but kevans failed to run the bectl tests prior to commit.
Reported by: lwhsu
show more ...
|