Capsicumize nm(1).

Reviewed by: emaste
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D21107

nm: Adjust argc and argv in get_opt().

This refactoring makes it slightly easier to capsicumize nm(1).

Discussed with: emaste
MFC after: 1 week
Sponsored by: The FreeBSD Foundation

elftoolchain nm(1): Initialize allocated memory before use

In out of memory scenarios (where one of these allocations failed but
other(s) did not), nm(1) could reference the uninitialized value of t

elftoolchain nm(1): Initialize allocated memory before use

In out of memory scenarios (where one of these allocations failed but
other(s) did not), nm(1) could reference the uninitialized value of these
allocations (undefined behavior).

Always initialize any successful allocations as the most expedient
resolution of the issue. However, I would encourage upstream elftoolchain
contributors to clean up the error path to just abort immediately, rather
than proceeding sloppily when one allocation fails.

Reported by: Coverity
Sponsored by: Dell EMC Isilon

show more ...

nm: avoid crash in print_lineno if func->name is NULL

This can occur when DW_AT_specification is used to refer to another DIE
that provides the actual DW_AT_name string. For example:

< 3><0x0000008

nm: avoid crash in print_lineno if func->name is NULL

This can occur when DW_AT_specification is used to refer to another DIE
that provides the actual DW_AT_name string. For example:

< 3><0x00000086> DW_TAG_subprogram
DW_AT_name PrettyStackTraceEntry
...
< 1><0x00002cf4> DW_TAG_subprogram
DW_AT_specification <0x00000086>

We will need to add support for DW_AT_specification, but in the interim
we should not segfault.

Obtained from: Elftoolchain (r3170)
Sponsored by: The FreeBSD Foundation

show more ...

nm: Accept long option --extern-only for -g

Submitted by: jkim

Fix elftoolchain tools in-tree build

* make variables static
* add header for uint*_t typedefs