DIRDEPS_BUILD: Update dependencies.Sponsored by: Dell EMC Isilon
Fix a (false positive?) Argument cannot be negative coverity defect.Rather than guarding close(fd) with an fd >= 0 test and setting fdto -1 when it is closed to avoid a potential double-close, jus
Fix a (false positive?) Argument cannot be negative coverity defect.Rather than guarding close(fd) with an fd >= 0 test and setting fdto -1 when it is closed to avoid a potential double-close, justmove the close() call after the conditional "goto make_token". Thismoves the close() call totally outside the loop to avoid thepossibility of calling it twice. This should also prevent a Coveritywarning about checking fd for validity after it was previously passedto read().Reported by: CoverityCID: 1355335MFC after: 1 weekX-MFC with: r299484
show more ...
random(6): Fix double-closeIn the case where a file lacks a trailing newline, there is some "evil" code toreverse goto the tokenizing code ("make_token") for the final token in thefile. In this
random(6): Fix double-closeIn the case where a file lacks a trailing newline, there is some "evil" code toreverse goto the tokenizing code ("make_token") for the final token in thefile. In this case, 'fd' is closed more than once. Use a negative sentinelvalue to guard close(2), preventing the double close.Ideally, this code would be restructured to avoid this ugly construction.Reported by: CoverityCID: 1006123Sponsored by: EMC / Isilon Storage Division
Final step of eliminating the "games" distribution: Merge src/games(or what's left of it, at least) into src/usr.bin.This change will not be MFCed.Discussed at: EuroBSDCon 2014Committed from:
Final step of eliminating the "games" distribution: Merge src/games(or what's left of it, at least) into src/usr.bin.This change will not be MFCed.Discussed at: EuroBSDCon 2014Committed from: EuroBSDCon 2015