MFC r340485:Add regression tests for r340313 and r340483.
MFC r340484:Rename the SO_REUSEPORT_LB test file to be consistent with other tests.
Add a couple of basic regression tests for SO_REUSEPORT_LB.Reviewed by: asomersApproved by: re (kib)Sponsored by: The FreeBSD FoundationDifferential revision: https://reviews.freebsd.org/D17110
DIRDEPS_BUILD: Update dependencies.Sponsored by: Dell EMC Isilon
tests/sys/netinet/fibs_test: skip selected tests when firewalls are enabledSome tests send packets over epair(4) interfaces. Firewalls can causespurious failures.Reviewed by: ngieMFC after: 3 w
tests/sys/netinet/fibs_test: skip selected tests when firewalls are enabledSome tests send packets over epair(4) interfaces. Firewalls can causespurious failures.Reviewed by: ngieMFC after: 3 weeksSponsored by: Spectra Logic CorpDifferential Revision: https://reviews.freebsd.org/D11917
show more ...
Make test scripts under tests/... non-executableExecutable bits should be set at install time instead of in the repo.Setting executable bits on files triggers false positives with Phabricator.MF
Make test scripts under tests/... non-executableExecutable bits should be set at install time instead of in the repo.Setting executable bits on files triggers false positives with Phabricator.MFC after: 2 months
Initial `srv` before using it in bind(2)MFC after: 3 daysReported by: CoverityCID: 1357526Sponsored by: Dell EMC Isilon
Fix back-to-back runs of sys/netinet/fibs_test;slaac_on_nondefault_fib6This test was failing if run twice because rtadvd takes too long to die.The rtadvd process from the first run was still runni
Fix back-to-back runs of sys/netinet/fibs_test;slaac_on_nondefault_fib6This test was failing if run twice because rtadvd takes too long to die.The rtadvd process from the first run was still running when thesecond run created its interfaces. The solution is to use SIGKILL duringthe cleanup instead of SIGTERM so rtadvd will die faster.While I'm here, randomize the addresses used for the test, which makes bugslike this easier to spot, and fix the cleanup order to be the opposite ofthe setup orderPR: 217871MFC after: 18 daysX-MFC-With: 315458Sponsored by: Spectra Logic Corp
Constrain IPv6 routes to single FIBs when net.add_addr_allfibs=0sys/netinet6/icmp6.c Use the interface's FIB for source address selection in ICMPv6 error responses.sys/netinet6/in6.c In in6_ne
Constrain IPv6 routes to single FIBs when net.add_addr_allfibs=0sys/netinet6/icmp6.c Use the interface's FIB for source address selection in ICMPv6 error responses.sys/netinet6/in6.c In in6_newaddrmsg, announce arrival of local addresses on the interface's FIB only. In in6_lltable_rtcheck, use a per-fib ND6 cache instead of a single cache.sys/netinet6/in6_src.c In in6_selectsrc, use the caller's fib instead of the default fib. In in6_selectsrc_socket, remove a superfluous check.sys/netinet6/nd6.c In nd6_lle_event, use the interface's fib for routing socket messages. In nd6_is_new_addr_neighbor, check all FIBs when trying to determine whether an address is a neighbor. Also, simplify the code for point to point interfaces.sys/netinet6/nd6.hsys/netinet6/nd6.csys/netinet6/nd6_rtr.c Make defrouter_select fib-aware, and make all of its callers pass in the interface fib.sys/netinet6/nd6_nbr.c When inputting a Neighbor Solicitation packet, consider the interface fib instead of the default fib for DAD. Output NS and Neighbor Advertisement packets on the correct fib.sys/netinet6/nd6_rtr.c Allow installing the same host route on different interfaces in different FIBs. If rt_add_addr_allfibs=0, only install or delete the prefix route on the interface fib.tests/sys/netinet/fibs_test.sh Clear some expected failures, but add a skip for the newly revealed BUG217871.PR: 196361Submitted by: Erick Turnquist <[email protected]>Reported by: Jason Healy <[email protected]>Reviewed by: asomersMFC after: 3 weeksSponsored by: Spectra Logic CorpDifferential Revision: https://reviews.freebsd.org/D9451
Add an ATF test for IPv6 SLAAC with multiple fibsTests that an interface can get a SLAAC address and that it inserts itsroutes into the correct fib. Does not test anything to do with NDP.PR: 19
Add an ATF test for IPv6 SLAAC with multiple fibsTests that an interface can get a SLAAC address and that it inserts itsroutes into the correct fib. Does not test anything to do with NDP.PR: 196361Reviewed by: Erick Turnquist <[email protected]>MFC after: 3 weeksSponsored by: Spectra Logic CorpDifferential Revision: https://reviews.freebsd.org/D9776
Remove tests/sys/netinet/fibs_tests's dependency on net/socatInstead of bridging two tap interfaces with socat, just use an epair pair.MFC after: 3 weeksSponsored by: Spectra Logic Corp
Add fibs_test:udp_dontroute6, another IPv6 multi-FIB testPR: 196361MFC after: 3 weeksSponsored by: Spectra Logic Corp
Add tests for multi-fib IPv6 routingPR: 196361Submitted by: [email protected]Reported by: Jason Healy <[email protected]>MFC after: 4 weeksSponsored by: Spectra Logic Corp
On FreeBSD there is a setsockopt option SO_USER_COOKIE which allowssetting a 32 bit value on each socket. This can be used by applicationsand DTrace as a rendezvous point so that an applicaton's da
On FreeBSD there is a setsockopt option SO_USER_COOKIE which allowssetting a 32 bit value on each socket. This can be used by applicationsand DTrace as a rendezvous point so that an applicaton's data canmore easily be captured at run time. Expose the user cookie viaDTrace by updating the translator in tcp.d and add a quick testprogram, a TCP server, that sets the cookie on each connectionaccepted.Reviewed by: hirenMFC after: 1 weekSponsored by: Limelight NetworksDifferential Revision: https://reviews.freebsd.org/D7152
Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installedafter r298107Summary of changes:- Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that na
Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installedafter r298107Summary of changes:- Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that namespacing is kept with FILES appropriately, and that this shouldn't need to be repeated if the namespace changes -- only the definition of PACKAGE needs to be changed- Allow PACKAGE to be overridden by callers instead of forcing it to always be `tests`. In the event we get to the point where things can be split up enough in the base system, it would make more sense to group the tests with the blocks they're a part of, e.g. byacc with byacc-tests, etc- Remove PACKAGE definitions where possible, i.e. where FILES wasn't used previously.- Remove unnecessary TESTSPACKAGE definitions; this has been elided into bsd.tests.mk- Remove unnecessary BINDIRs used previously with ${PACKAGE}FILES; ${PACKAGE}FILESDIR is now automatically defined in bsd.test.mk.- Fix installation of files under data/ subdirectories in lib/libc/tests/hash and lib/libc/tests/net/getaddrinfo- Remove unnecessary .include <bsd.own.mk>s (some opportunistic cleanup)Document the proposed changes in share/examples/tests/tests/... via examplesso it's clear that ${PACKAGES}FILES is the suggested way forward in terms ofreplacing FILES. share/mk/bsd.README didn't seem like the appropriate methodof communicating that info.MFC after: never probablyX-MFC with: r298107PR: 209114Relnotes: yesTested with: buildworld, installworld, checkworld; buildworld, packageworldSponsored by: EMC / Isilon Storage Division
DIRDEPS_BUILD: Connect MK_TESTS.Sponsored by: EMC / Isilon Storage Division
Avoid adding the '-release' suffix to non-debug kernel packages.Sponsored by: The FreeBSD Foundation
Make cleanup routines idempotentcleanup routines can be executed at any point during the execution of thebody, including even before the body has done any real work. In thosecases, cleanup routi
Make cleanup routines idempotentcleanup routines can be executed at any point during the execution of thebody, including even before the body has done any real work. In thosecases, cleanup routines should be careful to not raise spurious errors soas to not "override" the actual result of the test case.This is just general good coding style but is not a problem in practicefor these specific tests. (The way I discovered the issue, though, wasdue to a regression I introduced in Kyua itself while refactoring someinternals.)MFC after: 1 week
Use PROGS instead of PROG and remove unnecessary SRCS?= assignmentUsing PROG instead of PROGS will in cases of high -j with -DNO_ROOT causethe PROG to show up more than once as it's handling the S
Use PROGS instead of PROG and remove unnecessary SRCS?= assignmentUsing PROG instead of PROGS will in cases of high -j with -DNO_ROOT causethe PROG to show up more than once as it's handling the SCRIPTS install casein a recursive manner, separate from the non-recursive caseAfter the recent batch of commits to bsd.progs.mk to fix behavior with howvariables are defaulted to, explicitly setting SRCS for a PROG is no longerrequiredMFC after: 1 weekReviewed by: asomersPhabric: D1130Sponsored by: EMC / Isilon Storage Division
Fix source address selection on unbound sockets in the presence of multiplefibs. Use the mbuf's or the socket's fib instead of RT_ALL_FIBS. Fixes PR187553. Also fixes netperf's UDP_STREAM test on a
Fix source address selection on unbound sockets in the presence of multiplefibs. Use the mbuf's or the socket's fib instead of RT_ALL_FIBS. Fixes PR187553. Also fixes netperf's UDP_STREAM test on a nondefault fib.sys/netinet/ip_output.c In ip_output, lookup the source address using the mbuf's fib instead of RT_ALL_FIBS.sys/netinet/in_pcb.c in in_pcbladdr, lookup the source address using the socket's fib, because we don't seem to have the mbuf fib. They should be the same, though.tests/sys/net/fibs_test.sh Clear the expected failure on udp_dontroute.PR: 187553CR: https://reviews.freebsd.org/D772MFC after: 3 weeksSponsored by: Spectra Logic
Fix unintended KBI change from r264905. Add _fib versions ofifa_ifwithnet() and ifa_ifwithdstaddr() The legacy functions will call the_fib() versions with RT_ALL_FIBS, preserving legacy behavior.
Fix unintended KBI change from r264905. Add _fib versions ofifa_ifwithnet() and ifa_ifwithdstaddr() The legacy functions will call the_fib() versions with RT_ALL_FIBS, preserving legacy behavior.sys/net/if_var.hsys/net/if.c Add legacy-compatible functions as described above. Ensure legacy behavior when RT_ALL_FIBS is passed as fibnum.sys/netinet/in_pcb.csys/netinet/ip_output.csys/netinet/ip_options.csys/net/route.csys/net/rtsock.csys/netinet6/nd6.c Call with _fib() functions if we must use a specific fib, or the legacy functions otherwise.tests/sys/netinet/fibs_test.shtests/sys/netinet/udp_dontroute.c Improve the udp_dontroute test. The bug that this test exercises is that ifa_ifwithnet() will return the wrong address, if multiple interfaces have addresses on the same subnet but with different fibs. The previous version of the test only considered one possible failure mode: that ifa_ifwithnet_fib() might fail to find any suitable address at all. The new version also checks whether ifa_ifwithnet_fib() finds the correct address by checking where the ARP request goes.Reported by: bz, hrsReviewed by: hrsMFC after: 1 weekX-MFC-with: 264905Sponsored by: Spectra Logic
Remove last two NO_MAN= in the tree. In both of these cases, MAN= iswhat is needed.
Add regression test for PR kern/189088.PR: kern/189088MFC after: 3 weeksSponsored by: Spectra Logic
Fix a panic when removing an IP address from an interface, if the same addressexists on another interface. The panic was introduced by change 264887, whichchanged the fibnum parameter in the call
Fix a panic when removing an IP address from an interface, if the same addressexists on another interface. The panic was introduced by change 264887, whichchanged the fibnum parameter in the call to rtalloc1_fib() inifa_switch_loopback_route() from RT_DEFAULT_FIB to RT_ALL_FIBS. The solutionis to use the interface fib in that call. For the majority of users, that willbe equivalent to the legacy behavior.PR: kern/189089Reported by: neelReviewed by: neelMFC after: 3 weeksX-MFC with: 264887Sponsored by: Spectra Logic
Style fixes, mostly trailing whitespace elimination. No functional change.Reported by: phoMFC after: 3 weeks
12