MFC r349195: Use sbuf_cat() in GEOM confxml generation.When it comes to megabytes of text, difference between sbuf_printf() andsbuf_cat() becomes substantial.
MFC r342687:Use g_handleattr() to reply to GEOM::candelete queries.
Fix use-after-free in RAID0 error reporting of GEOM_RAID.PR: 231510Submitted by: [email protected]Approved by: re (gjb)MFC after: 1 week
Squash error from geom by sizing ident strings to DISK_IDENT_SIZE.Display attribute in future error strings and differentiate g_handleattr()error messages for ease of debugging in the future."g_
Squash error from geom by sizing ident strings to DISK_IDENT_SIZE.Display attribute in future error strings and differentiate g_handleattr()error messages for ease of debugging in the future."g_handleattr: md1 bio_length 24 strlen 31 -> EFAULT"Reported by: swillsReviewed by: imp cem avgSponsored by: Limelight NetworksDifferential Revision: https://reviews.freebsd.org/D14962
show more ...
Do pass removing some write-only variables from the kernel.This reduces noise when kernel is compiled by newer GCC versions,such as one used by external toolchain ports.Reviewed by: kib, andrew(
Do pass removing some write-only variables from the kernel.This reduces noise when kernel is compiled by newer GCC versions,such as one used by external toolchain ports.Reviewed by: kib, andrew(sys/arm and sys/arm64), emaste(partial), erj(partial)Reviewed by: jhb (sys/dev/pci/* sys/kern/vfs_aio.c and sys/kern/kern_synch.c)Differential Revision: https://reviews.freebsd.org/D10385
geom_raid (RAID5): do not lose bp->bio_error, keep it in pbp->bio_errorand return it by passing to g_raid_iodone()Approved by: mav (mentor)MFC after: 3 days
Fix use-after-free that sometimes results in a garbage returnedinstead of right error code after requests to SINGLE/CONCAT volumes, f.e:# dd if=/dev/raid/r0 bs=512 of=/dev/nulldd: /dev/raid/r0: U
Fix use-after-free that sometimes results in a garbage returnedinstead of right error code after requests to SINGLE/CONCAT volumes, f.e:# dd if=/dev/raid/r0 bs=512 of=/dev/nulldd: /dev/raid/r0: Unknown error: -559038242Reviewed by: avg (mentor), mav (mentor)MFC after: 3 days
sys/geom: adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - errorprone
sys/geom: adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - errorprone - task.The Software Package Data Exchange (SPDX) group provides a specificationto make it easier for automated tools to detect and summarize well knownopensource licenses. We are gradually adopting the specification, notingthat the tags are considered only advisory and do not, in any way,superceed or replace the license texts.
g_raid: Prevent tasters from attempting excessively large readsSome g_raid tasters attempt metadata reads in multiples of the providersectorsize. Reads larger than MAXPHYS are invalid, so detect
g_raid: Prevent tasters from attempting excessively large readsSome g_raid tasters attempt metadata reads in multiples of the providersectorsize. Reads larger than MAXPHYS are invalid, so detect and abortin such situations.Spiritually similar to r217305 / PR 147851.PR: 214721Sponsored by: Dell EMC Isilon
Fix improper use of "its".Sponsored by: Dell EMC Isilon
Removal of Giant droping wrappers for GEOM classes.Sponsored by: The FreeBSD Foundation
sys/geom: spelling fixes in comments.No functional change.
sys/geom: spelling fixes.These affect debugging messages.MFC after: 2 weeks
geom: unsign some types to match their definitions and avoid overflows.In struct:gctl_req, nargs is unsigned.In mirror:g_mirror_syncreqs is unsigned.In raid:in struct:g_raid_volume, v_disks_c
geom: unsign some types to match their definitions and avoid overflows.In struct:gctl_req, nargs is unsigned.In mirror:g_mirror_syncreqs is unsigned.In raid:in struct:g_raid_volume, v_disks_count is unsigned.In virstor:in struct:g_virstor_softc, n_components is unsigned.MFC after: 2 weeks
sys: extend use of the howmany() macro when available.We have a howmany() macro in the <sys/param.h> header that isconvenient to re-use as it makes things easier to read.
Cleanup unnecessary semicolons from the kernel.Found with devel/coccinelle.
Create an API to reset a struct bio (g_reset_bio). This is mandatoryfor all struct bio you get back from g_{new,alloc}_bio. Temporarybios that you create on the stack or elsewhere should use this b
Create an API to reset a struct bio (g_reset_bio). This is mandatoryfor all struct bio you get back from g_{new,alloc}_bio. Temporarybios that you create on the stack or elsewhere should use this beforefirst use of the bio, and between uses of the bio. At the moment, itis nothing more than a wrapper around bzero, but that may change inthe future. The wrapper also removes one place where we encode thesize of struct bio in the KBI.
Remove compatibility shims for legacy ATA device names.We got new ATA stack in FreeBSD 8.x, switched to it at 9.x, completelyremoved old stack at 10.x, so at 11.x it is time to remove compat shims.
Clean out some externally visible "more then" grammarMFC after: 3 days
Remove request sorting from GEOM_MIRROR and GEOM_RAID.When CPU is not busy, those queues are typically empty. When CPU is busy,then one more extra sorting is the last thing it needs. If specific
Remove request sorting from GEOM_MIRROR and GEOM_RAID.When CPU is not busy, those queues are typically empty. When CPU is busy,then one more extra sorting is the last thing it needs. If specific device(HDD) really needs sorting, then it will be done later by CAM.This supposed to fix livelock reported for mirror of two SSDs, when UFSfires zillion of BIO_DELETE requests, that totally blocks I/O subsystem bypointless sorting of requests and responses under single mutex lock.MFC after: 2 weeks
Replace constant with proper sizeof().Submitted by: Dmitry Luhtionov <[email protected]>MFC after: 2 weeks
Avoid unneeded malloc/memcpy/free if there is no metadata on disk.Submitted by: Dmitry Luhtionov <[email protected]>MFC after: 2 weeks
Decode some binary fields of Intel metadata.Submitted by: Dmitry Luhtionov <[email protected]>MFC after: 2 weeks
Follow up to r225617. In order to maximize the re-usability of kernel codein userland rename in-kernel getenv()/setenv() to kern_setenv()/kern_getenv().This fixes a namespace collision with libc sy
Follow up to r225617. In order to maximize the re-usability of kernel codein userland rename in-kernel getenv()/setenv() to kern_setenv()/kern_getenv().This fixes a namespace collision with libc symbols.Submitted by: kmacyTested by: make universe
Pull in r267961 and r267973 again. Fix for issues reported will follow.
1234