Add support for Error RecoverySubmitted by:[email protected]Approved by:re(kib)MFC after:5 days
Fixed isses: State check before enqueuing transmit task in bxe_link_attn() routine. State check before invoking bxe_nic_unload in bxe_shutdown().Submitted by:[email protected]Approved
Fixed isses: State check before enqueuing transmit task in bxe_link_attn() routine. State check before invoking bxe_nic_unload in bxe_shutdown().Submitted by:[email protected]Approved by:re(gjb)
show more ...
Fixes for the following issues:1. Fix taskqueues drain/free to fix panic seen when interface is being bought down and in parallel asynchronous link events happening.2. Fix bxe_ifmedia_status()
Fixes for the following issues:1. Fix taskqueues drain/free to fix panic seen when interface is being bought down and in parallel asynchronous link events happening.2. Fix bxe_ifmedia_status()Submitted by:[email protected] and [email protected]MFC after:5 days
Fix build of bxe with base gcc on i386Casting from rman_res_t to a pointer results in "cast to pointer frominteger of different size" warnings with base gcc on i386, so printthese without casting
Fix build of bxe with base gcc on i386Casting from rman_res_t to a pointer results in "cast to pointer frominteger of different size" warnings with base gcc on i386, so printthese without casting. The kva field of struct bxe_bar is of typevm_offset_t, which can be 32 or 64 bit, so cast it to uintmax_t beforeprinting.Reviewed by: markjMFC after: 3 daysDifferential Revision: https://reviews.freebsd.org/D15733
ifnet: Replace if_addr_lock rwlock with epoch + mutexRun on LLNW canaries and tested by pho@gallatin:Using a 14-core, 28-HTT single socket E5-2697 v3 with a 40GbE MLX5based ConnectX 4-LX NIC, I
ifnet: Replace if_addr_lock rwlock with epoch + mutexRun on LLNW canaries and tested by pho@gallatin:Using a 14-core, 28-HTT single socket E5-2697 v3 with a 40GbE MLX5based ConnectX 4-LX NIC, I see an almost 12% improvement in receivedpacket rate, and a larger improvement in bytes delivered all the wayto userspace.When the host receiving 64 streams of netperf -H $DUT -t UDP_STREAM -- -m 1,I see, using nstat -I mce0 1 before the patch:InMpps OMpps InGbs OGbs err TCP Est %CPU syscalls csw irq GBfree4.98 0.00 4.42 0.00 4235592 33 83.80 4720653 2149771 1235 247.324.73 0.00 4.20 0.00 4025260 33 82.99 4724900 2139833 1204 247.324.72 0.00 4.20 0.00 4035252 33 82.14 4719162 2132023 1264 247.324.71 0.00 4.21 0.00 4073206 33 83.68 4744973 2123317 1347 247.324.72 0.00 4.21 0.00 4061118 33 80.82 4713615 2188091 1490 247.324.72 0.00 4.21 0.00 4051675 33 85.29 4727399 2109011 1205 247.324.73 0.00 4.21 0.00 4039056 33 84.65 4724735 2102603 1053 247.32After the patchInMpps OMpps InGbs OGbs err TCP Est %CPU syscalls csw irq GBfree5.43 0.00 4.20 0.00 3313143 33 84.96 5434214 1900162 2656 245.515.43 0.00 4.20 0.00 3308527 33 85.24 5439695 1809382 2521 245.515.42 0.00 4.19 0.00 3316778 33 87.54 5416028 1805835 2256 245.515.42 0.00 4.19 0.00 3317673 33 90.44 5426044 1763056 2332 245.515.42 0.00 4.19 0.00 3314839 33 88.11 5435732 1792218 2499 245.525.44 0.00 4.19 0.00 3293228 33 91.84 5426301 1668597 2121 245.52Similarly, netperf reports 230Mb/s before the patch, and 270Mb/s after the patchReviewed by: gallatinSponsored by: Limelight NetworksDifferential Revision: https://reviews.freebsd.org/D15366
Fix bxe(4) netdump rx polling.Reviewed by: cem, rstoneX-MFC with: r333287Sponsored by: Dell EMC Isilon
Add netdump support to bxe(4).Tested with a NetXtreme II BCM57810 adapter.Reviewed by: davidcsMFC after: 1 monthSponsored by: Dell EMC IsilonDifferential Revision: https://reviews.freebsd.org/
Add netdump support to bxe(4).Tested with a NetXtreme II BCM57810 adapter.Reviewed by: davidcsMFC after: 1 monthSponsored by: Dell EMC IsilonDifferential Revision: https://reviews.freebsd.org/D15257
Fix Issue with adding MUltiCast Addresses. When multicast addresses areadded/deleted, the delete the multicast addresses previously programmedin HW and reprogram the new set of multicast addresses.
Fix Issue with adding MUltiCast Addresses. When multicast addresses areadded/deleted, the delete the multicast addresses previously programmedin HW and reprogram the new set of multicast addresses.Submitted by:[email protected]MFC after:5 days
dev/bxe: make use of mallocarray(9).Use mallocarray in a couple of cases where a calloc-like operation istaking place.
sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 3-Clause license.The Software Package Data Exchange (SPDX) group provides a specificationto make it easier
sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 3-Clause license.The Software Package Data Exchange (SPDX) group provides a specificationto make it easier for automated tools to detect and summarize well knownopensource licenses. We are gradually adopting the specification, notingthat the tags are considered only advisory and do not, in any way,superceed or replace the license texts.Special thanks to Wind River for providing access to "The Duke ofHighlander" tool: an older (2014) run over FreeBSD tree was useful as astarting point.
Add HPE FlexFabric 10Gb 4-port 536FLR-T device id to the bxe(4) driver.Tested by: David Miguel Almas <dmalmas gmail com>MFC after: 1 weekDifferential Revision: https://reviews.freebsd.org/D11478
1. state checks in bxe_tx_mq_start_locked() and bxe_tx_mq_start() to sync threads during interface down or detach.2. add sysctl to set pause frame parameters3. increase max segs for TSO packets to
1. state checks in bxe_tx_mq_start_locked() and bxe_tx_mq_start() to sync threads during interface down or detach.2. add sysctl to set pause frame parameters3. increase max segs for TSO packets to BXE_TSO_MAX_SEGMENTS (32)4. add debug messages for PHY5. HW LRO support restricted to FreeBSD versions 8.x and above.Submitted by:[email protected]MFC after:5 days
bxe: enable usage with NetXtreme II BCM57840 2x20GbE chipCurrent bxe probe function won't attach to devices with the NetXtreme IIBCM57840 2x20GbE chip, enable it by adding it's chip ID to the list
bxe: enable usage with NetXtreme II BCM57840 2x20GbE chipCurrent bxe probe function won't attach to devices with the NetXtreme IIBCM57840 2x20GbE chip, enable it by adding it's chip ID to the list ofsupported chips.Tested on: HP ProLiant WS460c Gen9Reviewed by: gnnMFC after: 1 weekSponsored by: Citrix Systems R&DDifferential Revision: https://reviews.freebsd.org/D9609
r266979 missed a call to enable capabilities of the hw leading to aninability to enable features of the device.PR: 213845Submitted by: [email protected]MFC after: 1 week
Use proper if_getdrvflags() API.This is a NOP.Sponsored by: Dell EMC Isilon
1. Use taskqueue_create() instead of taskqueue_create_fast() for both fastpath and slowpath taskqueues.2. Service all transmits in taskqueue threads.3. additional stats counters for keeping t
1. Use taskqueue_create() instead of taskqueue_create_fast() for both fastpath and slowpath taskqueues.2. Service all transmits in taskqueue threads.3. additional stats counters for keeping track of - bd availability - tx buf ring not emptied in the fp task queue. These are drained via timeout taskqueue. - tx attempts during link down.MFC after: 5 days
Revert commit r306284 - Fixes for issues under high workloadsWill fix and recommit patch
Fixes for issues under high workloadsMFC after:5 days
sys/dev: replace comma with semicolon when pertinent.Uses of commas instead of a semicolons can easily go undetected. The commacan serve as a statement separator but this shouldn't be abused when
sys/dev: replace comma with semicolon when pertinent.Uses of commas instead of a semicolons can easily go undetected. The commacan serve as a statement separator but this shouldn't be abused whenstatements are meant to be standalone.Detected with devel/coccinelle following a hint from DragonFlyBSD.MFC after: 1 month
Don't enqueue NULL on a drbrIn one corner case in the bxe TX path, a NULL mbuf could be enqueued ontoa drbr queue. This could case a KASSERT to fire with INVARIANTS enabled,or the processing of
Don't enqueue NULL on a drbrIn one corner case in the bxe TX path, a NULL mbuf could be enqueued ontoa drbr queue. This could case a KASSERT to fire with INVARIANTS enabled,or the processing of packets from the queue to be prematurely ended lateron.Submitted by: Matt Joras (matt.joras AT isilon.com)Reviewed by: davidcsMFC after: 3 daysSponsored by: EMC / Isilon Storage DivisionDifferential Revision: https://reviews.freebsd.org/D7041
Don't repeat the the word 'the'(one manual change to fix grammar)Confirmed With: dbApproved by: secteam (not really, but this is a comment typo fix)
Don't jam the softc in the device_probe routine. The softc isn't owned bythe driver here, so it shouldn't be accessed, let alone written to. Removethe nearby debug line, it's the only thing that
Don't jam the softc in the device_probe routine. The softc isn't owned bythe driver here, so it shouldn't be accessed, let alone written to. Removethe nearby debug line, it's the only thing that depended on the softc, andit depended on it in a way that couldn't work in this part of the code.This fixes some reports of use-after-free and system instability withDEBUG_MEMGUARD enabled.Submitted by: Matthew MacyMFC after: 3 days
sys/dev: minor spelling fixes.Most affect comments, very few have user-visible effects.
1. Removed -Wno-shift-negative-value from Makefile2. Fixed warning its absence caused in bxe_elink.cMFC after:5 days
Remove Unused/Dead CodeMFC after:5 days
12345