| 1613f091 | 07-Oct-2018 |
Kyle Evans <[email protected]> |
lualoader: Honor boot_* variables at lua init
For non-UEFI systems, boot.config(5) may have -s or -v specified for single-user and verbose boot respectively. These were not being properly taken into
lualoader: Honor boot_* variables at lua init
For non-UEFI systems, boot.config(5) may have -s or -v specified for single-user and verbose boot respectively. These were not being properly taken into account and reflected in the "Boot Options" submenu. When we initialize core.lua, we'll record boot_single and boot_verbose as we do ACPI and consider these the system defaults.
Reported by: David Wolfskill <[email protected]> Approved by: re (kib)
show more ...
|
| 1ee89ab5 | 23-Aug-2018 |
Kyle Evans <[email protected]> |
lualoader: Accept that people use unquoted values in loader.conf
While loader.conf(5) suggests that all values should be quoted, reality is that this was never strictly enforced and it is used. We a
lualoader: Accept that people use unquoted values in loader.conf
While loader.conf(5) suggests that all values should be quoted, reality is that this was never strictly enforced and it is used. We already make some concession to this in number values, which aren't strictly quoted either.
The compromise here is that multi-word values must be quoted. This lets things like `foo_load=YES` work, while denying more complex expressions on the right hand side. This likely catches the vast majority of current usage.
A bit of a kludge is needed to accomplish this since Lua regex doesn't support branching. I had considered splitting up expressions and generating the right-hand side of the expressions completely in config.parse, but deemed this too large of an overhaul to take given the current timing. This should be re-worked shortly after the thaw.
Reported by: royger
show more ...
|
| 9a16e110 | 22-Aug-2018 |
Kyle Evans <[email protected]> |
lualoader: Fix loader.conf(5) EOL validation for 'exec' lines
This includes some light rework to simplify the line parsing, as well. If we hit a line match, we'll always either use the line and mov
lualoader: Fix loader.conf(5) EOL validation for 'exec' lines
This includes some light rework to simplify the line parsing, as well. If we hit a line match, we'll always either use the line and move on to the next line, or we'll spew out malformed line errors.
We had multiple spots to output the error and set the status based on whether we had a non-nil first capture group or failed EOL validation, but it was always the same error. Light rework entails a small label jump to skip error handling and elimination of 'found' local.
show more ...
|
| 058c692e | 21-Aug-2018 |
Kyle Evans <[email protected]> |
lualoader: Refactor config line expressions
A couple of issues addressed:
1.) Modules with - in the name were not recognized as modules 2.) The module regex was repeated for each place a module nam
lualoader: Refactor config line expressions
A couple of issues addressed:
1.) Modules with - in the name were not recognized as modules 2.) The module regex was repeated for each place a module name may appear 3.) The 'strip leading space' bits were repeated for each expression 4.) The trailing 'comment validation' stuff was repeated every expression
#4 still has some more work to be done. exec lines, for instance, don't capture a 'value' -- there's only one capture pattern. This throws off the 'c' value that we match, so the trailing bits aren't *actually* being validated. This isn't a new issue, though, so a future comit will address this.
show more ...
|
| b991b318 | 20-Aug-2018 |
Kyle Evans <[email protected]> |
lualoader: Install all manpages
Now that a complete set is written, save for one describing loader.lua, install all of them. This was not previously done as they were written to hopefully avoid conf
lualoader: Install all manpages
Now that a complete set is written, save for one describing loader.lua, install all of them. This was not previously done as they were written to hopefully avoid confusion as bits and pieces of the overall system were undocumented.
show more ...
|
| 2c690e2a | 19-Aug-2018 |
Kyle Evans <[email protected]> |
lualoader: Add drawer-exported variables for default logodefs
Uncovered while writing the documentation from this, we previously explicitly fell back to orb or orbbw if an invalid or incompatible lo
lualoader: Add drawer-exported variables for default logodefs
Uncovered while writing the documentation from this, we previously explicitly fell back to orb or orbbw if an invalid or incompatible logodef was selected -- in contrast to branddefs, which have an exported variable that one can whip up a quick local.lua to override in a safe manner that works regardless of whether or not loader.conf(5) successfully loads.
show more ...
|
| a9edc01b | 19-Aug-2018 |
Kyle Evans <[email protected]> |
lualoader: Hide the rest of the private interfaces
These are less controversial than the others, thus done in a separate commit. These are all used internally and ways to override are provided via s
lualoader: Hide the rest of the private interfaces
These are less controversial than the others, thus done in a separate commit. These are all used internally and ways to override are provided via soon-to-be-documented API or loader.conf(5) variables.
show more ...
|
| 12eaa305 | 19-Aug-2018 |
Kyle Evans <[email protected]> |
lualoader: Hide most of the internal drawing functions
Ideally, all of the functionality to revamp the loader screen has associated APIs that are flexible enough that third-party scripts wouldn't ne
lualoader: Hide most of the internal drawing functions
Ideally, all of the functionality to revamp the loader screen has associated APIs that are flexible enough that third-party scripts wouldn't need to override these.
show more ...
|