| #
71ea6032 |
| 22-Jun-2023 |
Kudo Chien <[email protected]> |
[android][tools] fix expo go versioning issues on android (#22950)
# Why
fix expo-go android versioning for sdk 49
close ENG-8955
# How
- [tools] fix for react-native monorepo changes
- [
[android][tools] fix expo go versioning issues on android (#22950)
# Why
fix expo-go android versioning for sdk 49
close ENG-8955
# How
- [tools] fix for react-native monorepo changes
- [tools] update manifest-merger because the original one doesn't support java 17. since the new manifest-merger has kotlin runtime and the jar takes about 35MB. rather than committing a prebuilt jar, now we build manifest-merger from source.
- [tools] since #22609 we don't have `package` in libraries' AndroidManifest.xml, the manifest-merger still requires the `package`, so we have to temporarily put the `package` back during manifest merging. (the `package` name is generated from `namespace` in build.gradle)
- [tools] the original jarjar uses outdated [ASM](https://asm.ow2.io/) and it doesn't support bytecode generated by kotlin. react-native now has some kotlin code, and the original jarjar cannot transform package name from those kotlin classes. i've tried to rebuild a jarjar from [this revision](https://github.com/google/jarjar/commit/e11d5636aa45664271c8f1603067527b2520f591). this requires some manual steps like updating ASM libs and install ant builder. so i still commit the prebuilt jarjar in this pr.
- [updates] force casting for `UpdateEntity` to deal with kotlin smart casting from versioned to unversioned kernel class. (i'll leave inline comment for this)
- [expo-modules-core's `android-annotation`] the project stays in a place that does not support versioning yet. in this pr i just keep it as an unversionable project. cc @lukmccall
# Test Plan
`et add-sdk -p android -s 49.0.0` + android versioned expo-go + sdk 49 NCL smoke test
show more ...
|
| #
5bd1be93 |
| 19-Mar-2023 |
Tomasz Sapeta <[email protected]> |
[tools] Fix the review bot complaining about changes in the root changelog (#21209)
|
| #
5ff37293 |
| 01-Feb-2023 |
Kudo Chien <[email protected]> |
[android][tools] fix android versioning (#20889)
# Why
fix android versioning after react-native 0.71 upgrade
# How
mostly fixing transforms
# Test Plan
1. `et add-sdk -p android -s 4
[android][tools] fix android versioning (#20889)
# Why
fix android versioning after react-native 0.71 upgrade
# How
mostly fixing transforms
# Test Plan
1. `et add-sdk -p android -s 48.0.0`
2. `cd android ; ./gradlew :app:assembleVersionedDebug`
3. versioned android expo go + sdk 48 ncl smoke test
show more ...
|
| #
6239b2d0 |
| 21-Oct-2022 |
Kudo Chien <[email protected]> |
[tools] Update android versioning script for sdk 47 (#19518)
# Why
update android versioning script for sdk 47
# How
- [android] update gradle wrapper version to 7.5.1, which aligned with r
[tools] Update android versioning script for sdk 47 (#19518)
# Why
update android versioning script for sdk 47
# How
- [android] update gradle wrapper version to 7.5.1, which aligned with react-native 0.70
- [localization] fix compileSdkVersion 33 build error
- [tools] update versioning script
- remove `renameHermesEngine` which is deprecated patchelf based hermes versioning
- replace duplicated runReactNativeCodegenAndroidAsync with `Codegen.runReactNativeCodegenAsync`
- update versioning script to support building in-place from react-native-lab
- update for react-native 0.70
- update versionCxx for expo-modules-core
- support other new style vendoring modules
- @react-native-community/slider
- react-native-gesture-handler (with cxx files but they're only for new architecture)
- react-native-screens (with cxx files but they're only for new architecture)
- react-native-svg
- react-native-reanimated (with cxx files)
- remove old reanimated versioning scripts
# Test Plan
```
$ et add-sdk -p android -s 47.0.0
$ cd android && ./gradlew :app:installVersionedDebug
# smoke test on sdk 47 NCL
```
show more ...
|
| #
a9d50702 |
| 14-Jul-2022 |
Kudo Chien <[email protected]> |
[tools] Strip prebuilt native libs in versioned code
Summary:
The new cmake from AGP builds the `RelWithDebInfo` variant by default. That would increase the prebuilt lib size much and not ideal for
[tools] Strip prebuilt native libs in versioned code
Summary:
The new cmake from AGP builds the `RelWithDebInfo` variant by default. That would increase the prebuilt lib size much and not ideal for committing into git. This change uses the stripped prebuilt libs.
show more ...
|
| #
85fe1964 |
| 14-Jul-2022 |
Kudo Chien <[email protected]> |
[tools] fix android versioning (#18227)
# Why
fix for sdk46 android versioning
# How
- fix that settings.gradle content be overwrote from my change of vendoring skia
- update expo-modules-
[tools] fix android versioning (#18227)
# Why
fix for sdk46 android versioning
# How
- fix that settings.gradle content be overwrote from my change of vendoring skia
- update expo-modules-core patch
- fix vendor modules versioning for @shopify/flash-list
# Test Plan
1. `et add-sdk -p android -s 46.0.0`
2. versioned android expo go + sdk46 ncl launch test
show more ...
|
| #
1833af43 |
| 06-Jul-2022 |
Kudo Chien <[email protected]> |
[android] Add @shopify/react-native-skia vendoring support for Expo Go (#17964)
# Why
like #17704 but for android
close ENG-4889
# How
- introduce vendor modules autolinking for expo go.
[android] Add @shopify/react-native-skia vendoring support for Expo Go (#17964)
# Why
like #17704 but for android
close ENG-4889
# How
- introduce vendor modules autolinking for expo go.
previously, reanimated is the only vendor module having cxx code, we had a fixed versioning script for reanimated. because react-native-skia also has cxx code, i'm trying to keep the versioning more modularized and like what we did for ios versioning. ideally, a vendor module should have a dedicated gradle project. that's why i introduced a vendor module autolinking here.
- vendoring tool: add react-native-skia support
- versioning tool: trying to add a minimum support for new style versioning like ios.
currently, after transforming the code, i still prebuild the *.so to `jniLibs`. in the future when we commit `android/versioned-react-native/ABI46_0_0` to git, we can always build the versioned *.so from source.
# Test Plan
- android unversioned expo go + NCL skia
- android versioned expo go + NCL skia
Co-authored-by: Tomasz Sapeta <[email protected]>
show more ...
|