| #
85fe1964 |
| 14-Jul-2022 |
Kudo Chien <[email protected]> |
[tools] fix android versioning (#18227)
# Why
fix for sdk46 android versioning
# How
- fix that settings.gradle content be overwrote from my change of vendoring skia
- update expo-modules-
[tools] fix android versioning (#18227)
# Why
fix for sdk46 android versioning
# How
- fix that settings.gradle content be overwrote from my change of vendoring skia
- update expo-modules-core patch
- fix vendor modules versioning for @shopify/flash-list
# Test Plan
1. `et add-sdk -p android -s 46.0.0`
2. versioned android expo go + sdk46 ncl launch test
show more ...
|
| #
1833af43 |
| 06-Jul-2022 |
Kudo Chien <[email protected]> |
[android] Add @shopify/react-native-skia vendoring support for Expo Go (#17964)
# Why
like #17704 but for android
close ENG-4889
# How
- introduce vendor modules autolinking for expo go.
[android] Add @shopify/react-native-skia vendoring support for Expo Go (#17964)
# Why
like #17704 but for android
close ENG-4889
# How
- introduce vendor modules autolinking for expo go.
previously, reanimated is the only vendor module having cxx code, we had a fixed versioning script for reanimated. because react-native-skia also has cxx code, i'm trying to keep the versioning more modularized and like what we did for ios versioning. ideally, a vendor module should have a dedicated gradle project. that's why i introduced a vendor module autolinking here.
- vendoring tool: add react-native-skia support
- versioning tool: trying to add a minimum support for new style versioning like ios.
currently, after transforming the code, i still prebuild the *.so to `jniLibs`. in the future when we commit `android/versioned-react-native/ABI46_0_0` to git, we can always build the versioned *.so from source.
# Test Plan
- android unversioned expo go + NCL skia
- android versioned expo go + NCL skia
Co-authored-by: Tomasz Sapeta <[email protected]>
show more ...
|