| #
4ab6f4c5 |
| 23-Aug-2022 |
Kudo Chien <[email protected]> |
[ios][tools] Fix unversioned codegen scripts not updated (#18344)
# Why
some react-native codegen scripts in script_phases.rb are not versioned, e.g. [`get_script_phases_no_codegen_discovery`](ht
[ios][tools] Fix unversioned codegen scripts not updated (#18344)
# Why
some react-native codegen scripts in script_phases.rb are not versioned, e.g. [`get_script_phases_no_codegen_discovery`](https://github.com/expo/expo/blob/85a1f11cbcd6fbac54984d3396655fd4edcd46d7/ios/versioned-react-native/ABI46_0_0/ReactNative/scripts/react_native_pods_utils/script_phases.rb#L22). this will overwrite the unversioned codegen scripts, so [the latest change for with-environment.sh execution](https://github.com/expo/react-native/blob/e25372b2f95a580f61479fa6376a8f75b5460e99/scripts/react_native_pods_utils/script_phases.rb#L48-L49) will not be applied.
# How
- [ios] versioning methods in `script_phases.rb` in sdk 45/46 code.
- [tools] refactor `generateReactNativePodScriptAsync` to use `copyFileWithTransformsAsync`
- [tools] versioning methods in `script_phases.rb`
# Test Plan
- `et remove-sdk -p ios -s 46.0.0` + `et add-sdk -p ios -s 46.0.0` and make sure no changes in scripts/ folder
- `et pods -f` and check `ios/Pods/Local Podspecs/FBReactNativeSpec.podspec.json` has `with-environment.sh`
show more ...
|