| #
71ea6032 |
| 22-Jun-2023 |
Kudo Chien <[email protected]> |
[android][tools] fix expo go versioning issues on android (#22950)
# Why
fix expo-go android versioning for sdk 49
close ENG-8955
# How
- [tools] fix for react-native monorepo changes
- [
[android][tools] fix expo go versioning issues on android (#22950)
# Why
fix expo-go android versioning for sdk 49
close ENG-8955
# How
- [tools] fix for react-native monorepo changes
- [tools] update manifest-merger because the original one doesn't support java 17. since the new manifest-merger has kotlin runtime and the jar takes about 35MB. rather than committing a prebuilt jar, now we build manifest-merger from source.
- [tools] since #22609 we don't have `package` in libraries' AndroidManifest.xml, the manifest-merger still requires the `package`, so we have to temporarily put the `package` back during manifest merging. (the `package` name is generated from `namespace` in build.gradle)
- [tools] the original jarjar uses outdated [ASM](https://asm.ow2.io/) and it doesn't support bytecode generated by kotlin. react-native now has some kotlin code, and the original jarjar cannot transform package name from those kotlin classes. i've tried to rebuild a jarjar from [this revision](https://github.com/google/jarjar/commit/e11d5636aa45664271c8f1603067527b2520f591). this requires some manual steps like updating ASM libs and install ant builder. so i still commit the prebuilt jarjar in this pr.
- [updates] force casting for `UpdateEntity` to deal with kotlin smart casting from versioned to unversioned kernel class. (i'll leave inline comment for this)
- [expo-modules-core's `android-annotation`] the project stays in a place that does not support versioning yet. in this pr i just keep it as an unversionable project. cc @lukmccall
# Test Plan
`et add-sdk -p android -s 49.0.0` + android versioned expo-go + sdk 49 NCL smoke test
show more ...
|
| #
5bd1be93 |
| 19-Mar-2023 |
Tomasz Sapeta <[email protected]> |
[tools] Fix the review bot complaining about changes in the root changelog (#21209)
|
| #
9eae8a6a |
| 14-Sep-2022 |
Kudo Chien <[email protected]> |
[ios][tools] Add Hermes support for Expo Go (#19078)
# Why
close ENG-6189
# How
- [tools] add *versionHermes.ts* to create a versioned hermes.xcframework. this script will be invoked in add
[ios][tools] Add Hermes support for Expo Go (#19078)
# Why
close ENG-6189
# How
- [tools] add *versionHermes.ts* to create a versioned hermes.xcframework. this script will be invoked in adding new sdk. it will also show a prompt to upload the artifact.
for ci testing, the hermes podspec also supports xcframework from local file system:
```
if File.exists?(File.join(__dir__, "destroot"))
source[:path] = '.'
else
source[:http] = 'https://github.com/expo/react-native/releases/download/sdk-47.0.0/ABI47_0_0hermes.tar.gz'
end,
```
- [tools] versioning hermes related code in react-native
- [manifest] add `jsEngine` method to read the jsEngine or ios.jsEngine value from manifest
- ~[reanimated] introduce `useHermes` runtime option to create specific js runtime~ Update: always use hermes to simplify the versioning script.
- [reanimated] backport sdk45, sdk46 code to disable hermes
# Test Plan
- `et add-sdk -p ios -s 47.0.0` + versioned expo go
- unversioned expo go + NCL
- unversioned expo go + NCL with `"jsEngine": "hermes"`
- versioning ci job passed: https://github.com/expo/expo/actions/runs/3049529467/jobs/4915687276
Co-authored-by: Tomasz Sapeta <[email protected]>
show more ...
|
| #
d7f57c45 |
| 29-Apr-2021 |
Dominik Sokal <[email protected]> |
[tools] add sync-bundled-native-modules script (#12760)
* [tools] add sync-bundled-native-modules script
* [tools] fix tsc errors
* [tools] address PR feedback
* Apply suggestions from code
[tools] add sync-bundled-native-modules script (#12760)
* [tools] add sync-bundled-native-modules script
* [tools] fix tsc errors
* [tools] address PR feedback
* Apply suggestions from code review
Co-authored-by: Tomasz Sapeta <[email protected]>
Co-authored-by: Tomasz Sapeta <[email protected]>
show more ...
|
| #
eeffdb10 |
| 21-Dec-2020 |
Tomasz Sapeta <[email protected]> |
[tools] Move tools/expotools one folder up (#11410)
|