History log of /expo/packages/html-elements/src/primitives/Image.tsx (Results 1 – 2 of 2)
Revision Date Author Comments
# 8a424beb 11-Aug-2023 James Ide <[email protected]>

[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)

Why
---
Prettier 3 is out. Add support for it with this linter config.

**Note for reviewer:** the first commit is the one with th

[lint] Upgrade to Prettier v3, typescript-eslint to v6 (#23544)

Why
---
Prettier 3 is out. Add support for it with this linter config.

**Note for reviewer:** the first commit is the one with the actual
changes. The rest of this PR are changes to get the linter passing
(mostly autofix).

How
---
Update eslint-config-prettier and eslint-plugin-prettier. To address
deprecation warnings, also update typescript-eslint/parser and
typescript-eslint/eslint-plugin.
Because of an update to typescript-eslint/parser, we need to suppress
deprecation warnings (documented in a comment).

Regenerated test snapshots. Due to the upgraded dependencies, typecasts
and optional chaining are now auto-fixable by lint. This converts
warnings into autofixes.

Test Plan
---
`yarn test` in the linter config. Run `expotools check --all --fix-lint
--no-build --no-test --no-uniformity-check` to try this config on the
whole repo.

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...


# 641d0767 03-Feb-2023 Evan Bacon <[email protected]>

feat(html-elements): improve assertions (#21069)

# Why

- Temporary workaround for https://github.com/facebook/react/pull/22725
- Unwrapped text strings are very difficult to find and cause criti

feat(html-elements): improve assertions (#21069)

# Why

- Temporary workaround for https://github.com/facebook/react/pull/22725
- Unwrapped text strings are very difficult to find and cause critical
errors to occur. When using expo/html-elements, devs have a much higher
chance of accidentally making this mistake.
- `@expo/html-elements` is web-first React Native and therefore should
have first-class types and styles for `react-native-web`. This PR
injects a native wrapper to strip out web styles that aren't supported.

# How

When a text child appears in View, the child is replaced by a red view
with text indicating the string. A warning is also presented to attempt
to provide a stack trace (which mostly doesn't help).

# Test Plan

- Added unit tests for the expected functionality.
- I've been using this in my personal package `@bacons/react-views` for
a while and it hurts to go back.

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).

---------

Co-authored-by: Expo Bot <[email protected]>

show more ...