| #
641d0767 |
| 03-Feb-2023 |
Evan Bacon <[email protected]> |
feat(html-elements): improve assertions (#21069)
# Why
- Temporary workaround for https://github.com/facebook/react/pull/22725
- Unwrapped text strings are very difficult to find and cause criti
feat(html-elements): improve assertions (#21069)
# Why
- Temporary workaround for https://github.com/facebook/react/pull/22725
- Unwrapped text strings are very difficult to find and cause critical
errors to occur. When using expo/html-elements, devs have a much higher
chance of accidentally making this mistake.
- `@expo/html-elements` is web-first React Native and therefore should
have first-class types and styles for `react-native-web`. This PR
injects a native wrapper to strip out web styles that aren't supported.
# How
When a text child appears in View, the child is replaced by a red view
with text indicating the string. A warning is also presented to attempt
to provide a stack trace (which mostly doesn't help).
# Test Plan
- Added unit tests for the expected functionality.
- I've been using this in my personal package `@bacons/react-views` for
a while and it hurts to go back.
<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
---------
Co-authored-by: Expo Bot <[email protected]>
show more ...
|