[web-browser][docs] Fix broken link for AppState (#24400)
[expo] Use `requireNativeModule` instead of `NativeModulesProxy.*` (#23573)# Why Uses `requireNativeModule` instead of the legacy `NativeModulesProxy`.
[web-browser] Fix prettier issue
[docs] Update to use right protocol in redirect URI on iOS for openAuthSessionAsync (#20229)
[web-browser] Support CSS colors (#18586)
chore: remove mentions of legacy CLI commands (#18419)* chore: remove mentions of legacy CLI commands * Apply suggestions from code review Co-authored-by: Expo Bot <[email protected]
chore: remove mentions of legacy CLI commands (#18419)* chore: remove mentions of legacy CLI commands * Apply suggestions from code review Co-authored-by: Expo Bot <[email protected]> * Apply suggestions from code review Co-authored-by: James Ide <[email protected]> * update doc gen * Update packages/expo-web-browser/src/WebBrowser.ts * update files * fix Co-authored-by: Expo Bot <[email protected]> Co-authored-by: James Ide <[email protected]>
show more ...
[docs][web-browser] Switch comment to indicate we use ASWebAuthenticationSession (#18320)
[web-browser] Fix `windowFeatures` option on web (#18106)Co-authored-by: Expo Bot <[email protected]>
[web-browser] Make `redirectUrl` auth session argument optional (#17953)I'm personally not convinced about this change, but use it at your own risk. - Updated TypeScript to make this argument op
[web-browser] Make `redirectUrl` auth session argument optional (#17953)I'm personally not convinced about this change, but use it at your own risk. - Updated TypeScript to make this argument optional - Slightly clarified docs (default value is only provided on web) - On iOS made this argument optional. The `ASWebAuthenticationSession` seems not to require it, although it's not documented what happens then. From what I tested - The web auth session just does not close automatically after logged in - On Android, it was possible to make it optional - when it's `null`, the _wait for redirect Promise_ never resolves, but as it's part of a `Promise.race()`, then finally another promise resolves (wins the race) when auth session window is closed manually. This is the same behaviour as on iOS so it should be OK. Co-authored-by: Expo Bot <[email protected]>
[jest-expo] Fix auth-session tests (#17835)
[web-browser] Fix `removeSubscription()` deprecation warnings (#17645)- Replaced `_redirectHandler` with an `EmitterSubscription` object and `Linking.removeSubsctiption(...)` with `subscription.rem
[web-browser] Fix `removeSubscription()` deprecation warnings (#17645)- Replaced `_redirectHandler` with an `EmitterSubscription` object and `Linking.removeSubsctiption(...)` with `subscription.remove()` - Did the same with `appStateListener` in the web implementation Co-authored-by: Expo Bot <[email protected]>
[tsdoc] update example references, fix few issues, regenerate data (#17452)
[web-browser][web] Create state before open popup (#17222)
[web-browser][ios] Add `preferEphemeralSession` auth session option (#16926)* Native implementation * JS API changes * NCL, Regenerate docs * Update CHANGELOG Co-authored-by: Expo Bot <
[web-browser][ios] Add `preferEphemeralSession` auth session option (#16926)* Native implementation * JS API changes * NCL, Regenerate docs * Update CHANGELOG Co-authored-by: Expo Bot <[email protected]> Co-authored-by: Expo Bot <[email protected]>
[web-browser][ios] Add `modalPresentationStyle` option (#16919)* Native part * JS API * NCL * Update CHANGELOG Co-authored-by: Expo Bot <[email protected]> *
[web-browser][ios] Add `modalPresentationStyle` option (#16919)* Native part * JS API * NCL * Update CHANGELOG Co-authored-by: Expo Bot <[email protected]> * Generate docs * Apply suggestions - rework enum * Apply suggestion about platform * Workaround docs bug Co-authored-by: Expo Bot <[email protected]>
[lint] Add "caughtErrors: 'all'" to linter config (#16591)Why --- ES2019 added "optional catch bindings" so that `e`/`error`/etc. don't need to be specified in catch clauses if the thrown value i
[lint] Add "caughtErrors: 'all'" to linter config (#16591)Why --- ES2019 added "optional catch bindings" so that `e`/`error`/etc. don't need to be specified in catch clauses if the thrown value isn't used. This changes our lint rules to warn if unnecessary error variables are declared. https://2ality.com/2017/08/optional-catch-binding.html. In JS, as opposed to TS, we allow unused catch bindings if the variable names are prefixed with an underscore. This is so that JS targeting older JS interpreters can write `catch (_) {}` if needed. With TS we disallow unused catch bindings since tsc can compile code to its target JS version. How --- Added `caughtErrors: 'all'` to the no-unused-vars rule's configuration. As part of this change, I made the TypeScript linting rules apply only to .ts/.tsx/.ts.d files and updated the unit test snapshots. Test Plan --- Added unit tests to the linter. Ran linter over all modules in this repo with expotools.
Fix SDK tests after upgrading RN to 0.66
[web-browser] use platform annotations, update few comments (#15153)
[eslint-config] remove `arrowParens` overwrite, reformat files (#14232)
[android][web-browser] Fix `openAuthSessionAsync` stating browser is already open (#14181)
[eslint-config] bump dependencies and minimum required lint tools versions (#13858)Co-authored-by: James Ide <[email protected]>
Rename unimodules imports to expo-modules-core
[sdk] upgrade typescript to v4.3.5 (#14015)
[web-browser] add doc comments in source (#13189)# Why To utilize the auto generation feature for API section the package source code must contain the relevant documentation. Refs #12239 F
[web-browser] add doc comments in source (#13189)# Why To utilize the auto generation feature for API section the package source code must contain the relevant documentation. Refs #12239 Fixes ENG-1275 # How This PR moves the current documentation of `WebBrowser` API - https://docs.expo.io/versions/latest/sdk/webbrowser - (with minor tweaks and addition) to the package source code. Some of earlier undocumented parts were updated and described, but not all of them. The changeset includes the following improvement to the API Section and relative components code: * add support for rendering default values of fields in Types table * add support for rendering custom `Record` types * fix rendering of types set to constant, string or number value # Test Plan The changes and generated content have been tests running docs website on `localhost`. # Preview <img width="1541" alt="Screenshot 2021-06-07 at 17 51 57" src="https://user-images.githubusercontent.com/719641/121050684-13ccd400-c7b9-11eb-8b95-5ed7c65c64f6.png">
[android][web-browser] Add option to not open browser in new task (#12462)# Why The addition of this option can improve the user experience for users of apps using this dependency. By not naviga
[android][web-browser] Add option to not open browser in new task (#12462)# Why The addition of this option can improve the user experience for users of apps using this dependency. By not navigating "outside" of the app but instead keeping the users within the app will provide a more seamless experience. I found an issue addressing this [here](https://github.com/expo/expo/issues/11963). This addition will also make the user experience for iOS and Android similar, as the iOS implementation already does this by default. # How I created an additional browser option for Android called `createTask` which prevents the addition of the flag This resulted in the expected behaviour of the feature and it still maintained the capability of linking back to the application in case of authentication flow. The default value of this option is set to `true`, which essentially will act in the same way prior to this feature. # Test Plan I primarily used the bare-expo app on an emulator running Chrome to be as close as possible to simulate how it would work in practice. In the following demo I show how it works in the bare-expo app using both `openBrowserAsync()` and `openAuthSessionAsync`.  I also added an additional test case to the native tests to make sure the intent flags are set correctly. <img width="592" alt="Screen Shot 2021-04-08 at 23 31 45" src="https://user-images.githubusercontent.com/10698008/114099129-9d981800-98c2-11eb-83f0-d89bd42e477c.png">
123