| e3b54587 | 23-Mar-2023 |
Douglas Lowder <[email protected]> |
[expo-updates][Android] Fix missing manifest for flavor variants (#21813)
# Why
Fixes #21382 .
When Android flavor variants are used, builds will not contain the
embedded manifest for `expo-u
[expo-updates][Android] Fix missing manifest for flavor variants (#21813)
# Why
Fixes #21382 .
When Android flavor variants are used, builds will not contain the
embedded manifest for `expo-updates`. This gradle patch fixes this
issue.
# How
Modify `packages/expo-updates/scripts/create-manifest-android.gradle` to
add the new location from which to copy the manifest asset. Add
duplicate policy to handle cases where the manifest may be copied more
than once.
# Test Plan
- Create a new bare workflow project from SDK 48
- Modify `android/app/build.gradle` similarly to this patch:
```diff
--- android/app/build.gradle.orig 2023-03-22 11:00:43.000000000 -0700
+++ android/app/build.gradle 2023-03-09 11:57:31.000000000 -0800
@@ -150,6 +150,12 @@
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
}
}
+ flavorDimensions "default"
+ productFlavors {
+ development {
+ applicationId "com.douglowderexpo.bareworkflow48"
+ }
+ }
// applicationVariants are e.g. debug, release
applicationVariants.all { variant ->
variant.outputs.each { output ->
```
Before making this change, the `:app:installDevelopmentRelease` task
would produce a build with the updates manifest missing, and therefore
would not start.
After this change, the above build will run correctly.
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [x] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [x] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [x] This diff will work correctly for `expo prebuild` & EAS Build (eg:
updated a module plugin).
show more ...
|